Hi please add support for svg in logo with fallback to png if the browser or screen dosent support svg please.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Add support for SVGs to $wgLogoHD with PNG fallback | mediawiki/core | master | +237 -42 |
Event Timeline
It has to do with
/**
- @param $context ResourceLoaderContext
- @return array
*/
public function getStyles( ResourceLoaderContext $context ) {
$logo = $this->getConfig()->get( 'Logo' ); $styles = parent::getStyles( $context ); $styles['all'][] = '.mw-wiki-logo { background-image: ' . CSSMin::buildUrlValue( $logo ) . '; }'; return $styles;
}
in file ResourceLoaderSkinModule.php. The file should use less and then add .background-image.svg( ) and in $logo in localsettings.ph do something like $logo = 'image.svg', 'image.png';
Change 193434 had a related patch set uploaded (by Paladox):
Add support for svg with png fallback for logo
What's going on? Is there any negative review making it stuck? Or still waiting for any review?
@Dvorapa: See https://gerrit.wikimedia.org/r/#/c/193434/ (linked from T86229#1074657) and the code review comments there.
This https://gerrit.wikimedia.org/r/#/c/193434/ works, this will allow us to use svg images on Wikipedia whilst falling back to png on browsers that doint support svg :).
Change 193434 had a related patch set uploaded (by Paladox):
[mediawiki/core] Add support for svg with png fallback for logo
Change 193434 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/core@master] Add support for svg with png fallback for logo
Changing priority due to activity on the patch. Looks to be merged soon once one problem is resolved on the patch :)
Change 193434 merged by jenkins-bot:
[mediawiki/core@master] Add support for SVGs to $wgLogoHD with PNG fallback