Page MenuHomePhabricator
Create Task
Maniphest T87043

General DonationInterface code cleanup
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Tracking task for any cleanup work.

Details

SubjectRepoBranchLines +/-
Fix PHP CodeSniffer issuesmediawiki/extensions/DonationInterfacemaster+3 -4
Remove unused api_request stuffmediawiki/extensions/DonationInterfacemaster+3 -42
Don't senselessly repeat base class codemediawiki/extensions/DonationInterfacemaster+2 -18
Cleanupmediawiki/extensions/DonationInterfacemaster+6 -45
Burn a small book of unused codemediawiki/extensions/DonationInterfacemaster+0 -1 K
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jan 16 2015, 6:23 PM
awight raised the priority of this task from to Medium.
awight updated the task description. (Show Details)
awight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2015, 6:23 PM
gerritbot added a project: Patch-For-Review.Jan 16 2015, 6:23 PM
gerritbot subscribed.

Change 184849 had a related patch set uploaded (by Awight):
Burn a small book of unused code

https://gerrit.wikimedia.org/r/184849

Patch-For-Review

gerritbot added a comment.Jan 16 2015, 6:23 PM

Change 184844 had a related patch set uploaded (by Awight):
Cleanup

https://gerrit.wikimedia.org/r/184844

Patch-For-Review

awight added a comment.Jan 16 2015, 6:25 PM

https://gerrit.wikimedia.org/r/#/c/185355/

awight updated the task description. (Show Details)Jan 16 2015, 6:27 PM
awight added projects: MediaWiki-extensions-DonationInterface, § Fundraising Sprint Beastie Boys.
awight set Security to None.
awight moved this task from In Analysis to In Development on the § Fundraising Sprint Beastie Boys board.Jan 16 2015, 6:30 PM

https://gerrit.wikimedia.org/r/#/c/184852/

• atgo edited a custom field.Jan 16 2015, 7:56 PM
gerritbot added a comment.Jan 24 2015, 12:21 AM

Change 184849 merged by jenkins-bot:
Burn a small book of unused code

https://gerrit.wikimedia.org/r/184849

awight mentioned this in rEDOI1eed0e8d77a7: Burn a small book of unused code.Jan 24 2015, 12:25 AM
• atgo added a project: § Fundraising Sprint the Cure.Jan 28 2015, 11:38 PM
• atgo moved this task from In Analysis to In Development on the § Fundraising Sprint the Cure board.
• atgo assigned this task to awight.Jan 29 2015, 12:47 AM
gerritbot added a comment.Jan 29 2015, 8:02 PM

Change 184844 merged by jenkins-bot:
Cleanup

https://gerrit.wikimedia.org/r/184844

Ejegg mentioned this in rEDOI94a9eb32ae34: Cleanup.Jan 29 2015, 8:20 PM
• atgo moved this task from Backlog to Sometime on the MediaWiki-extensions-DonationInterface board.Jan 29 2015, 9:30 PM
Ejegg moved this task from In Development to Pending Deployment on the § Fundraising Sprint the Cure board.Feb 2 2015, 9:06 PM
awight added a comment.Feb 5 2015, 7:10 AM

https://gerrit.wikimedia.org/r/#/c/184852/ was merged.

awight renamed this task from General DonationInterface code cleanup to Tracking: General DonationInterface code cleanup.Feb 5 2015, 7:11 AM
awight removed projects: § Fundraising Sprint the Cure, § Fundraising Sprint Beastie Boys, Patch-For-Review.
gerritbot added a project: Patch-For-Review.Feb 6 2015, 11:54 PM

Change 189134 had a related patch set uploaded (by Awight):
Don't senselessly repeat base class code

https://gerrit.wikimedia.org/r/189134

Patch-For-Review

awight added a comment.Feb 9 2015, 11:47 PM

I like this one: https://gerrit.wikimedia.org/r/#/c/189615/

awight added projects: Fundraising-Backlog-Old, Wikimedia-Fundraising.Feb 9 2015, 11:47 PM
gerritbot added a comment.Feb 24 2015, 1:11 AM

Change 189134 merged by jenkins-bot:
Don't senselessly repeat base class code

https://gerrit.wikimedia.org/r/189134

Ejegg mentioned this in rEDOI5bf284e10fa3: Don't senselessly repeat base class code.Feb 24 2015, 1:11 AM
Diffusion mentioned this in rMEXTc40e39460ec2: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:24 AM
awight mentioned this in rMEXTd5313b1e4675: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:25 AM
awight mentioned this in rMEXT9843db98bb86: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 11 2015, 6:27 AM
• atgo added a project: Fundraising-Backlog.Jul 30 2015, 10:15 PM
• atgo removed a project: Wikimedia-Fundraising.Jul 30 2015, 10:49 PM
• atgo removed a project: Fundraising-Backlog.Jul 31 2015, 9:02 PM
awight removed awight as the assignee of this task.Feb 7 2016, 1:25 AM
Danny_B renamed this task from Tracking: General DonationInterface code cleanup to General DonationInterface code cleanup (tracking).May 31 2016, 3:40 PM
Danny_B added a project: Tracking-Neverending.
Danny_B renamed this task from General DonationInterface code cleanup (tracking) to General DonationInterface code cleanup.Jul 11 2016, 6:28 PM
Danny_B removed a project: Tracking-Neverending.
• DStrine added a project: Fundraising-Backlog.Aug 5 2016, 8:49 PM
• DStrine moved this task from Triage to from tech backlog on the Fundraising-Backlog board.Aug 5 2016, 8:53 PM
gerritbot added a comment.Jan 23 2017, 8:44 PM

Change 332971 had a related patch set uploaded (by Ejegg):
Remove unused api_request stuff

https://gerrit.wikimedia.org/r/332971

gerritbot added a comment.Jan 27 2017, 6:12 PM

Change 332971 merged by jenkins-bot:
Remove unused api_request stuff

https://gerrit.wikimedia.org/r/332971

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 27 2017, 7:00 PM
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), Patch-For-Review.May 25 2017, 2:02 PM
Krinkle subscribed.

Is this resolved?

• mmodell removed a subscriber: awight.Jun 22 2017, 9:33 PM
gerritbot added a comment.Jun 5 2018, 8:05 AM

Change 437402 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/DonationInterface@master] Fix PHP CodeSniffer issues

https://gerrit.wikimedia.org/r/437402

gerritbot added a project: Patch-For-Review.Jun 5 2018, 8:05 AM
gerritbot added a comment.Jun 5 2018, 6:53 PM

Change 437402 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix PHP CodeSniffer issues

https://gerrit.wikimedia.org/r/437402

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 5 2018, 7:01 PM
Krinkle unsubscribed.Jun 6 2018, 8:00 PM
Umherirrender closed this task as Resolved.Apr 5 2022, 6:19 PM
Umherirrender removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL