Change 185815 had a related patch set uploaded (by John Vandenberg):
PEP8 and PEP257 fixes

https://gerrit.wikimedia.org/r/185815

Patch-For-Review

Change 185815 merged by jenkins-bot:
PEP8 and PEP257 fixes

https://gerrit.wikimedia.org/r/185815

@Legoktm pointed me towards this as where the mediawiki linter is hardwired into jenkins
https://github.com/wikimedia/integration-config/blob/master/jjb/job-templates.yaml#L138

@jayvdb: This task has "Unbreak now" priority since January 2015 which seems unrealistic.
Are you working on this, or should the priority value be corrected?

@Aklapper, I was hoping the CI team might fix this regression created by @hashar. https://lists.wikimedia.org/pipermail/pywikipedia-l/2015-January/009214.html

My hacky idea is to have a pywikibot-core-tox-flake8 job that only runs if "tox.ini" is *not* touched for non-whitelisted users. Whitelisted users (and on gate-and-submit) we would run the normal tox-flake8 job.

Is pep257 part of flake8? or is that flake8-docstrings?

@Legoktm, that sounds much better than the current situation - tox.ini changes are very rare by non-whitelisted users.

package flake8-docstrings is the wrapper around pep257.

tox.ini entry flake8-docstrings is non-voting, so ignore that one.

flake8 , flake8-py3 and flake8-docstrings-mandatory (pep257) are the important entries in tox.ini

Any decision / movement is welcome here (I repeat myself by saying that this task has "Unbreak now" priority since January 2015 so if this is not "drop anything else and fix this", please decrease the Priority value!).

@hashar, this can be resolved if jenkins runs tox instead of specific commands, and runs them for non-whitelisted users (that is a separate task somewhere?).

Currently tox.ini is:

envlist = flake8,flake8-py3,flake8-docstrings-mandatory,py26,py27,py34

Do we need to change that?

Currently the Zuul conf has:

- name: pywikibot/core
  test:
    - tox-flake8
    - pywikibot-core-tox-flake8-py3-jessie
    - pywikibot-core-tox-flake8-docstrings
    - pywikibot-core-tox-flake8-docstrings-mandatory
    - pywikibot-core-tox-nose
    - pywikibot-core-tox-nose34-jessie
    - tox-doc-jessie
  gate-and-submit:
    - tox-flake8
    - pywikibot-core-tox-flake8-py3-jessie
    - pywikibot-core-tox-flake8-docstrings-mandatory
    - pywikibot-core-tox-nose
    - pywikibot-core-tox-nose34-jessie
    - tox-doc-jessie

We can replace most of that with tox-jessie.

Do we need to remove py26 from the envlist in tox.ini? If we get linting working again, it sounds like a good deal!

The tox envlist has:

flake8
flake8-py3
flake8-docstrings-mandatory
py26
py27
py34

Running all of them ends up taking 11 minutes IIRC. Potentially we could use detox to have them run in parallel.

python2.6 is no more available on Jessie. But we can keep a job running on Trusty where it is available. And if we keep py26 split, we can well keep py27,py34 split.

What I found out is that tox supports a specific env jenkins which is to override setting when tox detects it runs under Jenkins (i.e.: when env variable JENKINS_URL is set). We can probably abuse that feature to override envlist in Jenkins context and aggregate the lint/doc envs. So potentially:

tox.ini

[tox]
# Defaults env targets for developers
envlist = flake8,flake8-py3,flake8-docstrings-mandatory,py26,py27,py34

[testenv:jenkins]
# Override default for Jenkins
# The py26,py27,py34 run in their own individual jobs on WMF Jenkins
envlist = flake8,flake8-py3,flake8-docstrings-mandatory,doc

And In Zuul:

 - name: pywikibot/core
   test:
-    - tox-flake8
-    - pywikibot-core-tox-flake8-py3-jessie
     - pywikibot-core-tox-flake8-docstrings  # non voting
-    - pywikibot-core-tox-flake8-docstrings-mandatory
     - pywikibot-core-tox-nose
     - pywikibot-core-tox-nose34-jessie
-    - tox-doc-jessie
+    - tox-jessie  # runs envs from testenv::jenkins ie: flake8,flake8-py3,flake8-docstrings-mandatory,doc
   gate-and-submit:
-    - tox-flake8
-    - pywikibot-core-tox-flake8-py3-jessie
-    - pywikibot-core-tox-flake8-docstrings-mandatory
     - pywikibot-core-tox-nose
     - pywikibot-core-tox-nose34-jessie
-    - tox-doc-jessie
+    - tox-jessie  # runs envs from testenv::jenkins ie: flake8,flake8-py3,flake8-docstrings-mandatory,doc

That aggregates flake8/doc, but that might end up being over complicated to maintain.

Also I noticed we run the nose/nose34 envs, not the py27, py34 ones. Maybe that can be revisited as well.

11 minutes is IMO acceptable. That is roughly how long the jenkins job took before the recent upgrades.

If py26 is taking a considerable amount of that timeframe, we could kill it and/or replace it with a flake8-py26 which would catch 95% of the problems -- at least flake8-py26 would catch all the easy problems ; the hard ones can be handled as post-commit fixes when someone is interested.

Note, detox on pypi says it is Python 2 only, but this commit says otherwise.

In T87169#1711901, @jayvdb wrote:

Note, detox on pypi says it is Python 2 only, but this commit says otherwise.

According to https://pypi.python.org/pypi/detox/ "supports creation of python3 and all environments supported of the underlying “tox” command".

In T87169#1718474, @JanZerebecki wrote:

In T87169#1711901, @jayvdb wrote:

Note, detox on pypi says it is Python 2 only, but this commit says otherwise.

According to https://pypi.python.org/pypi/detox/ "supports creation of python3 and all environments supported of the underlying “tox” command".

Right; they were in the process of changing the documentation.

To get detox to be available on the salves one needs to add it to operations/puppet.git/modules/contint/manifests/packages/python.pp just like tox is installed from that file via pip (there seems to be no debian package). Then test that that works on all 3 distributions, get it merged, then make a new image for nodepool. But that can wait, changing the tox.ini as said in T87169#1711877 is probably the next step here. Once that works with check experimental it can be enabled for everyone.

Change 245582 had a related patch set uploaded (by JanZerebecki):
Add tox default envs for WM Jenkins

https://gerrit.wikimedia.org/r/245582

Change 245582 merged by jenkins-bot:
Add tox default envs for WM Jenkins

https://gerrit.wikimedia.org/r/245582

Change 247291 had a related patch set uploaded (by JanZerebecki):
Replace some pywikibot/core jobs with the generic tox-jessie version.

https://gerrit.wikimedia.org/r/247291

Change 247291 merged by jenkins-bot:
Replace some pywikibot/core jobs with the generic tox-jessie version.

https://gerrit.wikimedia.org/r/247291

@hashar Can we add the tox-jessie job also to the check pipeline to make it run for everone? Or is something still blocking that?

We talked about this during the CI weekly and while T86168 is not yet done, it is fine to go ahead and use nodepool based jobs in the check or check-voter pipeline.

Change 247623 had a related patch set uploaded (by JanZerebecki):
pywikibot/core: also run tox-jessie in check pipeline

https://gerrit.wikimedia.org/r/247623

Change 247623 merged by jenkins-bot:
pywikibot/core: also run tox-jessie in check pipeline

https://gerrit.wikimedia.org/r/247623

The tox-jessie job now runs for non-whitelisted users. Example: https://gerrit.wikimedia.org/r/#/c/241283/ .

PAH! Anyway ;) The tasks to watch are probably https://gerrit.wikimedia.org/r/243487, https://gerrit.wikimedia.org/r/246791 or https://gerrit.wikimedia.org/r/247041.

Change 248714 had a related patch set uploaded (by John Vandenberg):
Add tox default envs for WM Jenkins

https://gerrit.wikimedia.org/r/248714

Change 248714 merged by jenkins-bot:
Add tox default envs for WM Jenkins

https://gerrit.wikimedia.org/r/248714