Page MenuHomePhabricator
Create Task
Maniphest T87396

Non-Flow pages can be moved to the Topic namespace, and cannot be moved back
Closed, ResolvedPublic
Actions

Description

On enwiki's village pump today it was reported that a user moved the page Kuttiattoor Thittayil Sree Daivathar Temple to Topic:Kuttiattoor Thittayil Sree Daivathar Temple and administrators can't move it back. When a move is attempted with Special:MovePage the following error message is displayed: "You do not have permission to move this page, for the following reason: Moving a discussion board is currently not supported."

We need two things to happen here:

  1. Someone to edit the database to move "Topic:Kuttiattoor Thittayil Sree Daivathar Temple" back to "Kuttiattoor Thittayil Sree Daivathar Temple", and check if any other pages might be affected.
  2. MediaWiki/Flow to be patched to not allow pages to be moved to the Topic namespace.

Details

SubjectRepoBranchLines +/-
Live hack to allow repair of page in wrong namespacemediawiki/extensions/Flowwmf/1.25wmf14+6 -1
Live hack to allow repair of page in wrong namespacemediawiki/extensions/Flowmaster+6 -1
Disallow moving in Topic: namespacemediawiki/extensions/Flowwmf/1.25wmf15+11 -0
Disallow moving in Topic: namespacemediawiki/extensions/Flowwmf/1.25wmf14+11 -0
Disallow moving in Topic: namespacemediawiki/extensions/Flowmaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

MrStradivarius created this task.Jan 22 2015, 11:32 PM
MrStradivarius raised the priority of this task from to Unbreak Now!.
MrStradivarius updated the task description. (Show Details)
MrStradivarius added projects: StructuredDiscussions, acl*sre-team.
MrStradivarius subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2015, 11:32 PM
MrStradivarius updated the task description. (Show Details)Jan 22 2015, 11:42 PM
MrStradivarius set Security to None.
Nihiltres subscribed.Jan 23 2015, 12:05 AM
Nihiltres added a comment.Jan 23 2015, 12:11 AM

There might be a use-case for moving stuff to/from the Topic namespace, but until one's established, and pages can be moved back, I agree it should be disallowed. I've set up filter 658 to help prevent it from happening again in the meantime.

matthiasmullie subscribed.Jan 23 2015, 12:15 AM
matthiasmullie added a project: Collaboration-Team-Triage.Jan 23 2015, 12:18 AM
Krenair subscribed.Jan 23 2015, 12:23 AM
Technical13 subscribed.Jan 23 2015, 12:52 AM

An Abuse filter isn't a very sound way to deal with this. It wouldn't be hard to eliminate that option from the menu with JavaScript in MediaWiki:Common.js.

if ( mw.config.get( 'wgCanonicalNamespace' ) === "Special" && mw.config.get( 'wgCanonicalSpecialPageName' ) === "Movepage" ) {
    $( '#wpNewTitleNs option[value=2600]' ).remove();
}

Would probably be a better band-aid if one is needed.

TTO edited projects, added Shell; removed acl*sre-team.Jan 23 2015, 1:07 AM
Nihiltres added a comment.Jan 23 2015, 1:47 AM

What's unsound about using an edit filter? It's the surest way to prevent other moves to the namespace from happening. That client-side fix could be accidentally or maliciously bypassed simply by disabling JavaScript. That said, it seems like a good idea to make the option invisible as well as using a filter.

matmarex subscribed.Jan 23 2015, 2:30 AM

Flow must implement the NamespaceIsMovable hook to disable page moves for its namespaces.

Krenair added a subscriber: TTO.Jan 23 2015, 2:33 AM

@TTO: You added the shell project. What is there for us to do here exactly?

Jackmcbarn subscribed.Jan 23 2015, 2:34 AM
In T87396#990540, @Krenair wrote:

@TTO: You added the shell project. What is there for us to do here exactly?

Revert the page move mentioned in the task description.

Krenair added a comment.Jan 23 2015, 2:37 AM

Right, sorry.

Quiddity subscribed.Jan 23 2015, 5:02 AM
In T87396#990543, @Jackmcbarn wrote:
In T87396#990540, @Krenair wrote:

@TTO: You added the shell project. What is there for us to do here exactly?

Revert the page move mentioned in the task description.

I believe the Flow team can deal with this tomorrow (~16 hours), if someone else doesn't beforehand.

• Rdicerb subscribed.Jan 23 2015, 6:22 AM
TTO lowered the priority of this task from Unbreak Now! to High.Jan 23 2015, 9:29 AM
TTO updated the task description. (Show Details)

No longer requires manual DB manipulation, as the article was deleted. It would still be nice to make sure nothing else has gotten moved into Topic space though.

MrStradivarius raised the priority of this task from High to Unbreak Now!.Jan 23 2015, 2:23 PM
MrStradivarius added a comment.Jan 23 2015, 2:27 PM

I've bumped the priority back up. The urgency of this isn't in fixing the page on enwiki that was moved, but the potential for page-move vandalism on other wikis where Flow is enabled. If we can't roll out a patch for this in the next few hours then someone with global sysop rights should add a temporary edit filter preventing these moves on each affected wiki.

gerritbot added a project: Patch-For-Review.Jan 23 2015, 2:47 PM
gerritbot subscribed.

Change 186351 had a related patch set uploaded (by Matthias Mullie):
Disallow moving in Topic: namespace

https://gerrit.wikimedia.org/r/186351

Patch-For-Review

matthiasmullie added a comment.Jan 23 2015, 3:00 PM

I like the AbuseFilter that was added as a stopgap, very clever!

Above patch should disallow moving pages into the topic namespace

So far, there haven't been any other similar occurences on any of the wikis that Flow is currently deployed at. I'll check that again once we've deployed this patch, to make sure nothing happens between now & then.

gerritbot added a comment.Jan 23 2015, 3:29 PM

Change 186353 had a related patch set uploaded (by Matthias Mullie):
Disallow moving in Topic: namespace

https://gerrit.wikimedia.org/r/186353

Patch-For-Review

gerritbot added a comment.Jan 23 2015, 3:29 PM

Change 186354 had a related patch set uploaded (by Matthias Mullie):
Disallow moving in Topic: namespace

https://gerrit.wikimedia.org/r/186354

Patch-For-Review

Jackmcbarn added a comment.Jan 23 2015, 6:05 PM
In T87396#990828, @TTO wrote:

No longer requires manual DB manipulation, as the article was deleted. It would still be nice to make sure nothing else has gotten moved into Topic space though.

I think the deleted revisions are in the wrong place, though.

• DannyH moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Jan 23 2015, 6:30 PM
gerritbot added a comment.Jan 23 2015, 6:49 PM

Change 186351 merged by jenkins-bot:
Disallow moving in Topic: namespace

https://gerrit.wikimedia.org/r/186351

gerritbot added a comment.Jan 23 2015, 6:50 PM

Change 186353 merged by jenkins-bot:
Disallow moving in Topic: namespace

https://gerrit.wikimedia.org/r/186353

matthiasmullie moved this task from Sprint O (ends Jan 27) to Product Review on the Collaboration-Team-Triage board.Jan 23 2015, 6:50 PM
gerritbot added a comment.Jan 23 2015, 6:50 PM

Change 186354 merged by jenkins-bot:
Disallow moving in Topic: namespace

https://gerrit.wikimedia.org/r/186354

matthiasmullie claimed this task.Jan 23 2015, 6:51 PM
matthiasmullie mentioned this in rEFLWa212ff68fc29: Disallow moving in Topic: namespace.Jan 23 2015, 6:51 PM
matthiasmullie mentioned this in rEFLWfac6fe11ea70: Disallow moving in Topic: namespace.
matthiasmullie mentioned this in rEFLWd817cc016718: Disallow moving in Topic: namespace.
EBernhardson subscribed.Jan 23 2015, 7:09 PM

The patch to prevent moves into NS_TOPIC has been deployed to all wikis, we are discussing the best way to put the history of the deleted page back into the main namespace.

• Mattflaschen-WMF subscribed.Jan 23 2015, 7:32 PM

When we looked at it this morning, some of the deleted page content was in the right place, but not all. We're working on repairing this right now, so all of the deleted content is in the right place and could (if appropriate) be undeleted normally.

gerritbot added a comment.Jan 23 2015, 8:10 PM

Change 186395 had a related patch set uploaded (by Mattflaschen):
Live hack to allow repair of page in wrong namespace

https://gerrit.wikimedia.org/r/186395

Patch-For-Review

gerritbot added a comment.Jan 23 2015, 8:19 PM

Change 186399 had a related patch set uploaded (by Mattflaschen):
Live hack to allow repair of page in wrong namespace

https://gerrit.wikimedia.org/r/186399

Patch-For-Review

• Mattflaschen-WMF closed this task as Resolved.Jan 23 2015, 8:52 PM

The underlying bug is fixed (pages can not be moved to the Topic namespace again). The deleted content from Kuttiattoor Thittayil Sree Daivathar Temple has also now been moved back to the right namespace (and can be undeleted/re-deleted/whatever) normally if needed.

Let us know if you see any other problems.

gerritbot added a comment.Jan 23 2015, 9:19 PM

Change 186395 abandoned by Matthias Mullie:
Live hack to allow repair of page in wrong namespace

Reason:
Killing this patch, it's been executed

https://gerrit.wikimedia.org/r/186395

gerritbot added a comment.Jan 23 2015, 9:19 PM

Change 186399 abandoned by Matthias Mullie:
Live hack to allow repair of page in wrong namespace

Reason:
Killing this patch, it's been executed

https://gerrit.wikimedia.org/r/186399

RandomDSdevel awarded a token.Mar 2 2015, 10:08 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
matthiasmullie mentioned this in rMEXTa5a2b0ffbc53: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits