Page MenuHomePhabricator
Create Task
Maniphest T87538

That file type is forbidden: ogg
Closed, ResolvedPublic
Actions

Description

UploadWizard currently does not allow to upload .ogg files. This is a huge problem. Following error:
F31845

It works with Special:Upload.

See reports at:
https://commons.wikimedia.org/wiki/Commons:Upload_help#Forbidden_OGG_file_type_.3F
https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#error_uploading_ogg-Files
https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#Ogg_files_upload:_.22this_type_of_file_is_banned.22
https://commons.wikimedia.org/wiki/Commons:Upload_help#File_name_not_allowed_.28.E2.80.9EDieser_Dateiname_ist_nicht_erlaubt.22.29
https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#Ogg_files_upload:_.22this_type_of_file_is_banned.22

T87062 seems related, but i can't access (permission error).

Details

SubjectRepoBranchLines +/-
Bring UploadWizard submodule up to datemediawiki/corewmf/1.25wmf14+1 -1
Bring UploadWizard submodule up to datemediawiki/corewmf/1.25wmf15+1 -1
Fix formdata filename fieldmediawiki/extensions/UploadWizardwmf/1.25wmf14+1 -1
Fix formdata filename fieldmediawiki/extensions/UploadWizardwmf/1.25wmf15+1 -1
Fix formdata filename fieldmediawiki/extensions/UploadWizardmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Steinsplitter created this task.Jan 25 2015, 3:38 PM
Steinsplitter raised the priority of this task from to High.
Steinsplitter updated the task description. (Show Details)
Steinsplitter added a project: UploadWizard.
Steinsplitter added subscribers: Steinsplitter, Bawolff.
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 25 2015, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Steinsplitter set Security to None.Jan 25 2015, 3:40 PM
Steinsplitter added a subscriber: MarkTraceur.
Steinsplitter added subscribers: • Gilles, Tgr.
Steinsplitter updated the task description. (Show Details)Jan 25 2015, 3:43 PM
Steinsplitter updated the task description. (Show Details)Jan 25 2015, 3:52 PM
Bawolff added a comment.Jan 25 2015, 7:14 PM

I guess this must be intermittent, as the following files were recently (within the last couple hours) uploaded with uploadWizard:

https://commons.wikimedia.org/wiki/File:Ver_foto_no_fb_zero.mp4.ogg
https://commons.wikimedia.org/wiki/File:13_I%C3%82%C2%B4m_your_Angel.ogg (Looks like a copyvio...)

Bawolff added a comment.Jan 25 2015, 7:31 PM

I was able to reproduce with [[File:Mg-ady_am-panarahana.ogg]]

Error from api is:
{"servedby":"mw1017","error":{"code":"filetype-banned","info":"Filetype not permitted: ogx","filetype":"ogx","allowed":["png","gif","jpg","jpeg","tiff","tif","xcf","pdf","mid","ogg","ogv","svg","djvu","oga","flac","wav","webm"],"*":"See https://test.wikipedia.org/w/api.php for API usage"}}

So I guess its considering it to be an ogx instead of a .oga (or .ogg) like it should. MediaWiki should be considering ogx an alias of .ogg...

Steinsplitter added a comment.Jan 25 2015, 7:54 PM

I tested it with File:De-Deutschland.ogg and got the error. :/ So there has changed something in the last time?

MariaDB [commonswiki_p]> SELECT
    -> img_media_type,
    -> img_major_mime,
    -> img_minor_mime,
    -> img_sha1
    -> FROM image
    -> WHERE img_name = "De-Deutschland.ogg";
+----------------+----------------+----------------+---------------------------------+
| img_media_type | img_major_mime | img_minor_mime | img_sha1                        |
+----------------+----------------+----------------+---------------------------------+
| AUDIO          | application    | ogg            | 8fh3yibfcdm91ir2l14wmr0hckvp0j9 |
+----------------+----------------+----------------+---------------------------------+
1 row in set (0.00 sec)
Bawolff added a comment.Jan 25 2015, 7:57 PM

I think its something funky with how file detection is working (possibly if auto-detected as audio/ogg or application/ogg). I uploaded [[File:Random_ogg_test.ogg]] to testwiki just fine, but Mg-ady_am-panarahana.ogg fails, and I can't really tell what would be different between the two (they're both short vorbis audio files).

Bawolff added a comment.Jan 25 2015, 8:49 PM

I suspect this is failing on upload wizard but not Special:Upload due to how stashed files throw away the originial extension, where I don't think Special:Upload does.

So the most obvious fix would be to change mime.types to make .ogg the canonical extension for application/ogg (technically against rfc 5334), instead of .ogx (which it is currently). Or perhaps just enable .ogx as an allowed extension on commons.

Its unclear to me why this is suddenly failing now.

Bawolff added a comment.Jan 25 2015, 9:17 PM

Hmm, I noticed that uploadwizard is sending filename=undefined in the ajax request, maybe that's somehow triggering this.

Note, that second time around uploading [[File:Random_ogg_test.ogg]] it didn't work, so I'm not sure what I did the first time.

Tgr added a subtask: T87555: UploadWizard does not set filename for stash upload AJAX request.Jan 26 2015, 5:07 AM

Created a new bug for the missing filename issue as T87062 is still private (bah).

Steinsplitter added a comment.Jan 26 2015, 5:30 PM

Whiteisting ogx should solve this problem? If yes, can we do that please?

Steinsplitter updated the task description. (Show Details)Jan 27 2015, 6:19 PM
Aklapper added a comment.Jan 28 2015, 8:32 PM
In T87538#994114, @Tgr wrote:

Created a new bug for the missing filename issue as T87062 is still private (bah).

Sorry. It's public again now

gerritbot added a project: Patch-For-Review.Jan 29 2015, 1:41 AM
gerritbot subscribed.

Change 187317 had a related patch set uploaded (by Gilles):
Fix formdata filename field

https://gerrit.wikimedia.org/r/187317

Patch-For-Review

• Gilles claimed this task.Jan 29 2015, 1:42 AM
• Gilles moved this task from Untriaged to Needs code review on the Multimedia board.
gerritbot added a comment.Jan 29 2015, 6:47 PM

Change 187317 merged by jenkins-bot:
Fix formdata filename field

https://gerrit.wikimedia.org/r/187317

• Gilles mentioned this in rEUWI10a8fec19be5: Fix formdata filename field.Jan 29 2015, 6:49 PM
• Gilles moved this task from Needs code review to Ready for testing on the Multimedia board.Jan 29 2015, 7:25 PM
• Gilles moved this task from Ready for testing to Needs backport on the Multimedia board.Jan 30 2015, 5:19 PM
gerritbot added a comment.Jan 30 2015, 5:29 PM

Change 187697 had a related patch set uploaded (by Gilles):
Fix formdata filename field

https://gerrit.wikimedia.org/r/187697

Patch-For-Review

gerritbot added a comment.Jan 30 2015, 5:31 PM

Change 187698 had a related patch set uploaded (by Gilles):
Fix formdata filename field

https://gerrit.wikimedia.org/r/187698

Patch-For-Review

gerritbot added a comment.Jan 30 2015, 5:34 PM

Change 187699 had a related patch set uploaded (by Gilles):
Bring UploadWizard submodule up to date

https://gerrit.wikimedia.org/r/187699

Patch-For-Review

gerritbot added a comment.Jan 30 2015, 5:34 PM

Change 187697 merged by jenkins-bot:
Fix formdata filename field

https://gerrit.wikimedia.org/r/187697

gerritbot added a comment.Jan 30 2015, 5:34 PM

Change 187698 merged by jenkins-bot:
Fix formdata filename field

https://gerrit.wikimedia.org/r/187698

• Gilles mentioned this in rEUWId01e476219a1: Fix formdata filename field.Jan 30 2015, 5:35 PM
• Gilles mentioned this in rEUWI20eddf339fbc: Fix formdata filename field.
gerritbot added a comment.Jan 30 2015, 5:37 PM

Change 187700 had a related patch set uploaded (by Gilles):
Bring UploadWizard submodule up to date

https://gerrit.wikimedia.org/r/187700

Patch-For-Review

gerritbot added a comment.Feb 2 2015, 5:16 PM

Change 187699 merged by MarkTraceur:
Bring UploadWizard submodule up to date

https://gerrit.wikimedia.org/r/187699

gerritbot added a comment.Feb 2 2015, 5:16 PM

Change 187700 merged by MarkTraceur:
Bring UploadWizard submodule up to date

https://gerrit.wikimedia.org/r/187700

MarkTraceur mentioned this in rMWae8342ad1aa9: Bring UploadWizard submodule up to date.Feb 2 2015, 5:17 PM
MarkTraceur mentioned this in rMW92e0575ba41c: Bring UploadWizard submodule up to date.
MarkTraceur moved this task from Needs backport to Doing on the Multimedia board.Feb 4 2015, 5:50 PM
MarkTraceur closed this task as Resolved.Feb 6 2015, 9:32 PM

I believe this is fixed!

RandomDSdevel awarded a token.Mar 5 2015, 7:12 PM
• Gilles mentioned this in rMEXT10bbdbeb6b76: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:25 AM
Jdforrester-WMF moved this task from Doing to Done on the Multimedia board.Oct 23 2015, 4:59 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptOct 23 2015, 4:59 PM
MarkTraceur closed subtask T87555: UploadWizard does not set filename for stash upload AJAX request as Resolved.Dec 7 2015, 6:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL