Page MenuHomePhabricator

Support data-mw.body.id for reference contents
Closed, ResolvedPublic8 Estimated Story Points

Description

Old format:

<span typeof="mw:Extension/ref" data-mw='{"name":"ref","body":{"html":"Hello <b>world</b>"}}'>[...]</span>

New format:

<span typeof="mw:Extension/ref" data-mw='{"name":"ref","body":{"id":"mw-cite-foo"}}'>[...]</span>
[...]
<ol typeof="mw:Extension/references">
    <li about="#cite_note-3" id="cite_note-3"><span rel="mw:referencedBy">[...]</span> <span id="mw-cite-foo">Hello <b>world</b></span></li>
    [...]
</ol>

For backwards compatibility, both formats should be supported. Changes to reference contents should always be reflected in data-mw.body.html: if a reference using data-mw.body.id is changed, a data-mw.body.html attribute should be added with the new HTML.

Event Timeline

Catrope claimed this task.
Catrope raised the priority of this task from to Medium.
Catrope updated the task description. (Show Details)
Catrope set Security to None.
Catrope edited a custom field.
Catrope added subscribers: marcoil, Catrope, Esanders and 3 others.
gerritbot added a subscriber: gerritbot.

Change 188741 had a related patch set uploaded (by Catrope):
Support specifying reference contents with data-mw.body.id

https://gerrit.wikimedia.org/r/188741

Patch-For-Review

Change 188736 had a related patch set uploaded (by Catrope):
Allow access to DM document during model->DOM conversion

https://gerrit.wikimedia.org/r/188736

Patch-For-Review

Change 188737 had a related patch set uploaded (by Catrope):
Pass original document in model->DOM tests

https://gerrit.wikimedia.org/r/188737

Patch-For-Review

Catrope moved this task from Blocked to Q4 on the VisualEditor board.

Change 189120 had a related patch set uploaded (by Catrope):
Track originalHtml in internalItems

https://gerrit.wikimedia.org/r/189120

Patch-For-Review

Change 189121 had a related patch set uploaded (by Catrope):
Update tests for internalItem originalHtml change

https://gerrit.wikimedia.org/r/189121

Patch-For-Review

Change 188736 abandoned by Catrope:
Allow access to DM document during model->DOM conversion

https://gerrit.wikimedia.org/r/188736

Change 188737 abandoned by Catrope:
Pass original document in model->DOM tests

https://gerrit.wikimedia.org/r/188737

Change 189120 merged by jenkins-bot:
Track originalHtml in internalItems

https://gerrit.wikimedia.org/r/189120

Change 189121 merged by jenkins-bot:
Update VE core submodule to master (83a526a)

https://gerrit.wikimedia.org/r/189121

Change 188741 merged by jenkins-bot:
Support specifying reference contents with data-mw.body.id

https://gerrit.wikimedia.org/r/188741