Steps to reproduce:
Expected result: error message about file name, or (preferably) auto-correct
Actual result: no visible effect, JS error about this.title being null on mw.UploadWizardUpload.js line 446
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Correctly report an error for file names without extension | mediawiki/extensions/UploadWizard | master | +10 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T96907 Clean up possible refactor-related regressions | |||
| Resolved | matmarex | T89792 UploadWizard does not handle invalid names |
I actually can't repro on master with a JPG lacking an extension (OS X/firefox). It uploads fine and UW seems to add the extension in the UI.
Maybe in your case it's the combination of unsupported MIME type and lack of extension? What kind of file were you uploading?
Attached the test file I was using (with master). It's the one generated by the chunked upload browser test.
Can you upload it somewhere else? I can't find a way to download and save the actual image in phabricator, I keep getting an HTML error served instead.
Look at what it actually saves, the contents of the file is the HTML of an expired token error page.
That works, thanks. I think that the issue is what I expected: OS X's mime detection thinks this is a text file. Linux's mime detection probably does the same. Therefore, it behaves like an extension-less text file on upload. I imagine that the way crunchy generates it is throwing off the mime regexps.
So I think that it's smaller bug than expected. Extension-less images that are correctly mime-detected (which would be the vast majority) seem to work fine in UW.
Change 235363 had a related patch set uploaded (by Bartosz Dziewoński):
Correctly report an error for file names without extension
Change 235363 merged by jenkins-bot:
Correctly report an error for file names without extension