Page MenuHomePhabricator
Create Task
Maniphest T89976

mysql support should fall back to dependency on pure python package PyMySQL
Closed, ResolvedPublic
Actions

Description

The pywikibot mysql dependencies oursql depends on a C compiler. This is fine as an optional dependency, but we should depend on a pure python package.

https://pypi.python.org/pypi/PyMySQL

Details

SubjectRepoBranchLines +/-
mysql: drop support for MySQLdb modulepywikibot/coremaster+7 -22
mysql: update requirementspywikibot/coremaster+1 -2
mysql: remove traces of 'oursql' dependencypywikibot/coremaster+0 -3
mysql.py: add PyMySql as pure-Python MySQL client librarypywikibot/coremaster+56 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

jayvdb created this task.Feb 19 2015, 7:13 PM
jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot, Pywikibot-pagegenerators.py.
jayvdb subscribed.
Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptFeb 19 2015, 7:13 PM
XZise subscribed.Feb 21 2015, 12:18 PM

Hmm wouldn't that solve also the oursql problem in T75704?

jayvdb added a comment.May 30 2015, 4:37 PM
In T89976#1056465, @XZise wrote:

Hmm wouldn't that solve also the oursql problem in T75704?

Yes it would. I've seen a few py3 packages which provide an almost identical API to oursql, etc.

jayvdb added a parent task: T75704: Python 3 library support.May 30 2015, 4:38 PM
Ricordisamoa subscribed.May 30 2015, 6:31 PM
jayvdb added a comment.Jun 9 2015, 6:22 AM

How will we test this. The MySQL generator needs a mysql database with a MediaWiki table structure.
Maybe there is a fake MYSQL database that can be used for testing.

jayvdb added a project: Pywikibot-tests.Jun 9 2015, 6:23 AM
jayvdb moved this task from Backlog to New tests needed on the Pywikibot-tests board.
Ricordisamoa added a comment.Jun 9 2015, 12:46 PM
In T89976#1348136, @jayvdb wrote:

How will we test this. The MySQL generator needs a mysql database with a MediaWiki table structure.

Labs?

jayvdb added a comment.Jun 9 2015, 12:54 PM
In T89976#1348767, @Ricordisamoa wrote:
In T89976#1348136, @jayvdb wrote:

How will we test this. The MySQL generator needs a mysql database with a MediaWiki table structure.

Labs?

So maybe as part of T100903: Run pywikibot test suite regularly on beta cluster as part of MediaWiki/Wikimedia CI and T58961: Tests: test using local mediawiki installation

jayvdb triaged this task as High priority.Sep 1 2015, 5:55 AM

Including the compiled package in requirements.txt causes Win32 users a problem.

Dvorapa subscribed.Jun 11 2017, 9:17 PM
Dvorapa mentioned this in T142021: Error mysqlquery.Jul 24 2017, 9:15 PM
Dvorapa added a parent task: T187122: Make pywikibot work with SQL on all platforms and all Python versions supported.Feb 12 2018, 10:31 PM
gerritbot subscribed.Mar 7 2018, 9:32 PM

Change 416370 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] mysql.py: add PyMySql as pure-Python MySQL client library

https://gerrit.wikimedia.org/r/416370

gerritbot added a project: Patch-For-Review.Mar 7 2018, 9:32 PM
Dvorapa added a subtask: T189052: install pymysql on tools-bastion-03.May 17 2018, 9:23 PM
gerritbot added a comment.Jun 11 2018, 9:37 AM

Change 416370 merged by jenkins-bot:
[pywikibot/core@master] mysql.py: add PyMySql as pure-Python MySQL client library

https://gerrit.wikimedia.org/r/416370

Dvorapa closed this task as Resolved.Jun 11 2018, 9:38 AM
Dvorapa assigned this task to Mpaa.
Dvorapa closed subtask T189052: install pymysql on tools-bastion-03 as Resolved.Jun 14 2018, 11:01 PM
Dvorapa mentioned this in T75704: Python 3 library support.Oct 1 2018, 9:33 PM
gerritbot added a comment.Mar 11 2019, 7:43 PM

Change 495739 had a related patch set uploaded (by Hashar; owner: Hashar):
[pywikibot/core@master] mysql: remove traces of 'oursql' dependency

https://gerrit.wikimedia.org/r/495739

gerritbot added a comment.Mar 11 2019, 8:03 PM

Change 495740 had a related patch set uploaded (by Hashar; owner: Hashar):
[pywikibot/core@master] mysql: drop support for MySQLdb module

https://gerrit.wikimedia.org/r/495740

hashar subscribed.Mar 11 2019, 8:05 PM

Note that pywikibot now defaults to use PyMySQL which is the pure python module and defaults to it. That has been the case since October 2018.

I have send a couple patches to clean up the code of mentions to oursql and remove support for MySQLdb has a fall back.

Dvorapa added a comment.Mar 11 2019, 8:38 PM

Oursql was not needed anymore, but I would leave MySQLdb fallback perhaps.

gerritbot added a comment.Mar 12 2019, 12:20 AM

Change 495739 merged by jenkins-bot:
[pywikibot/core@master] mysql: remove traces of 'oursql' dependency

https://gerrit.wikimedia.org/r/495739

gerritbot added a comment.Jul 4 2019, 9:38 AM

Change 495740 abandoned by Hashar:
mysql: drop support for MySQLdb module

https://gerrit.wikimedia.org/r/495740

Maintenance_bot removed a project: Patch-For-Review.Jul 4 2019, 10:10 AM
gerritbot added a comment.Jan 19 2020, 11:36 AM

Change 565757 had a related patch set uploaded (by Xqt; owner: Hashar):
[pywikibot/core@master] mysql: update requirements

https://gerrit.wikimedia.org/r/565757

gerritbot added a project: Patch-For-Review.Jan 19 2020, 11:36 AM
Xqt added a parent task: T243154: Drop support for MySQLdb.Jan 19 2020, 12:55 PM
gerritbot added a comment.Jan 19 2020, 1:01 PM

Change 565757 merged by jenkins-bot:
[pywikibot/core@master] mysql: update requirements

https://gerrit.wikimedia.org/r/565757

Xqt mentioned this in rPWBC442d0d038ac3: mysql: update requirements.Jan 19 2020, 1:04 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 19 2020, 1:10 PM
gerritbot added a comment.Apr 1 2020, 5:59 AM

Change 495740 restored by Xqt:
mysql: drop support for MySQLdb module

Reason:
T243154. May be removed after 1 year.

https://gerrit.wikimedia.org/r/495740

gerritbot added a comment.Apr 1 2020, 6:09 AM

Change 495740 had a related patch set uploaded (by Xqt; owner: Hashar):
[pywikibot/core@master] mysql: drop support for MySQLdb module

https://gerrit.wikimedia.org/r/495740

gerritbot added a project: Patch-For-Review.Apr 1 2020, 6:09 AM
gerritbot added a comment.Apr 1 2020, 6:17 AM

Change 495740 merged by jenkins-bot:
[pywikibot/core@master] mysql: drop support for MySQLdb module

https://gerrit.wikimedia.org/r/495740

Xqt mentioned this in rPWBC821ee47c2f6a: mysql: drop support for MySQLdb module.Apr 1 2020, 6:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits