Gerrit change 186332 has caused unit tests to fail in any extension that happens to have a section edit link in its unit tests. A quick grep turns up
LabeledSectionTransclusion, CommonsMetadata, and Scribunto as likely victims.
Description
Details
Related Objects
- Mentioned In
- rELUA0c4e9ecf106b: Fix parser tests, YET AGAIN
rELUAcb4cf733f28b: Fix parser tests, again
rMEXTfa069b18ac8d: Updated mediawiki/extensions Project: mediawiki/extensions/Scribunto…
rMEXTde740ece26a2: Updated mediawiki/extensions Project…
rMEXT3afd5ad7178f: Updated mediawiki/extensions Project: mediawiki/extensions/Scribunto…
rELSTf7bd9aa184c6: Update parser tests to account for section anchors, again
rMEXT9ec183760029: Updated mediawiki/extensions Project: mediawiki/extensions/Scribunto…
rMEXT8b809077cd76: Updated mediawiki/extensions Project…
rELUAbdec6124b53e: Update Scribunto tests after I562e437e
rELSTc2c3b958d8ca: Update parser tests to account for section anchors
Event Timeline
@Anomie: That patch changed the output of the parser and added an anchor tag in all headings in the content. The tests for the extensions will need to be updated. Should I be cloning all extensions and checking them for tests involving headings? Or is there a list of commonly used extensions that I should be checking first?
The extensions running parser tests will start failing. Hopefully maintainers will amend their parser tests to match the new mediawiki/core contract. You can probably announce it on wikitech-l since people will wonder why their unrelated patch started failing.
It's good for the person breaking things to make the fix when possible, instead of making more work for others.
Why are these extensions' tests not ran as a part of the mediawiki-extensions-hhvm/mediawiki-extensions-zend jobs? These flagged an issue with MobileFrontend that I fixed before it became a problem (https://gerrit.wikimedia.org/r/#/c/191682/). That would be a good long-term solution to these problems.
Change 191880 had a related patch set uploaded (by Polybuildr):
Update parser tests to account for section anchors
The job is still rather experimental. I am looking for a way to ease the addition/removal of extensions participating in those jobs.
Vivek Ghaisas has poke wikitech-l about the parser tests failure: https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080909.html
We can probably close this bug, or fill sub tasks for each mediawiki extensions having parser tests and verify whether they still pass / amend them.
Change 192007 had a related patch set uploaded (by Gergő Tisza):
Check CommonsMetadata tests after I562e437e
CommonsMetadata seems fine (which is what I would expect, it has information extraction tests rather than parser tests and you need fairly specific changes to break those).
Change 192065 had a related patch set uploaded (by Polybuildr):
Update Scribunto tests after I562e437e
Change 191880 merged by jenkins-bot:
Update parser tests to account for section anchors
Change 197207 had a related patch set uploaded (by Bartosz Dziewoński):
Update parser tests to account for section anchors, again
Change 197207 merged by jenkins-bot:
Update parser tests to account for section anchors, again
Ok, the first time someone broke extension parser tests is an understandable oversight. But for the second people should really have known better and should have done the extension updates themselves. WHY DID IT HAPPEN A THIRD TIME???
Change 197540 had a related patch set uploaded (by Anomie):
Fix parser tests, YET AGAIN
Perhaps as a passive-aggressive way to indicate that people really hate how parser tests work?