Page MenuHomePhabricator
Create Task
Maniphest T90463

Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See reports here: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#HTTP_503_errors

  • Repeat the steps, but after you open the save dialog, dump the HTML output (how to here: https://www.mediawiki.org/wiki/Parsoid/Debugging#Dumping_HTML_DOM_before_save_in_VE)
  • This HTML crashes the currently deployed version of Parsoid.
  • You will notice that the issn parameter for the transclusion has {"wt": [...]} instead of {"wt": ".."} .. i.e. Parsoid is receiving an array containing a string instead of a string for the wt parameter.

https://gerrit.wikimedia.org/r/#/c/192349/ is a fix in Parsoid so the serializer doesn't crash if a non-string parameter is passed in (it also logs an error event), but this should be fixed in citoid/VE. We'll try to get this fix deployed to Parsoid as part of the regularly scheduled Parsoid deploy for this afternoon.

Details

SubjectRepoBranchLines +/-
Fix: Don't convert ISSN/ISBN in MWDeprecatedmediawiki/services/citoidmaster+2 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• ssastry created this task.Feb 23 2015, 5:57 PM
• ssastry assigned this task to Mvolz.
• ssastry raised the priority of this task from to High.
• ssastry updated the task description. (Show Details)
• ssastry added projects: Citoid, VisualEditor.
• ssastry subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2015, 5:57 PM
• ssastry updated the task description. (Show Details)Feb 23 2015, 5:58 PM
• ssastry set Security to None.
• ssastry updated the task description. (Show Details)
Mvolz moved this task from Backlog to Service on the Citoid board.Feb 23 2015, 6:04 PM
Mvolz moved this task from Service to Extension on the Citoid board.
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Feb 23 2015, 6:15 PM
• ssastry added a parent task: T90479: Update the fix in https://gerrit.wikimedia.org/r/#/c/192349/ to log errors and not crash after T90463 is fixed.Feb 23 2015, 8:05 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 24 2015, 10:13 PM
Jdforrester-WMF edited a custom field.Feb 24 2015, 11:59 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 26 2015, 12:18 AM
Mvolz added a comment.Feb 28 2015, 2:28 PM

This is a problem in the user gadget, not the extension.

Mvolz closed this task as Invalid.Feb 28 2015, 2:28 PM
Mvolz reopened this task as Open.Feb 28 2015, 2:34 PM
Mvolz lowered the priority of this task from High to Low.
Mvolz added a comment.Feb 28 2015, 2:36 PM

Eh, on second thought, this was ultimately caused by a change to the MWDeprecated format that citoid still supports- (although maybe not for much longer) so I'll go ahead and fix that in the citoid service to be back to the way it was.

Mvolz removed projects: VisualEditor 2014/15 Q3 blockers, VisualEditor.Feb 28 2015, 2:45 PM
gerritbot subscribed.Feb 28 2015, 2:50 PM

Change 193575 had a related patch set uploaded (by Mvolz):
Fix: Don't convert ISSN/ISBN in MWDeprecated

https://gerrit.wikimedia.org/r/193575

gerritbot added a project: Patch-For-Review.Feb 28 2015, 2:50 PM
Mvolz moved this task from Extension to Service on the Citoid board.Feb 28 2015, 2:54 PM
gerritbot added a comment.Mar 2 2015, 3:21 AM

Change 193575 merged by jenkins-bot:
Fix: Don't convert ISSN/ISBN in MWDeprecated

https://gerrit.wikimedia.org/r/193575

Jdforrester-WMF closed this task as Resolved.Mar 2 2015, 3:21 AM
Jdforrester-WMF subscribed.

Fixed; will need a service update to be fixed in production, though.

• ssastry added a comment.Mar 2 2015, 10:26 PM

Once deployed, please update T90479 so we know to clean up Parsoid code.

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:41 PM
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:48 PM
Mvolz mentioned this in rGCIT2c44c4af7f6b: Fix: Don't convert ISSN/ISBN in MWDeprecated.Apr 8 2015, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits