Maniphest T90479

Update the fix in https://gerrit.wikimedia.org/r/#/c/192349/ to log errors and not crash after T90463 is fixed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Feb 23 2015, 8:05 PM

Tags

Referenced Files

None

Subscribers

Description

We should not leave behind temporary workarounds. Instead of reverting, we should change that code to throw an error and at least not crash.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T90479 Update the fix in https://gerrit.wikimedia.org/r/#/c/192349/ to log errors and not crash after T90463 is fixed
		Resolved		Mvolz	T90463 Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec

Event Timeline

ssastry created this task.Feb 23 2015, 8:05 PM

ssastry raised the priority of this task from to Medium.

ssastry updated the task description. (Show Details)

ssastry added a project: Parsoid.

ssastry subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2015, 8:05 PM

ssastry added a subtask: T90463: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec.Feb 23 2015, 8:05 PM

Mvolz closed subtask T90463: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec as Invalid.Feb 28 2015, 2:28 PM

Mvolz reopened subtask T90463: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec as Open.Feb 28 2015, 2:34 PM

Jdforrester-WMF closed subtask T90463: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec as Resolved.Mar 2 2015, 3:21 AM

ssastry mentioned this in T90463: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec.Mar 2 2015, 10:26 PM

You can go ahead and fix this now, it shouldn't be causing any more problems.

Change 271916 had a related patch set uploaded (by Arlolra):
T90479: Assert param value serializes to a string

https://gerrit.wikimedia.org/r/271916

gerritbot added a project: Patch-For-Review.Feb 19 2016, 10:20 PM

Change 271916 merged by jenkins-bot:
T90479: Assert param value serializes to a string

https://gerrit.wikimedia.org/r/271916

Arlolra closed this task as Resolved.Feb 19 2016, 10:47 PM

Arlolra claimed this task.

Arlolra removed a project: Patch-For-Review.