[Regression wmf18] Deleting the text inside a bullet/numbered item, heading, other nodes throws error
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open a page with VE
2.Click on bullet list or numbered list icon
3.Now type a text
4.Press enter and go to the next line
5.And then go back to the end of first bulleted or numbered item
6.Delete the text until it deletes the bullet point or the number

Observed that, it throws this error in the console:Error: Offset could not be translated to a DOM element and offset

Now if you go to the second bullet/numbered point and type some text watch text being typed randomly or sometimes deleting the second point entirely.Also there are more error keeps popping in the console as you try to edit the page:

Error: Invalid retain length, cannot retain backwards:-2
Uncaught TypeError: Cannot read property 'insertBefore' of null

Error_and_deleting_edit.mov5 MBDownload

Details

Subject	Repo	Branch	Lines +/-
Stop bogus emits from handleLinearDelete	VisualEditor/VisualEditor	wmf/1.25wmf21	+1 -1
Stop bogus emits from handleLinearDelete	VisualEditor/VisualEditor	wmf/1.25wmf20	+1 -1
Stop bogus emits from handleLinearDelete	VisualEditor/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rGVED263b194004ab: Stop bogus emits from handleLinearDelete
rGVEDa3f1224076a9: Stop bogus emits from handleLinearDelete
rGVED24fe91091663: Stop bogus emits from handleLinearDelete
T92286: Deleting through a list throws an exception

Event Timeline

Ryasmeen created this task.Feb 23 2015, 7:47 PM

Ryasmeen raised the priority of this task from to Needs Triage.

Ryasmeen updated the task description. (Show Details)

Ryasmeen subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2015, 7:47 PM

Happens in both Chrome and Firefox

Ryasmeen renamed this task from [Regression wmf 18] Error: Offset could not be translated to a DOM element and offset appears while deleting the text inside a bullet/numbered item and then cursor starts behaving weirdly while typing text to [Regression wmf 18] "Error: Offset could not be translated to a DOM element and offset" appears while deleting the text inside a bullet/numbered item and then cursor starts behaving weirdly while typing text .Feb 23 2015, 7:49 PM

Ryasmeen triaged this task as High priority.Feb 23 2015, 8:24 PM

Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.

Ryasmeen updated the task description. (Show Details)

Ryasmeen assigned this task to dchan.Feb 24 2015, 12:43 AM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 24 2015, 10:13 PM

Jdforrester-WMF renamed this task from [Regression wmf 18] "Error: Offset could not be translated to a DOM element and offset" appears while deleting the text inside a bullet/numbered item and then cursor starts behaving weirdly while typing text to [Regression wmf18] Deleting the text inside a bullet/numbered item throws error .Feb 24 2015, 11:59 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF renamed this task from [Regression wmf18] Deleting the text inside a bullet/numbered item throws error to [Regression wmf18] Deleting the text inside a bullet/numbered item, heading, other nodes throws error .Feb 25 2015, 6:42 PM

Jdforrester-WMF added a project: VisualEditor-DataModel.

Jdforrester-WMF added a subscriber: matmarex.

James guilted me into debugging this a bit. A good place to put a breakpoint when debugging this is in ve.dm.SurfaceFragment.prototype.delete after this line: tx = ve.dm.Transaction.newFromRemoval( this.document, rangeToRemove );. Astonishingly, the removal transation turns out not to have any remove operations. The list item gets removed anyway for some reason (on the next line), but the selection range is not correctly translated to account for that (on the next next line) and so the offset ends up in the middle of nowhere. I'll leave figuring out why this happens to someone else.

Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 26 2015, 12:18 AM

matmarex mentioned this in T92286: Deleting through a list throws an exception.Mar 10 2015, 5:34 PM

I think the model is a red herring here. I think the problem is the state of the CE, and missing inline slugs.

...caused by the introduction of allowing native delete, so the bug is set up by the delete operation *before* the one which throws an exception, as it removes the valid cursor position the next operation expects when calling an intermediary showSelection.

Change 196224 had a related patch set uploaded (by Divec):
Stop bogus emits from handleLinearDelete

https://gerrit.wikimedia.org/r/196224

gerritbot added a project: Patch-For-Review.Mar 12 2015, 4:04 PM

The missing slug allows the exception to occur, but it happens too because the SurfaceFragment performing the deletion has autoSelect and applies a nonsensical selection midway through processing (before subsequently applying the selection that is actually desired). The patch addresses this by turning off autoSelect and then selecting once only, after content processing is complete.

Jdforrester-WMF moved this task from External and Administrivia to Blocked on the VisualEditor board.Mar 12 2015, 5:41 PM

Change 196224 merged by jenkins-bot:
Stop bogus emits from handleLinearDelete

https://gerrit.wikimedia.org/r/196224

Catrope mentioned this in rGVED24fe91091663: Stop bogus emits from handleLinearDelete.Mar 12 2015, 7:31 PM

Change 196314 had a related patch set uploaded (by Jforrester):
Stop bogus emits from handleLinearDelete

https://gerrit.wikimedia.org/r/196314

Change 196315 had a related patch set uploaded (by Jforrester):
Stop bogus emits from handleLinearDelete

https://gerrit.wikimedia.org/r/196315

Jdforrester-WMF closed this task as Resolved.Mar 12 2015, 7:37 PM

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-04_(1.25wmf20), WMF-deploy-2015-03-11_(1.25wmf21), WMF-deploy-2015-03-18_(1.25wmf22); removed Patch-For-Review.

Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 12 2015, 8:29 PM

Change 196315 merged by jenkins-bot:
Stop bogus emits from handleLinearDelete