wbmergeitems adds alias when a duplicate label / alias already existed on target item
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Addshore
	Mar 2 2015, 10:51 PM

Description

See https://www.wikidata.org/w/index.php?title=Q474157&diff=200753230&oldid=200706473

The label "collaborative software" already existed in the target, but an alias "Collaborative software" was added.
This should perhaps not be the case and instead don't add the alias...

I believe the change is / needs to be at https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/ChangeOp/ChangeOpsMerge.php#L168
where we currently have the following but instead need a case insensitive check:

$toLabel === $label

Details

	Subject	Repo	Branch	Lines +/-
	ChangeOpsMerge Case insensitive string check added	mediawiki/extensions/Wikibase	master	+1 -1

Customize query in gerrit

Event Timeline

Addshore created this task.Mar 2 2015, 10:51 PM

Addshore raised the priority of this task from to Medium.

Addshore updated the task description. (Show Details)

Addshore added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, good first task, patch-welcome.

Addshore added subscribers: Addshore, Lydia_Pintscher.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2015, 10:51 PM

Sjoerddebruin subscribed.Mar 2 2015, 10:52 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 3 2015, 11:44 AM

Lydia_Pintscher added subscribers: daniel, hoo, aude, JanZerebecki.

matej_suchanek subscribed.Mar 3 2015, 2:16 PM

Change 197909 had a related patch set uploaded (by Sumit):
ChangeOpsMerge Case insensitive string check added

https://gerrit.wikimedia.org/r/197909

gerritbot added a project: Patch-For-Review.Mar 19 2015, 3:11 PM

See my comment at https://gerrit.wikimedia.org/r/#/c/197909/. I suggest to close this as "wont fix", "works as intended".

I am inclined to agree with thiemo (even thought I opened the bug) :)

I agree with the above statements, let's not do this.

Change 197909 abandoned by Sumit:
ChangeOpsMerge Case insensitive string check added

Reason:
declined

https://gerrit.wikimedia.org/r/197909

matej_suchanek removed projects: Patch-For-Review, patch-welcome.May 23 2015, 10:13 AM

matej_suchanek set Security to None.

matej_suchanek removed subscribers: gerritbot, matej_suchanek.

Ricordisamoa subscribed.Aug 23 2015, 2:15 PM

wbmergeitems adds alias when a duplicate label / alias already existed on target itemClosed, DeclinedPublicActions

Description

Details

Event Timeline

wbmergeitems adds alias when a duplicate label / alias already existed on target item
Closed, DeclinedPublic
Actions