Write an abstracted interface for queue send and receive
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This should be a simple interface, for sending and receiving messages. Probably best if we wrap the commonly used selectors in methods, to decouple from the STOMP implementation.

Write DonationQueue shim around PHPQueue - https://gerrit.wikimedia.org/r/203280

Upstream issues

Note that we're not blocked by these, composer.json is pointing to my modified fork.

(MERGED) Straighten out FIFO vs key-value access. https://github.com/CoderKungfu/php-queue/issues/37
Add STOMP support, https://github.com/CoderKungfu/php-queue/issues/36
Decouple job queue from queue: https://github.com/CoderKungfu/php-queue/issues/39

Details

	Subject	Repo	Branch	Lines +/-
	Write DonationQueue shim around PHPQueue	mediawiki/extensions/DonationInterface	master	+719 -4
	Require the php-queue library	mediawiki/extensions/DonationInterface	master	+174 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
					Restricted Task
		Resolved		awight	T92916 Write an abstracted interface for queue send and receive

Event Timeline

awight created this task.Mar 16 2015, 11:44 PM

awight raised the priority of this task from to Needs Triage.

awight updated the task description. (Show Details)

awight added projects: MediaWiki-extensions-DonationInterface, Fundraising-Backlog-Old.

awight subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 11:44 PM

awight added a parent task: Restricted Task.Mar 17 2015, 12:12 AM

• atgo added a project: Fundraising Sprint Grandmaster Flash.Mar 18 2015, 6:32 PM

• atgo subscribed.

• atgo triaged this task as High priority.Mar 18 2015, 6:35 PM

• atgo set Security to None.

• atgo edited a custom field.

• atgo moved this task from Backlog to no on the Fundraising Sprint Grandmaster Flash board.

• atgo moved this task from no to Backlog on the Fundraising Sprint Grandmaster Flash board.Mar 18 2015, 10:32 PM

awight moved this task from Backlog to Doing on the Fundraising Sprint Grandmaster Flash board.Mar 20 2015, 10:36 PM

Sadly, this library supports all the major queues from the last ten years... so no STOMP support. But for inspiration: https://github.com/CoderKungfu/php-queue

I'm considering using this library, and writing the STOMP backend.

I think I'll go for it. 2.7kloc and sort of recently maintained. Submitting the PR will be a good way to learn about project health :)

Change 198438 had a related patch set uploaded (by Awight):
WIP php-queue library

https://gerrit.wikimedia.org/r/198438

gerritbot added a project: Patch-For-Review.Mar 20 2015, 11:52 PM

• atgo assigned this task to awight.Mar 23 2015, 8:10 PM

Add basic STOMP support to the external library, https://github.com/CoderKungfu/php-queue/pull/38

awight updated the task description. (Show Details)Mar 27 2015, 9:26 PM

awight moved this task from Doing to Review on the Fundraising Sprint Grandmaster Flash board.Mar 30 2015, 9:41 PM

awight added a project: Fundraising Sprint House of Pain.Apr 1 2015, 9:42 PM

awight moved this task from Backlog to Review on the Fundraising Sprint House of Pain board.

Unassigning, to signify that we're waiting on reviews from the library's maintainer.

Change 203280 had a related patch set uploaded (by Awight):
Write DonationQueue shim around PHPQueue

https://gerrit.wikimedia.org/r/203280

Change 198438 abandoned by Awight:
Require the php-queue library

https://gerrit.wikimedia.org/r/198438

awight updated the task description. (Show Details)Apr 12 2015, 2:31 AM

awight updated the task description. (Show Details)

awight updated the task description. (Show Details)Apr 13 2015, 10:02 PM

Ejegg added a project: Fundraising Sprint Indigo Girls.Apr 15 2015, 10:24 PM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Indigo Girls board.

Change 203280 merged by jenkins-bot:
Write DonationQueue shim around PHPQueue

https://gerrit.wikimedia.org/r/203280

awight mentioned this in rEDOI7842e9c25f9a: Write DonationQueue shim around PHPQueue.Apr 22 2015, 8:02 PM

Diffusion mentioned this in rMEXTb549a9abea91: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Apr 22 2015, 8:02 PM

• atgo moved this task from Review to Pending Deployment on the Fundraising Sprint Indigo Girls board.Apr 22 2015, 10:10 PM

Issue while deploying:

Submodule path 'extensions/DonationInterface/vendor': checked out '6405631ee4036ffd12c814e68eb0bc8fe3136ff4'
error: No submodule mapping found in .gitmodules for path 'coderkungfu/php-queue'
error: Failed to recurse into submodule path 'extensions/DonationInterface/vendor'

Ejegg added a project: Fundraising Sprint James Brown.Apr 29 2015, 10:49 PM

awight moved this task from Backlog to Pending Deployment on the Fundraising Sprint James Brown board.Apr 29 2015, 10:50 PM