⚓ T93569 MobileFrontend shouldn't check sessionid length in qunit tests

	Subject	Repo	Branch	Lines +/-
	Hygiene: Don't check sessionid length	mediawiki/extensions/MobileFrontend	master	+1 -2

Status	Assigned	Task
Declined	None	T91707 L10n-bot should not force-merge / override Jenkins (breaks the build)
Open	None	T93591 Tasks blocking translatewiki.net / l10n-bot patch sets from merging
Resolved	kaldari	T93511 MobileFrontend commits fail in qunit in Jenkins
Resolved	Florian	T93569 MobileFrontend shouldn't check sessionid length in qunit tests

Florian raised the priority of this task from to Needs Triage.

Florian updated the task description. (Show Details)

Florian added subscribers: Florian, Krinkle.

Change 198698 had a related patch set uploaded (by Florianschmidtwelzow):
Hygiene: Don't check sessionid length

It looks like now that the MobileFrontend tests are fixed with that patch, it is now the Thanks extension that is failing with the opposite error:

17:48:00 >> MobileFrontend user.js - #getSessionId
17:48:00 >> Message: session ID is 16 chars long
17:48:00 >> Actual: 32
17:48:00 >> Expected: 16

What's going on?

This patch isn't merged, yet, so it shouldn't interfere other tests? And MobileFrontend sometimes have the same problem, see e.g.:
https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/10564/console

(but the same change works for one run and other changes works without problems). After merging your change (https://gerrit.wikimedia.org/r/#/c/198690/) we had some changes, that sometimes fail and sometimes pass tests, see e.g.:
https://gerrit.wikimedia.org/r/#/c/198734/
??

Change 198698 merged by jenkins-bot:
Hygiene: Don't check sessionid length

This is fixed now, i think other projects (like Thanks) will pass tests now, too :)

MobileFrontend shouldn't check sessionid length in qunit tests
Closed, ResolvedPublic
Actions