Page MenuHomePhabricator

Document how to tag extensions in git
Closed, ResolvedPublic

Description

In order to mark our releases, I'd like to tag my extension BlueSpice in git. However, I get a permission error when doing

git push --tags

In my times as release manager, I could push the release tags to core this way. I probably had different permissions in core compared to my extensino repository.

I could not find any hint how to get the correct permission set. So if anyone could help me, I'd be very happy. And I will document the process on mw.o

Event Timeline

Mglaser raised the priority of this task from to Needs Triage.
Mglaser updated the task description. (Show Details)
Mglaser subscribed.

Good idea. My main problem is, though, that I don't know how to tag extensions or better, how to get the permissions. Whom could I ask?

@mmodell has some thoughts on this I presume.

I wholeheartedly support the tagging of releases. I think everyone should have permission to push tags to the same repos they have the ability to push to in general.

@mmodell, thanks for your support here! Tagging helps a lot when you want to do good extension versioning. I wonder what @demon thinks. Can this be implemented easily?

Sure. Add it to mediawiki/* ACL and it'll inherit. Should be already...wonder why it's not :)

Change 203388 had a related patch set uploaded (by MarkAHershberger):
Don't drop the page count information for this release, push to 1.26

https://gerrit.wikimedia.org/r/203388

oops, sorry for the wrong bug number and the noise.

I believe that it was possible to tag extensions in the past. Think one had to be the repo owner, but I am not absolutely sure. However, it should be possible to tag extensions.

I believe that it was possible to tag extensions in the past. Think one had to be the repo owner, but I am not absolutely sure. However, it should be possible to tag extensions.

Unless a repo's changed their ACL this is the default for all MW repos

Just tried again. It works in mediawiki/packages/WPI. However, I tried to push tags in mediawiki/extensions/BlueSpiceFoundation and
mediawiki/skins/BlueSpiceSkin. Any idea why this is different? I am project owner in both cases and have (at least not intenionally) changed any ACLs. WPI is way older than BlueSpice and comes from svn days. Is there a way I can see the ACLs in order to compare them?

OK, I remove the rules in BlueSpiceFoundation (so I should inherit everything). Still no success. How long does it take for the changes to become effective?

With the help of @cicalese, I found the reason it didn't work: you have to use the ssh url instead of the https one. So when I changed my origin repo from

[remote "origin"]
        url = https://mglaser@gerrit.wikimedia.org/r/mediawiki/skins/BlueSpiceSkin
        fetch = +refs/heads/*:refs/remotes/origin/*

to

[remote "origin"]
        url = ssh://mglaser@gerrit.wikimedia.org:29418/mediawiki/skins/BlueSpiceSkin
        fetch = +refs/heads/*:refs/remotes/origin/*

in .git/config, it worked. This even worked in the BlueSpiceSkin repo with modified permissions.

Thanks a lot @cicalese and @demon for your help! I will now find a proper place in mw.o and document this.

hashar claimed this task.
hashar subscribed.

Seems the issue is solved (push tags to the ssh based remote)