Add a flag button
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 2 2015, 6:25 PM

Description

When viewing a collection that I do not own whilst logged in or not logged in I see a flag button.
Clicking the flag should event log the following

user id of the person flagging (0 or null for anonymous)
edit count of user
groups that the user belongs to e.g. autoconfirmed, admin etc..
collection id

When a user clicks the flag button they see a confirmation message saying "Are you sure you want to flag this collection for review?"
A user who flags a collection sees a toast so that they know their action was recorded. The toast appears for 2 seconds max and says "This collection has been flagged for review".

Flag button gets disabled after it has been flagged for review.
We will manually go through these and work out correct heuristics for flagging.

Details

	Subject	Repo	Branch	Lines +/-
	Add flag collection button and confirm overlay	mediawiki/extensions/Gather	master	+179 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T94641 Allow autopatrolled users to contribute in list moderation.
Resolved	Jdlrobson	T94228 Add a hide button to collections
Resolved	• rmoen	T94871 Add a flag button
Resolved	Jdlrobson	T97076 Visiting a collection triggers an API request on every page load

Event Timeline

Jdlrobson created this task.Apr 2 2015, 6:25 PM

Jdlrobson assigned this task to • MSyed.

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Gather.

Jdlrobson moved this task to Bug backlog on the Gather board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2015, 6:25 PM

Jdlrobson set Security to None.Apr 2 2015, 6:25 PM

Jdlrobson edited a custom field.

Mock still needed @MSyed...

Jdlrobson updated the task description. (Show Details)Apr 9 2015, 10:41 PM

Jdlrobson added a project: Gather Sprint Forward.

Jdlrobson renamed this task from Data to fuel heuristics for flagging to Add a flag button.Apr 10 2015, 10:41 PM

Jdlrobson added a parent task: T94641: Allow autopatrolled users to contribute in list moderation..Apr 11 2015, 12:09 AM

Jdlrobson updated the task description. (Show Details)Apr 11 2015, 12:31 AM

Jdlrobson merged a task: T95767: user who flags collection sees confirmation overlay .

Jdlrobson added a subscriber: • JKatzWMF.

@Jdlrobson. @MSyed has added mock, here: https://phabricator.wikimedia.org/T94228#1202075, but I think it has some issues. Waiting to hear back from moiz...

• Moushira subscribed.Apr 13 2015, 4:49 PM

Jdlrobson updated the task description. (Show Details)Apr 13 2015, 5:39 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Apr 13 2015, 5:42 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited a custom field.Apr 13 2015, 5:45 PM

Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Forward board.

@Jdlrobson @JKatzWMF Since we dont have Follow and Share functionality built, just the flag icon in the corner is fine.

Also, I'm putting a hide icon in the corner too for admins.

CollectionsFlagging2.png (1×1 px, 305 KB)

Jdlrobson added a parent task: T94228: Add a hide button to collections.Apr 13 2015, 5:48 PM

Thanks @MSyed. Stealing this from you now. Go back to vacationing ;)

• rmoen moved this task from Ready for dev to In development on the Gather Sprint Forward board.Apr 13 2015, 10:32 PM

@JKatzWMF @Jdlrobson: For schema, value for "groups that the user belongs to" is a comma separated list?
eg: "autoconfirmed, admin"

Should this be in its own schema (GatherFlags) ? Or add a flag option to GatherClicks?

@rmoen. Good questions. Groups that a user belongs to is comma
separated. I like having them in the same schema, but for scalability,
let's put it in its own schema for now.

@JKatzWMF, @Jdlrobson, Schema created. Please review: https://meta.wikimedia.org/wiki/Schema:GatherFlags

@JKatzWMF comma separated may be a bad idea... how do you plan to use this information? If comma separated you cannot easily do queries such as "what % of users who reported were admins?"

you'll have to do LIKE statements which may be slower.

That said, user groups should also be possible to obtain by joining with the user groups table...

I think it is much faster to search this table with like than doing a join
against user table. Anytime I have had to join against user table it takes

30 minutes.

Depends on the table size but okay! :)

Patch here: https://gerrit.wikimedia.org/r/#/c/204201/
The schema registration was a bit confusing. I think I got it all rigged up but needs tested.
All that's left is schema testing and any rigging, and adding in userGroups (it is an empty string now)

@Jdlrobson, would appreciate your thoughts about the ConfirmationOverlay. It simplified the CollectionDeleteOverlay quite a bit and I think it will be useful for further down the road.

@Jhernandez, feel free to grab this in the morning if you want to poke with the schema, otherwise I will finish when I wake up.

Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Forward board.Apr 15 2015, 4:47 PM

Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Forward board.Apr 16 2015, 5:17 PM

Jdlrobson moved this task from Bug backlog to In sprint on the Gather board.Apr 16 2015, 5:36 PM

• rmoen moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Forward board.Apr 16 2015, 11:18 PM

Change 204611 had a related patch set uploaded (by Jdlrobson):
Add flag collection button and confirm overlay

https://gerrit.wikimedia.org/r/204611

gerritbot added a project: Patch-For-Review.Apr 20 2015, 5:03 PM

Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Forward board.Apr 20 2015, 5:35 PM

• rmoen moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Forward board.Apr 22 2015, 8:34 PM

Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Forward board.Apr 22 2015, 8:54 PM

Jdlrobson updated the task description. (Show Details)

@JKatzWMF we haven't been clear on the disabled behaviour. Can you create a separate card about this - what does a disabled flag look like? Does the flag stay disabled if I refresh the page/go to another device (remember we show this to anons too)?

• rmoen moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Forward board.Apr 22 2015, 9:38 PM

@Jdlrobson the flag should never be shown in a disable state. If you're an
anon, then you shouldnt seen any flag icon.

@JKatzWMF @MSyed the task asked to show this to anons. When beta labs is back up and running can you review and create a follow up sub task before signing off if you are unhappy with it.