Page MenuHomePhabricator
Create Task
Maniphest T94931

[Regression wmf24] Hitting return deletes the text even after deselecting it
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open VE
2.Type a text
3.Select the text
4.De-select it by clicking at the end of text
5.Press return to go to the next line

Observed Result:
It deletes the entire text that was selected before.

Details

SubjectRepoBranchLines +/-
Fix typo in ve.ce.RangeState#compareSelectionsVisualEditor/VisualEditorwmf/1.25wmf24+19 -1
Fix typo in ve.ce.RangeState#compareSelectionsVisualEditor/VisualEditormaster+19 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 2 2015, 11:13 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2015, 11:13 PM
Ryasmeen triaged this task as High priority.Apr 2 2015, 11:13 PM
Ryasmeen set Security to None.
Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.Apr 2 2015, 11:48 PM
Catrope subscribed.Apr 6 2015, 9:17 PM

Regression from 87d1c1a549739c46c992d5a0ee64f338d49df0a8

Catrope assigned this task to Esanders.Apr 6 2015, 9:17 PM
Catrope raised the priority of this task from High to Unbreak Now!.
Catrope added a subscriber: dchan.
In T94931#1183802, @Catrope wrote:

Regression from 87d1c1a549739c46c992d5a0ee64f338d49df0a8

At least that's what it git bisects to, but for whatever reason this isn't broken on enwiki which is supposed to be running wmf23.

Catrope added a comment.Apr 6 2015, 9:22 PM

Never mind, that commit really was in wmf24, I'm just bad at typing 23 when I mean 23.

Esanders added a comment.Apr 6 2015, 9:22 PM

DM range doesn't update when clicking at end of line, which would cause the behaviour described. Interestingly if you try it a second time it doesn't break.

gerritbot subscribed.Apr 6 2015, 10:46 PM

Change 202266 had a related patch set uploaded (by Divec):
Fix typo in ve.ce.RangeState#compareSelections

https://gerrit.wikimedia.org/r/202266

gerritbot added a project: Patch-For-Review.Apr 6 2015, 10:46 PM
gerritbot added a comment.Apr 6 2015, 11:11 PM

Change 202266 merged by jenkins-bot:
Fix typo in ve.ce.RangeState#compareSelections

https://gerrit.wikimedia.org/r/202266

dchan mentioned this in rGVEDcbb01cfb136b: Fix typo in ve.ce.RangeState#compareSelections.Apr 6 2015, 11:12 PM
Catrope closed this task as Resolved.Apr 6 2015, 11:21 PM
Catrope reassigned this task from Esanders to dchan.
Catrope added a project: VisualEditor 2014/15 Q4 blockers.
Catrope edited a custom field.
Catrope removed a project: Patch-For-Review.
Catrope added a project: WMF-deploy-2015-04-08_(1.26wmf1).Apr 7 2015, 12:02 AM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 7 2015, 11:39 AM
gerritbot added a comment.Apr 7 2015, 2:03 PM

Change 202390 had a related patch set uploaded (by Jforrester):
Fix typo in ve.ce.RangeState#compareSelections

https://gerrit.wikimedia.org/r/202390

gerritbot added a project: Patch-For-Review.Apr 7 2015, 2:03 PM
gerritbot added a comment.Apr 7 2015, 2:06 PM

Change 202390 merged by jenkins-bot:
Fix typo in ve.ce.RangeState#compareSelections

https://gerrit.wikimedia.org/r/202390

Jdforrester-WMF mentioned this in rGVED16e15af175d2: Fix typo in ve.ce.RangeState#compareSelections.Apr 7 2015, 2:06 PM
Jdforrester-WMF renamed this task from [Regression wmf 24] Hitting return deletes the text even after deselecting it to [Regression wmf24] Hitting return deletes the text even after deselecting it.Apr 7 2015, 3:46 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-01_(1.25wmf24); removed Patch-For-Review.
Ryasmeen added a comment.Apr 7 2015, 8:05 PM

Verified the fix

Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 8 2015, 10:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL