RevisionDeleter::suggestTarget can just return null...
E.g. https://www.mediawiki.org/w/index.php?title=Special:RevisionDelete&type=revision&ids=100000000000000000
Apr 20 03:08:04 mw1052: #012Fatal error: Argument 3 passed to RevisionDeleter::createList() must be an instance of Title, null given in /srv/mediawiki/php-1.26wmf2/includes/revisiondelete/RevisionDeleter.php on line 89
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Move Title null check in Special:RevisionDelete | mediawiki/core | master | +7 -6 |
Related Objects
Event Timeline
E.g. https://www.mediawiki.org/w/index.php?title=Special:RevisionDelete&type=revision&ids=100000000000000000
Apr 20 03:08:04 mw1052: #012Fatal error: Argument 3 passed to RevisionDeleter::createList() must be an instance of Title, null >given in /srv/mediawiki/php-1.26wmf2/includes/revisiondelete/RevisionDeleter.php on line 89
Isnt this error happening because the RevisionDeleter::createList() expects a parameter 'title' which you are not passing in this case - and not - related to the id passed ?
No, see for example https://www.mediawiki.org/w/index.php?title=Special:RevisionDelete&type=revision&ids=498632, which works. The point of RevisionDeleter::suggestTarget() is to determine the relevant title based on the given revision ID(s). Obviously if the revision ID is bogus, it will fail. The point is that it should fail more gracefully.
Change 215697 had a related patch set uploaded (by Umherirrender):
Move Title null check in Special:RevisionDelete