Page MenuHomePhabricator
Create Task
Maniphest T96957

Global rename request notification emails should be sent with 'Notes'
Closed, ResolvedPublic
Actions

Description

If a global rename request is accepted/rejected from the queue then a email is sent without mentioning the reason. The notes column where we are providing the reason, should be included in the email. Currently there is no way for the user to know why the request got rejected. Also we are getting multiple rename request because of this.

Currently the following is the text that i am getting in the email, also unable to access this page from the rename requested account.

The request to rename "Shanmugambot" to "Dont Rename, Testing" could not be completed.

For more information, please visit this help page: <https://meta.wikimedia.org/wiki/Help:Unified_login#Frequently_asked_questions>. 
To discuss your rename request, you can post on this page: <https://meta.wikimedia.org/wiki/Talk:Steward_requests/Username_changes>. 
You must still log in to your current account name first.

Details

SubjectRepoBranchLines +/-
Globalrenamequeue-email-body-rejected: add $3mediawiki/extensions/WikimediaMessagesmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Shanmugamp7 created this task.Apr 23 2015, 6:13 AM
Shanmugamp7 raised the priority of this task from to High.
Shanmugamp7 updated the task description. (Show Details)
Shanmugamp7 added a project: SUL-Finalization.
Shanmugamp7 added subscribers: Shanmugamp7, Keegan.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 6:13 AM
Shanmugamp7 updated the task description. (Show Details)Apr 23 2015, 6:14 AM
Shanmugamp7 set Security to None.
Shanmugamp7 added a project: MediaWiki-User-rename.Apr 23 2015, 6:17 AM
Keegan added a subscriber: bd808.Apr 23 2015, 6:20 AM
Steinsplitter awarded a token.Apr 23 2015, 8:25 AM
Steinsplitter subscribed.
Stryn subscribed.Apr 23 2015, 11:19 AM
Vogone assigned this task to Legoktm.Apr 23 2015, 12:26 PM
Vogone raised the priority of this task from High to Unbreak Now!.
DerHexer subscribed.Apr 23 2015, 9:22 PM
hoo lowered the priority of this task from Unbreak Now! to High.Apr 24 2015, 7:45 AM
hoo edited projects, added MediaWiki-extensions-CentralAuth; removed MediaWiki-User-rename.
hoo subscribed.

This sounds like it's done on purpose, needs clarification.

MarcoAurelio subscribed.Apr 26 2015, 10:39 PM
Legoktm removed Legoktm as the assignee of this task.Apr 28 2015, 5:39 PM
Steinsplitter added a project: GlobalRename.Apr 29 2015, 6:15 PM
Steinsplitter added a comment.May 1 2015, 5:55 AM

We need to send every user a mail and explaining why the request was declined. It would be helpful if the "Rason" can be send with the informations mail.

Xeno subscribed.May 1 2015, 12:13 PM
In T96957#1251424, @Steinsplitter wrote:

We need to send every user a mail and explaining why the request was declined. It would be helpful if the "Rason" can be send with the informations mail.

Agreed, from a user experience perspective, not telling them why their rename is rejected is entirely unacceptable.

Please fix as soon as possible!

Glaisher subscribed.May 1 2015, 4:41 PM

CentralAuth does actually provide the reason as the third parameter for the rejected mail message. This is not used in Meta's override: https://meta.wikimedia.org/wiki/MediaWiki:Globalrenamequeue-email-body-rejected

gerritbot subscribed.May 1 2015, 5:10 PM

Change 208123 had a related patch set uploaded (by Legoktm):
Globalrenamequeue-email-body-rejected: add $3

https://gerrit.wikimedia.org/r/208123

gerritbot added a project: Patch-For-Review.May 1 2015, 5:10 PM
Steinsplitter assigned this task to saper.May 1 2015, 5:11 PM
Steinsplitter moved this task from Backlog to Review requested on the GlobalRename board.
MarcoAurelio moved this task from Backlog to In progress on the MediaWiki-extensions-CentralAuth board.May 5 2015, 6:37 PM
gerritbot added a comment.May 8 2015, 5:55 PM

Change 208123 merged by jenkins-bot:
Globalrenamequeue-email-body-rejected: add $3

https://gerrit.wikimedia.org/r/208123

Legoktm closed this task as Resolved.May 8 2015, 5:56 PM
Legoktm subscribed.
Glaisher added a comment.May 8 2015, 5:56 PM

https://meta.wikimedia.org/wiki/Meta:Requests_for_help_from_a_sysop_or_bureaucrat#Requested_edit:_MediaWiki:Globalrenamequeue-email-body-rejected Already fixed locally but oh well.

Diffusion mentioned this in rMEXT475e3de263d9: Updated mediawiki/extensions Project: mediawiki/extensions/WikimediaMessages….May 8 2015, 6:00 PM
Legoktm mentioned this in rEWME9ee1155eb840: Globalrenamequeue-email-body-rejected: add $3.May 8 2015, 6:00 PM
Keegan moved this task from It's complicated to Done on the SUL-Finalization board.May 12 2015, 9:10 PM
MarcoAurelio moved this task from In progress to Done on the MediaWiki-extensions-CentralAuth board.May 25 2015, 11:46 PM
Trijnstel subscribed.Jun 1 2015, 1:26 AM
Keegan moved this task from Review requested to Closed on the GlobalRename board.Jun 7 2015, 1:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL