Deprecate DataSite.createNewItemFromPage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	May 9 2015, 4:31 AM

Description

Introduction

ItemPage has a fromPage classmethod already which lazy loads the wikibase contents when needed. DataSite.createNewItemFromPage can be dropped. The deprecation process needs a deprecation warning first that bot owners can replace the method usage. A FutureWarning will Always be shown which means the method will be removed completely with overnext release.

What to do:

add a deprecated decorator with future_warning parameter and ImagePage.fromPage() for the first (instead) parameter
look for a sample using deprecated decorator e.g. here

Important hints

refer our Coding Convention Guidlines

Details

	Subject	Repo	Branch	Lines +/-
	[cleanup] Remove deprecated createNewItemFromPage	pywikibot/core	master	+0 -41
	Deprecate DataSite.createNewItemFromPage	pywikibot/core	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Xqt	T98663 Deprecate DataSite.createNewItemFromPage
		Resolved		Xqt	T94848 AttributeError: 'ItemPage' object has no attribute 'claims'

Event Timeline

jayvdb created this task.May 9 2015, 4:31 AM

jayvdb raised the priority of this task from to Needs Triage.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot, Pywikibot-Wikidata.

jayvdb subscribed.

Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptMay 9 2015, 4:31 AM

jayvdb moved this task from Backlog to Ready to go on the Pywikibot-Wikidata board.Jul 6 2015, 12:47 AM

jayvdb added a project: good first task.Sep 10 2015, 11:37 AM

jayvdb triaged this task as Low priority.Sep 10 2015, 9:28 PM

@jayvdb
What do you mean by this? Are you saying remove the whole function? I'm a little confused.

In T98663#1923160, @MtDu wrote:

@jayvdb
What do you mean by this? Are you saying remove the whole function? I'm a little confused.

It should be deprecated, once we have a better approach.
People shouldnt been to use DataSite directly; instead we should provide a class method on ItemPage. However this probably needs to wait until T94848 is fixed, as that is a larger problem preventing ItemPage to be used as a container for data not yet serialised with a Wikibase ID.

TheSandDoctor subscribed.Dec 30 2019, 7:57 PM

Hello, I want to work on this issue but seems like the issue mentioned above https://phabricator.wikimedia.org/T94848 is not resolved yet and also inactive so do I still have to wait for this to be solved to proceed on this?

Xqt added a subtask: T94848: AttributeError: 'ItemPage' object has no attribute 'claims'.Mar 24 2021, 6:20 AM

Does not look like a good-first-task. I don’t know what should be done with this task and what should be an alternate way of that method to be deprecated. Probably to be declined. Or wait until the description of this task shows the needed steps.

Xqt added a subscriber: matej_suchanek.Mar 24 2021, 6:43 AM

Xqt closed subtask T94848: AttributeError: 'ItemPage' object has no attribute 'claims' as Resolved.Mar 24 2021, 9:21 AM

createNewItemFromPage fails anyway whereas ItemPage.fromPage works due to its lazyload

>>> item1 = repo.createNewItemFromPage(page)
WARNING: C:\pwb\GIT\core\pywikibot\tools\__init__.py:1475: UserWarning: Site wikipedia:no instantiated using different code "nb"
  return obj(*__args, **__kw)

Sleeping for 12.6 seconds, 2021-03-24 10:34:03
WARNING: API error no-external-page: The external client site "vecwiki" did not provide page information for page "Idràułega".
Traceback (most recent call last):
  File "<pyshell#21>", line 1, in <module>
    item1 = repo.createNewItemFromPage(page)
  File "C:\pwb\GIT\core\pywikibot\site\_decorators.py", line 93, in callee
    return fn(self, *args, **kwargs)
  File "C:\pwb\GIT\core\pywikibot\site\_datasite.py", line 745, in createNewItemFromPage
    result = self.editEntity({}, data, bot=bot, **kwargs)
  File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 1475, in wrapper
    return obj(*__args, **__kw)
  File "C:\pwb\GIT\core\pywikibot\site\_decorators.py", line 93, in callee
    return fn(self, *args, **kwargs)
  File "C:\pwb\GIT\core\pywikibot\site\_datasite.py", line 344, in editEntity
    return req.submit()
  File "C:\pwb\GIT\core\pywikibot\data\api.py", line 1922, in submit
    raise APIError(**result['error'])
pywikibot.data.api.APIError: no-external-page: The external client site "vecwiki" did not provide page information for page "Idràułega".
[messages: [{'name': 'wikibase-api-no-external-page', 'parameters': ['vecwiki', 'Idràułega'], 'html': {'*': 'Die externe Website „vecwiki“ hat keine Informationen zur Seite „Idràułega“ bereitgestellt.'}}];
 help: See https://www.wikidata.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes.]