Page MenuHomePhabricator
Feed Advanced Search

Dec 23 2014

Jackmcbarn added a comment to T68746: Provide a parser function to create links to the wiki which don't look external.

Since such a thing couldn't output wikitext, it would be better as an extension tag than as a parser function.

Dec 23 2014, 4:50 PM · I18n, MediaWiki-Parser

Dec 22 2014

Jackmcbarn committed rMW98f56b62e12c: API: Add page properties to action=expandtemplates output (authored by Anomie).
API: Add page properties to action=expandtemplates output
Dec 22 2014, 9:52 PM
Restricted Application changed the visibility for T85113: Function names aren't sanitized in Lua error backtraces.

After discussing with Anomie on IRC, change the messages so that they can contain wikitext, just not HTML.

Dec 22 2014, 5:43 PM · Security, Vuln-XSS, Scribunto
Restricted Application changed the visibility for T85113: Function names aren't sanitized in Lua error backtraces.


Same patch with full metadata.

Dec 22 2014, 5:23 PM · Security, Vuln-XSS, Scribunto
Jackmcbarn created T85121: Things called by braceSubstitution should avoid setting $found = false.
Dec 22 2014, 1:48 AM · MediaWiki-Templates, MediaWiki-Parser

Dec 21 2014

Restricted Application changed the visibility for T85113: Function names aren't sanitized in Lua error backtraces.

The attached patch ensures that all text used in the backtrace is properly sanitized.

Dec 21 2014, 9:11 PM · Security, Vuln-XSS, Scribunto
Jackmcbarn created T85113: Function names aren't sanitized in Lua error backtraces.
Dec 21 2014, 9:07 PM · Security, Vuln-XSS, Scribunto
Jackmcbarn added a comment to T72182: Restrict editing of core MediaWiki javascript / css with a separate user right.

Looks that way.

Dec 21 2014, 6:06 PM · JavaScript, MediaWiki-Page-protection

Dec 19 2014

Jackmcbarn committed rELUA93579c7363ae: Add more comments and type hints (authored by thiemowmde).
Add more comments and type hints
Dec 19 2014, 7:29 PM
Jackmcbarn committed rMWc05b4c9bc4a6: Re-emit unknown tags from #tag.
Re-emit unknown tags from #tag
Dec 19 2014, 4:19 AM
Jackmcbarn committed rELUAc0c61701080c: Handle PTD_FOR_INCLUSION properly.
Handle PTD_FOR_INCLUSION properly
Dec 19 2014, 3:56 AM
Jackmcbarn committed rELUA4002f43ef208: Use a metatable when os.date("*t") is called.
Use a metatable when os.date("*t") is called
Dec 19 2014, 3:52 AM
Jackmcbarn committed rELUA85ac0ae4bbbc: Make Jenkins tests pass.
Make Jenkins tests pass
Dec 19 2014, 3:46 AM

Dec 16 2014

Jackmcbarn added a comment to T78634: disallow changing content model from API and EditPage.

I don't see a reason that users shouldn't be able to freely change a page's content model.

Dec 16 2014, 8:58 PM · MediaWiki-ContentHandler
Jackmcbarn awarded T78634: disallow changing content model from API and EditPage a Dislike token.
Dec 16 2014, 8:58 PM · MediaWiki-ContentHandler
Jackmcbarn added a comment to T78488: Carriage return (\r) line endings not being normalized before being passed to the preprocessor.

@Anomie: Rather than modify both the PST and Scribunto (and probably other places in the future), why not just change Preprocessor_Hash to have the same behavior as Preprocessor_DOM?

Dec 16 2014, 3:52 AM · Patch-For-Review, MediaWiki-Core-Team, MediaWiki-Action-API, MediaWiki-Parser

Dec 14 2014

RandomDSdevel awarded T72901: Users can change the content model of other users' user pages to CSS or JS a Haypence token.
Dec 14 2014, 9:40 PM · Security, Patch-For-Review, Vuln-XSS, Security-Core

Dec 13 2014

Jackmcbarn added a comment to T78465: Checking existence of files with both title.exists and title.file.exists increments the expensive function count by two.

I agree we can probably make the second example cheap, but not the first one. Remember that a file description page can exist without a file existing.

Dec 13 2014, 11:32 AM · Scribunto

Dec 11 2014

Jackmcbarn committed rELUA15203e9b72f3: Record a link to pages looked up by ID.
Record a link to pages looked up by ID
Dec 11 2014, 10:05 PM
Jackmcbarn closed T68328: mw.title should avoid unnecessary expensive work as Resolved.
Dec 11 2014, 8:06 PM · Patch-For-Review, Performance Issue, Scribunto
Jackmcbarn committed rELUAce5ac6611da2: Avoid unnecessary database queries.
Avoid unnecessary database queries
Dec 11 2014, 8:05 PM
Jackmcbarn created T78237: vary-revision intermittently broken on WMF production cluster.
Dec 11 2014, 5:59 AM · WMF-General-or-Unknown

Dec 10 2014

Jackmcbarn committed rELUA98f25aa9a19f: Improve error messages in mw.html (authored by MrStradivarius).
Improve error messages in mw.html
Dec 10 2014, 8:30 PM
Jackmcbarn committed rETBL9056a338cb1b: Return registerInterface() per Ibdc1f4ef.
Return registerInterface() per Ibdc1f4ef
Dec 10 2014, 6:21 PM
Jackmcbarn committed rETBLf0e2d73e876c: Display a warning when editing a blacklisted page.
Display a warning when editing a blacklisted page
Dec 10 2014, 6:21 PM
Jackmcbarn committed rETBLbf188e7af1bc: Add mw.ext.TitleBlacklist.test.
Add mw.ext.TitleBlacklist.test
Dec 10 2014, 6:20 PM
Jackmcbarn committed rETHA49c061de2957: Fix mismatched parentheses.
Fix mismatched parentheses
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETHAbafe6568e9ee: Make the diff the primary link in thanks.
Make the diff the primary link in thanks
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETHA75c88532653e: Remove misleading Thank button from some diffs.
Remove misleading Thank button from some diffs
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETSA7f55cb96525f: Use current revision callback instead of template callback.
Use current revision callback instead of template callback
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETSA46edcfdcdb38: Hook TitleExists when previewing.
Hook TitleExists when previewing
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETSA1b5c01035849: Output hidden fields on pages other than templates.
Output hidden fields on pages other than templates
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETSAe996e025a772: Use Html::hidden instead of Html::input.
Use Html::hidden instead of Html::input
Dec 10 2014, 6:18 PM
Jackmcbarn committed rETSAc756463969c9: Allow changing name of template being previewed.
Allow changing name of template being previewed
Dec 10 2014, 6:18 PM
Jackmcbarn committed rESPB32b546a22341: Categorize pages containing blacklisted links.
Categorize pages containing blacklisted links
Dec 10 2014, 6:13 PM
Jackmcbarn committed rESPB57a417d18125: Add an API action to test blacklisted URLs.
Add an API action to test blacklisted URLs
Dec 10 2014, 6:13 PM
Jackmcbarn committed rELUAe2ae7331b90f: Improve mw.getCurrentFrame handling (authored by Anomie).
Improve mw.getCurrentFrame handling
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA7eb15d6eb749: Improve mw.getCurrentFrame handling (authored by Anomie).
Improve mw.getCurrentFrame handling
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA18e738d3bbc9: Use correct variable in require().
Use correct variable in require()
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA33fb32f87259: Expose file page count, width, and height to Lua.
Expose file page count, width, and height to Lua
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA553744ab5a80: Remove unnecessary redefinition.
Remove unnecessary redefinition
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA6ac9669bc552: Remove unused variable.
Remove unused variable
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAccba1c78f5d3: Allow numbers in tag names.
Allow numbers in tag names
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA23199c2e8154: Improve compatibility with TemplateSandbox.
Improve compatibility with TemplateSandbox
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAc5959b56e7a3: Display the full error message in wikitext.
Display the full error message in wikitext
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA9270d30c50c9: Throw an exception if LuaSandboxFunction::call returns false.
Throw an exception if LuaSandboxFunction::call returns false
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA634f75f53e4c: Don't escape the delete character.
Don't escape the delete character
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA01c9ef5004f8: Set vary-revision appropriately with getContent().
Set vary-revision appropriately with getContent()
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAab722f3b0804: Improve performance of PHP ustring.
Improve performance of PHP ustring
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAece8cc5e820d: Only set indexOffset when the function name is indexed.
Only set indexOffset when the function name is indexed
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAb970046f2e59: Don't output a semicolon at the end of CSS.
Don't output a semicolon at the end of CSS
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAef6e2fa4106d: Fix __pairs not working in LuaStandalone serialization.
Fix __pairs not working in LuaStandalone serialization
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAf5894a6a9fc8: Output   instead of &#nbsp;.
Output   instead of &#nbsp;
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA0367e9bddda3: Fix deceptively-simple pattern in pure-Lua ustring (authored by Anomie).
Fix deceptively-simple pattern in pure-Lua ustring
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAfd9ecb9cbee0: Expose cascading protection directly to Lua.
Expose cascading protection directly to Lua
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA22950097294e: Add 2 tests to unitTestsList.
Add 2 tests to unitTestsList
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAee289c8045ea: Make the cssEncode pattern simpler.
Make the cssEncode pattern simpler
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA58a0db11211b: Make logs work in preview on OSs other than Linux.
Make logs work in preview on OSs other than Linux
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA7c51f69901e2: Create mw.dumpObject split from mw.logObject.
Create mw.dumpObject split from mw.logObject
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAe65638777a64: Show blanknamespace in content language.
Show blanknamespace in content language
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAccab415701f3: Don't cache volatile wikitext (authored by Anomie).
Don't cache volatile wikitext
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA8d1d5ac84ca9: Fix strange mw.html errors with numeric arguments.
Fix strange mw.html errors with numeric arguments
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA1201618b7d21: Keep modules' export tables inside Lua.
Keep modules' export tables inside Lua
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAd1030989bc41: Allow passing nils to mw.html.
Allow passing nils to mw.html
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA780d8e1ec7d1: Set TTLs on outputs containing times.
Set TTLs on outputs containing times
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAec4267991374: Show ScribuntoExceptions in content language.
Show ScribuntoExceptions in content language
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA40b8bd2caaf0: Add comments and remove trailing whitespace.
Add comments and remove trailing whitespace
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA1492ac3d68f2: Avoid running all of mw.lua twice.
Avoid running all of mw.lua twice
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAb0de034ffe41: Use correct variable in require().
Use correct variable in require()
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAe19a1404f406: Use do...end to restrict scope.
Use do...end to restrict scope
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUAd74c81c2337a: Add name to nosuchfunction and nosuchmodule errors.
Add name to nosuchfunction and nosuchmodule errors
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA50a1f556b7be: Remove leftover code for titles in messages.
Remove leftover code for titles in messages
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA55fd5f7bdd88: Remove limits on mw.language:formatDate().
Remove limits on mw.language:formatDate()
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA18f177a3a932: Improve invalid title error message.
Improve invalid title error message
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA2b06e83816f2: Remove message formats other than plain.
Remove message formats other than plain
Dec 10 2014, 5:54 PM
Jackmcbarn committed rELUA9902ec128458: Add protectionLevels variable to mw.title output.
Add protectionLevels variable to mw.title output
Dec 10 2014, 5:54 PM
Jackmcbarn committed rEPOP60a07564a790: Simplify if statement logic.
Simplify if statement logic
Dec 10 2014, 5:43 PM
Jackmcbarn committed rEPFNe56baee855dd: Unstub $langObject.
Unstub $langObject
Dec 10 2014, 5:40 PM
Jackmcbarn committed rEPFNd207d6493d41: Return registerInterface() per Ibdc1f4ef.
Return registerInterface() per Ibdc1f4ef
Dec 10 2014, 5:40 PM
Jackmcbarn committed rEPFN28072281fdd2: Call Title::exists() instead of checking the ID.
Call Title::exists() instead of checking the ID
Dec 10 2014, 5:40 PM
Jackmcbarn committed rEPFNb34f264e0c26: Unstub $langObject.
Unstub $langObject
Dec 10 2014, 5:40 PM
Jackmcbarn committed rEPFN334f1f0ee373: Add a TTL to #time and #timel output.
Add a TTL to #time and #timel output
Dec 10 2014, 5:40 PM
Jackmcbarn committed rEPFNf7bd89e435ab: Allow calling #expr from Lua without the parser.
Allow calling #expr from Lua without the parser
Dec 10 2014, 5:40 PM
Jackmcbarn committed rEINBc3fd290fffe1: Allow InputBoxes to be used to move pages.
Allow InputBoxes to be used to move pages
Dec 10 2014, 5:00 PM
Jackmcbarn committed rEFLRd43720e38d28: Remove "temp hack" quota.
Remove "temp hack" quota
Dec 10 2014, 4:44 PM
Jackmcbarn committed rEFLR42175140f3ce: Add UserMerge support (authored by Legoktm).
Add UserMerge support
Dec 10 2014, 4:44 PM
Jackmcbarn committed rEFLR8e74921613dd: Allow PENDINGCHANGELEVEL to work on other pages.
Allow PENDINGCHANGELEVEL to work on other pages
Dec 10 2014, 4:44 PM
Jackmcbarn committed rEFLR2884597632a7: Don't use deprecated link call.
Don't use deprecated link call
Dec 10 2014, 4:44 PM
Jackmcbarn committed rEFLR8e9c3e091952: Autoaccept reverts to the last stable revision.
Autoaccept reverts to the last stable revision
Dec 10 2014, 4:44 PM
Jackmcbarn committed rECOE333e0653619a: Support protocol-relative URLs in the whitelist.
Support protocol-relative URLs in the whitelist
Dec 10 2014, 4:22 PM
Jackmcbarn committed rECIT50d8e2e290f9: Kill code that's been unnecessary since 2006.
Kill code that's been unnecessary since 2006
Dec 10 2014, 4:01 PM
Jackmcbarn committed rECTP50d8e2e290f9: Kill code that's been unnecessary since 2006.
Kill code that's been unnecessary since 2006
Dec 10 2014, 3:52 PM
Jackmcbarn committed rECAUfc2e124453f3: Remove unused variable $newRights.
Remove unused variable $newRights
Dec 10 2014, 3:50 PM
Jackmcbarn committed rECAPcad4d29d845d: Fix Special:Version.
Fix Special:Version
Dec 10 2014, 3:37 PM
Jackmcbarn committed rECAP4446c091122a: Don't inline hard coded CSS (authored by hoo).
Don't inline hard coded CSS
Dec 10 2014, 3:37 PM
Jackmcbarn committed rEABF9a2f79cc0a73: Only skip apparent null-edits when the page exists.
Only skip apparent null-edits when the page exists
Dec 10 2014, 3:34 PM
Jackmcbarn committed rEABF4046a3ceaf15: Don't pass empty strings to strpos.
Don't pass empty strings to strpos
Dec 10 2014, 3:33 PM
Jackmcbarn committed rEABF4255e3810b3d: Prevent fatal error in Special:AbuseFilter/test.
Prevent fatal error in Special:AbuseFilter/test
Dec 10 2014, 3:33 PM

Dec 8 2014

Jackmcbarn added a comment to T76973: "[[File:Information icon.svg|20px|link=||alt=]]" misparsed inside a table.

Also, this doesn't just affect files:

Dec 8 2014, 12:21 AM · MediaWiki-Parser
Jackmcbarn added a comment to T76973: "[[File:Information icon.svg|20px|link=||alt=]]" misparsed inside a table.

Okay, here's what's going on in the broken case: In Parser::parse, doTableStuff is running before replaceInternalLinks, which turns "[[File:Information icon.svg|20px|link=||alt=]]" into "[[File:Information icon.svg|20px|link=</td>
<td>alt=]]". Unsurprisingly, when replaceInternalLinks then gets called on that mess, it doesn't do you what you wanted.

Dec 8 2014, 12:00 AM · MediaWiki-Parser