Page MenuHomePhabricator
Create Task
Maniphest T101878

Improve Zotero Validation
Closed, ResolvedPublic
Actions

Description

Currently we do some minor validation, such as validate the language code and fix the access date.

We should validate every field Zotero hands us, i.e.

  • Ensure all dates are ISO
  • Ensure any html is stripped from any field
  • Ensure url field is a fully qualified uri
  • Delete extraneous keys

Details

SubjectRepoBranchLines +/-
Remove Zotero library specific keys from citationmediawiki/services/citoidmaster+3 -1
Validate Zotero urlmediawiki/services/citoidmaster+90 -6
Convert all Zotero date fields to ISOmediawiki/services/citoidmaster+30 -2
Clean html tags out of top level fieldsmediawiki/services/citoidmaster+119 -89
Hot-fix for production:mediawiki/services/citoid/deploymaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mvolz created this task.Jun 9 2015, 7:32 PM
Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz moved this task to Zotero on the Citoid board.
Mvolz subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2015, 7:32 PM
Mvolz added a parent task: T101589: Automatic Cite generation results in malformed URL after fed valid LeMonde.fr link.Jun 9 2015, 7:33 PM
Mvolz added a parent task: T95016: Citoid should be validating date fields.
Mvolz added a parent task: T100464: Insertion of <i> tag.Jun 9 2015, 7:36 PM
Mvolz updated the task description. (Show Details)
Mvolz set Security to None.
Mvolz renamed this task from Better Zotero Validation to Improve Zotero Validation.Jun 9 2015, 7:40 PM
Mvolz added a parent task: T93561: Improve language code validation.
Mvolz updated the task description. (Show Details)
Mvolz added a subtask: T95295: Create a cleaner import and export of natively scraped and zotero scraped citations.
Mvolz moved this task from Zotero to IO Tasks on the Citoid board.Jun 18 2015, 6:15 PM
Mvolz triaged this task as High priority.Jun 20 2015, 6:40 PM
• Elitre subscribed.Jun 21 2015, 5:06 AM
• mobrovac mentioned this in T97042: Science direct translator displays unusual behaviour (occasionally gets stuck in redirect loop)..Jun 22 2015, 7:57 PM
Mvolz claimed this task.Jun 23 2015, 12:16 PM
gerritbot subscribed.Jun 23 2015, 5:55 PM

Change 220190 had a related patch set uploaded (by Mobrovac):
Hot-fix for production:

https://gerrit.wikimedia.org/r/220190

gerritbot added a project: Patch-For-Review.Jun 23 2015, 5:55 PM

Change 220190 merged by Mobrovac:
Hot-fix for production:

https://gerrit.wikimedia.org/r/220190

• mobrovac mentioned this in rGCIDffbaf6da12f6: Hot-fix for production:.Jun 23 2015, 6:03 PM
gerritbot added a comment.Jun 26 2015, 3:10 PM

Change 221131 had a related patch set uploaded (by Mvolz):
Clean html tags out of top level fields

https://gerrit.wikimedia.org/r/221131

gerritbot added a comment.Jun 27 2015, 2:10 PM

Change 221369 had a related patch set uploaded (by Mvolz):
Convert all Zotero date fields to ISO

https://gerrit.wikimedia.org/r/221369

gerritbot added a comment.Jun 29 2015, 1:19 PM

Change 221131 merged by Mobrovac:
Clean html tags out of top level fields

https://gerrit.wikimedia.org/r/221131

Mvolz mentioned this in rGCIT105663eb57be: Clean html tags out of top level fields.Jun 29 2015, 1:19 PM
gerritbot added a comment.Jun 30 2015, 1:11 PM

Change 221369 merged by Mobrovac:
Convert all Zotero date fields to ISO

https://gerrit.wikimedia.org/r/221369

Mvolz mentioned this in rGCIT5c0c9d48bddc: Convert all Zotero date fields to ISO.Jun 30 2015, 1:12 PM
Mvolz removed a project: Patch-For-Review.Jul 1 2015, 1:37 PM
Mvolz updated the task description. (Show Details)
• mobrovac closed subtask T95295: Create a cleaner import and export of natively scraped and zotero scraped citations as Resolved.Jul 16 2015, 11:23 AM
gerritbot added a comment.Aug 5 2015, 11:15 AM

Change 229368 had a related patch set uploaded (by Mvolz):
[WIP] Validate Zotero url

https://gerrit.wikimedia.org/r/229368

gerritbot added a project: Patch-For-Review.Aug 5 2015, 11:15 AM
Mvolz removed a parent task: T93561: Improve language code validation.Aug 13 2015, 11:38 AM
gerritbot added a comment.Aug 13 2015, 11:51 AM

Change 231254 had a related patch set uploaded (by Mvolz):
Remove Zotero library specific keys from citation

https://gerrit.wikimedia.org/r/231254

gerritbot added a comment.Aug 24 2015, 5:58 PM

Change 229368 merged by Mobrovac:
Validate Zotero url

https://gerrit.wikimedia.org/r/229368

Mvolz mentioned this in rGCIT22cf8c21f357: Validate Zotero url.Aug 24 2015, 6:21 PM
gerritbot added a comment.Aug 24 2015, 6:41 PM

Change 231254 merged by Mobrovac:
Remove Zotero library specific keys from citation

https://gerrit.wikimedia.org/r/231254

Mvolz mentioned this in rGCIT7e6b67b6f515: Remove Zotero library specific keys from citation.Aug 24 2015, 6:47 PM
Mvolz closed this task as Resolved.Aug 25 2015, 11:20 AM
Mvolz updated the task description. (Show Details)
Mvolz removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits