Maniphest T95295

Create a cleaner import and export of natively scraped and zotero scraped citations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mvolz
	Apr 7 2015, 2:43 PM

Tags

Referenced Files

None

Subscribers

Description

Currently, all format conversion and validation happens in a single method per method in ZoteroService.js. This can cause confusion when results from Scraper need to be converted, or different validation needs to happen from Zotero versus Scraper results.

Details

	Subject	Repo	Branch	Lines +/-
	Fully restore Zotero data type integrity	mediawiki/services/citoid	master	+85 -79
	Cleaner import/export of Zotero & Scraper	mediawiki/services/citoid	master	+333 -177
	Promisify	mediawiki/services/citoid	master	+1 K -926

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• mobrovac	T101589 Automatic Cite generation results in malformed URL after fed valid LeMonde.fr link
		Resolved		Mvolz	T100464 Insertion of <i> tag
		Resolved		Mvolz	T94209 Results of a test with 10 random DOIs from en.wiki on the Beta site
		Resolved		• mobrovac	T95016 Citoid should be validating date fields
		Resolved		Mvolz	T101878 Improve Zotero Validation
		Resolved		Mvolz	T103238 Add crossref metadata request to lib/Scraper.js
		Resolved		Mvolz	T95434 Ensure DOI, PMID, and PMCID are in the resultant citation when they're the requested format
		Resolved		• mobrovac	T95981 Find doi in link to doi.org
		Resolved		Mvolz	T95295 Create a cleaner import and export of natively scraped and zotero scraped citations
		Resolved		Mvolz	T75993 Promisify Citoid and base it on service-template-node / service-runner
		Resolved		Mvolz	T96363 Promisify html-metadata

Event Timeline

Mvolz created this task.Apr 7 2015, 2:43 PM

Mvolz raised the priority of this task from to Needs Triage.

Mvolz updated the task description. (Show Details)

Mvolz added projects: Citoid, Technical-Debt.

Mvolz moved this task to Service on the Citoid board.

Mvolz subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2015, 2:43 PM

Mvolz merged a task: T78773: Separate conversion methods from Zotero.js.Apr 7 2015, 2:46 PM

Mvolz claimed this task.Apr 7 2015, 3:42 PM

Mvolz set Security to None.

• mobrovac added a subtask: T75993: Promisify Citoid and base it on service-template-node / service-runner.Apr 7 2015, 5:50 PM

Mvolz added a parent task: T95434: Ensure DOI, PMID, and PMCID are in the resultant citation when they're the requested format.Apr 8 2015, 4:06 PM

Mvolz triaged this task as Medium priority.Apr 13 2015, 1:32 PM

Mvolz mentioned this in T98096: Security review of Citoid.May 5 2015, 9:23 AM

Mvolz removed Mvolz as the assignee of this task.May 11 2015, 9:50 AM

Change 214038 had a related patch set uploaded (by Mvolz):
[WIP] Promisify

https://gerrit.wikimedia.org/r/214038

gerritbot added a project: Patch-For-Review.Jun 8 2015, 1:19 PM

Mvolz added a parent task: T101878: Improve Zotero Validation.Jun 9 2015, 7:41 PM

Change 214038 merged by Mobrovac:
Promisify

https://gerrit.wikimedia.org/r/214038

Mvolz mentioned this in rGCITfad1601353e0: Promisify.Jun 15 2015, 3:16 PM

Mvolz added a parent task: T103238: Add crossref metadata request to lib/Scraper.js.Jun 20 2015, 6:31 PM

Mvolz added a parent task: T95981: Find doi in link to doi.org.

Mvolz claimed this task.Jun 20 2015, 6:33 PM

Mvolz raised the priority of this task from Medium to High.

Mvolz removed a project: Patch-For-Review.

Mvolz removed a subscriber: gerritbot.

Josve05a subscribed.Jun 20 2015, 8:04 PM

• Elitre subscribed.Jun 21 2015, 5:03 AM

Change 219802 had a related patch set uploaded (by Mvolz):
[WIP] Cleaner import/export of Zotero & Scraper

https://gerrit.wikimedia.org/r/219802

gerritbot added a project: Patch-For-Review.Jun 23 2015, 10:08 AM

Change 219802 merged by Mobrovac:
Cleaner import/export of Zotero & Scraper

https://gerrit.wikimedia.org/r/219802

Mvolz mentioned this in rGCIT8f3f4488b29b: Cleaner import/export of Zotero & Scraper.Jun 29 2015, 10:43 AM

Mvolz moved this task from Service to Waiting on Deploy on the Citoid board.Jun 29 2015, 12:58 PM

Mvolz removed a project: Patch-For-Review.Jun 30 2015, 9:37 AM

Change 222898 had a related patch set uploaded (by Mvolz):
Fully restore Zotero data type integrity

https://gerrit.wikimedia.org/r/222898

gerritbot added a project: Patch-For-Review.Jul 5 2015, 12:37 PM

Change 222898 merged by Mobrovac:
Fully restore Zotero data type integrity

https://gerrit.wikimedia.org/r/222898

Mvolz mentioned this in rGCIT1108c6fd2a57: Fully restore Zotero data type integrity.Jul 13 2015, 8:19 PM

Deployed, resolving.

• mobrovac removed a project: Patch-For-Review.Jul 16 2015, 11:23 AM