Unknown topic error when viewing unconverted page in occupied namespace
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Jun 9 2015, 7:52 PM

Description

Start with NS_HELP_TALK not in $wgFlowOccupiedNamespaces
Create Help talk:Foo (as a wikitext page)
Add NS_HELP_TALK to $wgFlowOccupiedNamespaces
Visit Help talk:Foo again

You'll see an error saying "Unknown topic. The requested topic doesn't exist".

This seems like it would be a problem for any full-namespace conversion, since we intend to skip conversion for archive pages (or more generally, subpages without corresponding subject namespace pages). This error would leave these archives (which could even have been created by Special:EnableFlow to begin with) inaccessible after conversion.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Flow	master	+101 -6	Only check $wgFlowOccupy settings for non-existent pages

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Legoktm	T101881 Unknown topic error when viewing unconverted page in occupied namespace
Resolved	Legoktm	T95592 D5. Only take into account $wgFlowOccupyNamespaces, $wgFlowOccupyPages, and flow-create-board (allowCreation array) for non-existent pages (CA)
Duplicate	None	T95595 A10. Run page creation script (for missing page and revision entries) in production
Resolved	matthiasmullie	T95594 Write maintenance script to make sure all Flow boards exist in page and revision table
Resolved	• Mattflaschen-WMF	T96888 A14. Run maintenance/FlowUpdateWorkflowPageId.php in production
Resolved	EBernhardson	T95581 Flow board creations do not create entry in core's page and revision tables

Event Timeline

Catrope created this task.Jun 9 2015, 7:52 PM

Catrope raised the priority of this task from to Needs Triage.

Catrope updated the task description. (Show Details)

Catrope added projects: StructuredDiscussions, Collaboration-Team-Triage.

Catrope added subscribers: Aklapper, Catrope.

Apparently this does not affect subpages, so I guess this wouldn't directly affect conversion.

Except that this does seem to break the page forever, so if occupation is enabled before the page is converted (which probably shouldn't happen anyway? but could this happen as a race condition maybe?) then we'd have a problem.

In any case, this looks scary, even if it's not high-impact.

Catrope mentioned this in T101890: D3. EnsureFlowRevision() is called when viewing an unconverted page in an occupied namespace.Jun 9 2015, 8:29 PM

• Mattflaschen-WMF added a subtask: T95592: D5. Only take into account $wgFlowOccupyNamespaces, $wgFlowOccupyPages, and flow-create-board (allowCreation array) for non-existent pages (CA).Jun 10 2015, 1:41 AM

Change 219286 had a related patch set uploaded (by Legoktm):
Only check $wgFlowOccupy settings for non-existent pages

https://gerrit.wikimedia.org/r/219286

gerritbot added a project: Patch-For-Review.Jun 18 2015, 11:49 PM

Legoktm claimed this task.Jun 18 2015, 11:51 PM

Change 219286 merged by jenkins-bot:
Only check $wgFlowOccupy settings for non-existent pages

https://gerrit.wikimedia.org/r/219286

Diffusion mentioned this in rMEXTd7aead559d93: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 20 2015, 7:56 PM

Legoktm mentioned this in rEFLW4c33ff5b535d: Only check $wgFlowOccupy settings for non-existent pages.Jun 20 2015, 7:56 PM

Catrope closed this task as Resolved.Jun 20 2015, 8:06 PM