| Etonkovidova | |
| Jun 12 2015, 9:11 PM |
| F178550: Screenshot_2015-06-12-14-47-04.jpg | |
| Jun 12 2015, 10:09 PM |
| F178537: Screenshot_2015-06-12-13-52-32.jpg | |
| Jun 12 2015, 9:11 PM |
Found when checking
T101845
Android app showing cached versions of pages too aggressively
As a result, 'Saved pages' display the same entry multiple times
Note: Each entry in 'Saved pages' shows the same content.
If a page was updated, then after 'Refresh page', it can be saved. After that, clicking on the page from Saved pages, brings up a page that can be saved again.
So, there are a couple of different things going on here. First, the app doesn't reliably know when it's on a saved page. Second, because of yet another instance of our null namespace problem[0], the app allows saving duplicate entries for non-mainspace entries.
To deal with the first problem, I removed the existing code dealing with page save state[1] and implemented a check over the saved pages in the db when the options menu is prepared to determine whether the current page is in fact a saved page. (If this is too expensive, then we'll have find another way; I experimented with maintaining page saved state as a property of a PageTitle but that proved unreliable.[2])
For the second, testing showed that duplicate entries are only saved for pages outside mainspace. If the query is changed to take namespace into account[3], then duplicate entries are only saved for mainspace pages and not for others. Until we figure out how to deal with null namespace values[4], we'll have to accept one or the other, and allowing duplicate saves only for non-mainspace pages -- i.e., the current behavior -- seems like the lesser evil.
Patch to follow.
[0] See T105472.
[1] This previous code did not actually keep track of page save state but set it as saved when navigating from the saved pages fragment or when refreshing after saving a page. As such, it failed to detect when the user navigated to a saved page from other sources, e.g., an ordinary search.
[2] Fire up the debugger and put a break point in PageFragment.onPrepareOptionsMenu, for instance, and you'll find that when a new page is loaded, it's called twice, with two different PageTitle objects returned by model.getTitle()....
[3] I.e., by making the equivalent changes to these: https://gerrit.wikimedia.org/r/#/c/227068/2/wikipedia/src/main/java/org/wikipedia/history/HistoryEntryPersistenceHelper.java.
[4] See my earlier discussion at https://gerrit.wikimedia.org/r/#/c/228291/ and https://gerrit.wikimedia.org/r/#/c/229319/.
Change 229959 had a related patch set uploaded (by Mholloway):
WIP: Fix saved page logic
Change 230129 had a related patch set uploaded (by Mholloway):
WIP: Add db query support for null selection arguments
Change 231325 had a related patch set uploaded (by Mholloway):
WIP: Update SQL query generation to handle mainspace and other null params
Change 230129 abandoned by Mholloway:
Add db query support for null selection arguments
Reason:
Dropping in favor of https://gerrit.wikimedia.org/r/#/c/231325/.
Change 231325 merged by jenkins-bot:
Update SQL query generation to handle mainspace and other null params
Change 229959 merged by jenkins-bot:
Check if page is saved in DB when preparing 'save page' options menu item