Page MenuHomePhabricator

Pages in the Wikipedia namespace can not be deleted from the history
Closed, ResolvedPublic

Description

Description

Reported on OTRS here https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8492547&OTRSAgentInterface=10b4f88584be5d9c0768745d4c96f387f7 with an older release of the app (can be reproduced with latest release).

You can not delete a page in the Wikipedia namespace (probably other namespaces, too) in the history of the app. Deleting other pages seems to work without problems. Deleting the whole history works.

Probably related: T105471: Saved pages unexpectedly doubled anytime I refresh/delete them

Steps to reproduce

  1. Open a page in the Wikipedia NS (e.g. in the german WP the page i mentioned above)
  2. Go to the history of the app
  3. Try to delete the last visited page (not _all_ pages)

Expected results

The page should be deleted

Actual results

The page is still there.

Environments observed

App version: Android App 2.0.105-r-2015-06-30
Android OS versions: Android 5.1.1 (probably others, too)
Device model: Nexus 7 (2013)
Device language: German

Event Timeline

Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Deskana triaged this task as Medium priority.

Change 227068 had a related patch set uploaded (by Deskana):
Fix history entries only being deletable if they're in mainspace

https://gerrit.wikimedia.org/r/227068

Change 228291 had a related patch set uploaded (by Mholloway):
Allow deleting history entries outside the main namespace

https://gerrit.wikimedia.org/r/228291

Change 230129 had a related patch set uploaded (by Mholloway):
WIP: Add db query support for null selection arguments

https://gerrit.wikimedia.org/r/230129

Change 231325 had a related patch set uploaded (by Mholloway):
WIP: Update SQL query generation to handle mainspace and other null params

https://gerrit.wikimedia.org/r/231325

Change 228291 abandoned by Mholloway:
Allow deleting history entries outside the main namespace

Reason:
Found a better solution.

https://gerrit.wikimedia.org/r/228291

Change 230129 abandoned by Mholloway:
Add db query support for null selection arguments

Reason:
Dropping in favor of https://gerrit.wikimedia.org/r/#/c/231325/.

https://gerrit.wikimedia.org/r/230129

Change 231325 merged by jenkins-bot:
Update SQL query generation to handle mainspace and other null params

https://gerrit.wikimedia.org/r/231325

Checked with 2.0.108-alpha-2015-08-19 on Nexus5(Android 5.1)
Samsung Tablet Ce0168(Android 4.0.4)

T105471 was checked too(the same issue).

Change 227068 abandoned by Deskana:
Fix history entries only being deletable if they're in mainspace

Reason:
Issue resolved by other patches

https://gerrit.wikimedia.org/r/227068