This has broken twice now. Let's get it some test coverage.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Introduce tests for pagination | mediawiki/extensions/Gather | master | +60 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Anomie | T96858 Use "new" continuation by default | |||
| Resolved | • Niharika | T96864 Update API query continuation usage in Gather for future change of default | |||
| Resolved | • Niharika | T103496 Special:Gather/all/recent pagination is broken | |||
| Resolved | Jdlrobson | T103570 Create tests for pagination |
Event Timeline
Comment Actions
Change 220328 had a related patch set uploaded (by Jdlrobson):
WIP: Introduce tests for recent collections
Comment Actions
^^ @dduvall could you give me a hand with this?
I'm not sure how to scroll to the footer element nor how to only run the api request the first time the browser tests run.
Comment Actions
I just left you some feedback on the PS. Let me know if any of it doesn't make sense or if you want to pair on it.
As far as scrolling goes, I'm not actually sure what the best way would be. (Perhaps @zeljkofilipin knows.) I would maybe try:
10.times { browser.send_keys(:page_down) } # most end-to-end way
# or
browser.execute_script("window.scrollTo(0, window.outerHeight)") # not very BDD but it gets the job doneComment Actions
See also comment https://phabricator.wikimedia.org/T103496#1399670 since it is broken for anonymous users right now so when we test it let's test it for both anon and logged in please.
Thanks for adding these tests!!