Fragment encoding in heading anchors and in links differ
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Jun 24 2015, 5:12 PM

Description

The anchor of the heading and the link have different encoding:

== A&B&amp;C&amp;amp;D&amp;amp;amp;E ==
[[#A&B&amp;C&amp;amp;D&amp;amp;amp;E]]

The visualization does not differ: A&B&C&D&amp;E

The link does not match to the anchor of the heading.

The anchor of the heading is #A.26B.26C.26amp.3BD.26amp.3Bamp.3BE (also in TOC)
The link points to #A.26B.26C.26D.26amp.3BE

With enabled $wgExperimentalHtmlIds = true:

The anchor of the heading is #A_B_C_amp;D_amp;amp;E (also in TOC)
The link points to #A_B_C_D_amp;E

Expected result: The link should match to the anchor of the heading.

Details

Subject	Repo	Branch	Lines +/-
Update Parsoid to generate modern HTML5 IDs w/ legacy fallback	mediawiki/services/parsoid	master	+707 -260
Do not double decode HTML entities for IDs	mediawiki/core	master	+12 -11
Do not double decode HTML entities for IDs	mediawiki/core	master	+30 -16

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Fomafix	T103714 Fragment encoding in heading anchors and in links differ
		Resolved		Fomafix	T104311 Fragment encoding of autocomment on diff and history differ

Event Timeline

Fomafix created this task.Jun 24 2015, 5:12 PM

Fomafix raised the priority of this task from to Needs Triage.

Fomafix updated the task description. (Show Details)

Fomafix added a project: Parsing-Team--ARCHIVED.

Fomafix subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2015, 5:12 PM

Aklapper edited projects, added MediaWiki-Parser; removed Parsing-Team--ARCHIVED.Jun 24 2015, 8:17 PM

Aklapper set Security to None.

Fomafix updated the task description. (Show Details)Jun 29 2015, 10:57 AM

Fomafix mentioned this in T104196: Do not double decode HTML entities in indicator ID.Jun 29 2015, 1:39 PM

Change 221614 had a related patch set uploaded (by Gerrit Patch Uploader):
Do not double decode HTML entities for IDs

https://gerrit.wikimedia.org/r/221614

gerritbot added a project: Patch-For-Review.Jun 29 2015, 2:41 PM

Fomafix claimed this task.Jun 29 2015, 4:26 PM

Ricordisamoa subscribed.Jun 29 2015, 5:29 PM

Fomafix mentioned this in T104311: Fragment encoding of autocomment on diff and history differ.Jun 30 2015, 11:03 AM

Isn't this duplicate of T20431?

@Lahwaacz No, T20431 is a related but separate bug.

Change 286385 had a related patch set uploaded (by Gerrit Patch Uploader):
Do not double decode HTML entities for IDs

https://gerrit.wikimedia.org/r/286385

• ssastry triaged this task as Medium priority.Jan 4 2017, 6:38 PM

With https://gerrit.wikimedia.org/r/362167 I added parser tests that test for the current behavior.

Fomafix added a comment.Jun 29 2017, 11:39 AM

This comment was removed by Fomafix.

Change 221614 abandoned by Fomafix:
Do not double decode HTML entities for IDs

Reason:
Superseded by https://gerrit.wikimedia.org/r/286385.

https://gerrit.wikimedia.org/r/221614

Change 377659 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] [WIP] Update Parsoid to generate modern IDs w/ legacy fallback

https://gerrit.wikimedia.org/r/377659

Change 286385 merged by jenkins-bot:
[mediawiki/core@master] Do not double decode HTML entities for IDs

https://gerrit.wikimedia.org/r/286385

Fomafix closed subtask T104311: Fragment encoding of autocomment on diff and history differ as Resolved.Oct 4 2017, 7:30 AM

Fomafix closed this task as Resolved.Oct 4 2017, 7:32 AM

Fomafix removed a project: Patch-For-Review.

Change 377659 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Update Parsoid to generate modern HTML5 IDs w/ legacy fallback

https://gerrit.wikimedia.org/r/377659