Page MenuHomePhabricator
Create Task
Maniphest T169006

Correctly redirect in Parsoid /transform/wikitext/to/lint endpoint
Closed, ResolvedPublic
Actions

Description

In Parsoid /transform/wikitext/to/lint endpoint, if I provide just the page title and no revision ID or wikitext body parameter, the endpoint 302 redirects me to the URI with the latest page revision. However, 302 redirects instruct clients to change the request method from POST to GET, while Parsoid doesn't support GET for that endpoint. So the correct way of redirecting would be 307 redirect that doesn't allow the client to change the request method.

Alternatively, Parsoid should support GET for that endpoint, or make the revision parameter required if no body is provided.

Details

SubjectRepoBranchLines +/-
Redirect to the right pathmediawiki/services/parsoidmaster+5 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Jun 27 2017, 6:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2017, 6:17 PM
ssastry edited projects, added Parsoid, Parsoid-Web-API; removed Parsing-Team--ARCHIVED.Sep 6 2017, 4:54 PM
ssastry moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.
ssastry moved this task from Needs Triage to Linting on the Parsoid board.Sep 18 2017, 5:11 PM
gerritbot subscribed.Dec 6 2017, 11:04 PM

Change 395880 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T169006: Preserve request method when redirecting to oldid

https://gerrit.wikimedia.org/r/395880

gerritbot added a project: Patch-For-Review.Dec 6 2017, 11:04 PM
ssastry added a comment.Dec 8 2017, 7:15 PM

Interesting, I didn't know about this 302/307 distinction .. it appears (based on a quick read) that browsers de-facto handle 302s incorrectly which led to introduction of 307 for stricter compliance.

gerritbot added a comment.Dec 8 2017, 7:27 PM

Change 395880 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T169006: Preserve request method when redirecting to oldid

https://gerrit.wikimedia.org/r/395880

Arlolra closed this task as Resolved.Dec 8 2017, 8:19 PM
Arlolra claimed this task.
Stashbot mentioned this in T114072: <section> tags for MediaWiki sections.Dec 12 2017, 7:57 PM
Stashbot mentioned this in T181226: Don't output section wrappers in body_only mode.
Stashbot mentioned this in T21910: Headings of the form ===+\s+ are not preprocessed correctly..
Stashbot mentioned this in T152540: Migrate to HTML5 section ids.
Stashbot mentioned this in T103714: Fragment encoding in heading anchors and in links differ.
Stashbot mentioned this in T97093: Parsoid should mark interwiki links as such.
Stashbot mentioned this in T118520: Use <figure-inline> instead of <span> for inline figures..
Stashbot mentioned this in T181229: Content after reference tag in template disappears.
Stashbot mentioned this in T182338: Parsoid: Interwiki links with angle brackets should be invalid.
Stashbot mentioned this in T182170: Create new high-priority linter category for multiple unclosed formatting tags whose effects accumulate.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-12-12T19:57:07Z] <arlolra> Updated Parsoid to 741fc5d (T114072, T181226, T21910, T152540, T103714, T97093, T118520, T181229, T182338, T182170, T169006)

• Pchelolo reopened this task as Open.Feb 22 2018, 1:29 PM

Right now a POST to /v3/transform/wikitext/to/lint/{title} returns a 307 redirect to /en.wikipedia.org/v3/page/lint/{title}/{revision}, but the former URI doesn't exist - POST to it returns a 404, GET returns an error that {"error":"Invalid page format: lint"}.

The 307 redirect is preserving the request method, so it should point to /v3/transform/wikitext/to/lint/{title}/{revision}

Reopening.

Arlolra added a comment.Feb 22 2018, 6:08 PM

Gah, sorry

gerritbot added a comment.Feb 22 2018, 6:09 PM

Change 413425 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Redirect to the right path

https://gerrit.wikimedia.org/r/413425

gerritbot added a comment.Feb 26 2018, 9:07 PM

Change 413425 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Redirect to the right path

https://gerrit.wikimedia.org/r/413425

Arlolra closed this task as Resolved.Feb 26 2018, 9:09 PM
Stashbot mentioned this in T58756: Parsoid doesn't give external links class="external free|text".Feb 28 2018, 9:46 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-28T21:46:38Z] <arlolra> Updated Parsoid to 1415a2a (T58756, T169006)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits