Page MenuHomePhabricator
Create Task
Maniphest T104237

Show nicer previews of complex (timed, paged, …) media inside VisualEditor
Open, LowPublic8 Estimated Story Points
Actions

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jun 29 2015, 7:08 PM
Jdforrester-WMF raised the priority of this task from to Low.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki, TimedMediaHandler, Multimedia.
Jdforrester-WMF subscribed.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptJun 29 2015, 7:08 PM
Jdforrester-WMF added a project: Epic.Jun 29 2015, 7:08 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a parent task: T91574: Image for Audio Clip Resizes.
Jdforrester-WMF added a parent task: T103096: Preview video while editing with VE.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 29 2015, 9:23 PM
Jdforrester-WMF renamed this task from Show nicer previews of timed media inside VisualEditor to Show nicer previews of complex (timed, paged, …) media inside VisualEditor.Jul 3 2015, 10:21 PM
Jdforrester-WMF added a parent task: T100453: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon.
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 5:51 PM
Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 4:01 PM
TheDJ moved this task from To sort to Player on the TimedMediaHandler board.Oct 21 2015, 7:14 PM
TheDJ added a project: Kaltura player.Oct 26 2015, 8:33 PM
TheDJ moved this task from Backlog to VE/Parsoid on the Kaltura player board.May 10 2016, 12:41 PM
Jdforrester-WMF added a parent task: T64673: VisualEditor: Be able to set a non-image multi-paged item's display page (page=) in the media dialog.Mar 25 2017, 1:14 AM
Jdforrester-WMF added a subtask: T154709: Parsoid does not emit different HTML when the page=# property is set on paged media (PDFs/DjVus/TIFFs).Mar 25 2017, 1:25 AM
Arlolra closed subtask T154709: Parsoid does not emit different HTML when the page=# property is set on paged media (PDFs/DjVus/TIFFs) as Resolved.Apr 20 2017, 12:07 PM
Jdforrester-WMF added a comment.Apr 25 2017, 7:01 PM

Update now that Parsoid's change is live:

  • For paged media (PDFs/DjVu/etc.), correct previews are now done (because there's nothing VE needs to do beyond its current architecture).
  • For video media, it now shows the 'correct' preview (e.g. thumbtime is respected) but it doesn't show the "play" button, so it's not a perfect preview, and you can't play it, which is T103096: Preview video while editing with VE.
  • For audio media, the preview is wrong, and you can't play it.
TheDJ subscribed.EditedApr 25 2017, 8:25 PM

@Jdforrester-WMF the new html5 structure (for TMH) assumes that JS controls will be provided. If those are not provided, then a controls attribute needs to be added to enable the standard browser controls.

There was some discussion on this when we implemented it, but basically it comes down to: HTML5 video assumes that you can guarantee the same environment for all your content, or that you have different end points for different environments. You can't have JS in one environment and then no JS in the other, with the same HTML content.

So either add the video.js modules, or add custom JS to add the controls attribute for this specific situation.

Jdforrester-WMF mentioned this in T103096: Preview video while editing with VE.Apr 25 2017, 8:38 PM
Jdforrester-WMF removed a parent task: T103096: Preview video while editing with VE.
Jdforrester-WMF added a subtask: T103096: Preview video while editing with VE.
Jdforrester-WMF added a comment.Apr 25 2017, 8:45 PM
In T104237#3211514, @TheDJ wrote[…]

Moved to that task.

Jdforrester-WMF removed a parent task: T100453: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon.Apr 25 2017, 8:48 PM
Jdforrester-WMF added a subtask: T100453: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon.
Arlolra subscribed.Apr 25 2017, 9:02 PM
In T104237#3211134, @Jdforrester-WMF wrote:
  • For video media, it now shows the 'correct' preview (e.g. thumbtime is respected) but it doesn't show the "play" button, so it's not a perfect preview, and you can't play it, which is T103096: Preview video while editing with VE.
  • For audio media, the preview is wrong, and you can't play it.

Those are fixed in T64270 which is merged, and should go out soon.

Jdforrester-WMF added a subtask: T64270: Support video and audio content.Apr 25 2017, 9:03 PM
Jdforrester-WMF removed projects: Kaltura player, Epic, TimedMediaHandler.
Jdforrester-WMF set the point value for this task to 8.
In T104237#3211720, @Arlolra wrote:
In T104237#3211134, @Jdforrester-WMF wrote:
  • For video media, it now shows the 'correct' preview (e.g. thumbtime is respected) but it doesn't show the "play" button, so it's not a perfect preview, and you can't play it, which is T103096: Preview video while editing with VE.
  • For audio media, the preview is wrong, and you can't play it.

Those are fixed in T64270 which is merged, and should go out soon.

Ah, my apologies, I thought both T64270 and T154709 had gone out at the same time but I was wrong.

Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Apr 25 2017, 9:04 PM
Arlolra closed subtask T100453: VE does not display PDF thumbnails: Big empty box and (browser's) broken file icon as Resolved.May 23 2017, 10:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits