Page MenuHomePhabricator

Change some of the data attributes of A/V to data-file, for consistency
Closed, ResolvedPublic


As a general rule, attributes derived from inspection of the original media file (original size, bandwidth, framerate, etc) should get data-file- prefixes. Attributes of derived/transcoded media can be plain data- attributes.

Event Timeline

TheDJ created this task.Apr 26 2016, 11:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2016, 11:43 AM

Is this going to happen (but hasn't already)? If so, should this hold up the release (rather than be a breaking change)?

@Jdforrester-WMF This was done as part of T64270. I guess I'm leaving it open in case there's anything to be done for TimedMediaHandler.

Jdforrester-WMF closed this task as Resolved.Apr 26 2017, 8:16 PM
Jdforrester-WMF claimed this task.

I'll declare it done, then, and we can re-open if something's wrong. :-)

Some fat-fingering? Hello, @Arlolra, fellow Arlo.