Page MenuHomePhabricator
Create Task
Maniphest T104895

[Story] Stop using deprecated methods of Entity
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Remove usage of deprecated methodsmediawiki/extensions/Wikibasemaster+86 -56
Add missing redirect checks to EntityContent classesmediawiki/extensions/Wikibasemaster+38 -29
Remove usage of Entity::copymediawiki/extensions/Wikibasemaster+146 -157
Add missing EntityContent::isEmpty default implementationmediawiki/extensions/Wikibasemaster+36 -48
Move isEmpty and isStub to Item/PropertyContentmediawiki/extensions/Wikibasemaster+123 -14
Use getStatements instead of getClaims in EntityContent subclassesmediawiki/extensions/Wikibasemaster+23 -8
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
DeclinedBeneT98290 [Task] Remove deprecated methods from Entity and subtypes
ResolvedBeneT104895 [Story] Stop using deprecated methods of Entity
ResolvedAddshoreT64188 Replace old serialization code in lib with datamodel serialization
ResolveddanielT110177 [RFC] Add methods to EntityDocument
· · ·

Event Timeline

Bene created this task.Jul 6 2015, 6:58 PM
Bene claimed this task.
Bene raised the priority of this task from to Medium.
Bene updated the task description. (Show Details)
Bene added projects: Patch-For-Review, Wikidata, Wikidata-Sprint-2015-06-30.
Bene added subscribers: gerritbot, JanZerebecki, daniel and 4 others.
gerritbot added a comment.Jul 6 2015, 6:58 PM

Change 222978 had a related patch set uploaded (by Bene):
Remove usage of Entity::copy

https://gerrit.wikimedia.org/r/222978

gerritbot added a comment.Jul 6 2015, 6:59 PM

Change 222934 had a related patch set uploaded (by Bene):
Move isEmpty and isStub to Item/PropertyContent

https://gerrit.wikimedia.org/r/222934

Bene moved this task from Backlog to Review on the Wikidata-Sprint-2015-06-30 board.Jul 6 2015, 7:03 PM
Bene set Security to None.
Bene edited a custom field.
gerritbot added a comment.Jul 6 2015, 7:54 PM

Change 222895 had a related patch set uploaded (by Bene):
Use getStatements instead of getClaims in EntityContent subclasses

https://gerrit.wikimedia.org/r/222895

Bene added a subtask: T64188: Replace old serialization code in lib with datamodel serialization.Jul 6 2015, 7:57 PM
gerritbot added a comment.Jul 8 2015, 3:06 PM

Change 223563 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Avoid a little bit of code duplication in EntityContent classes

https://gerrit.wikimedia.org/r/223563

gerritbot added a comment.Jul 8 2015, 3:11 PM

Change 222895 merged by jenkins-bot:
Use getStatements instead of getClaims in EntityContent subclasses

https://gerrit.wikimedia.org/r/222895

Diffusion mentioned this in rMEXT1ed03d952278: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 8 2015, 3:11 PM
Bene mentioned this in rEWBA70cfde649cf6: Use getStatements instead of getClaims in EntityContent subclasses.Jul 8 2015, 3:11 PM
gerritbot added a comment.Jul 8 2015, 3:35 PM

Change 223567 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Alternative architecture of EntityContent::isStub

https://gerrit.wikimedia.org/r/223567

gerritbot added a comment.Jul 9 2015, 3:36 PM

Change 222934 merged by jenkins-bot:
Move isEmpty and isStub to Item/PropertyContent

https://gerrit.wikimedia.org/r/222934

Diffusion mentioned this in rMEXT42b1c40adb0a: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 9 2015, 3:36 PM
Bene mentioned this in rEWBA60e716291314: Move isEmpty and isStub to Item/PropertyContent.Jul 9 2015, 3:36 PM
gerritbot added a comment.Jul 14 2015, 12:53 PM

Change 223567 merged by jenkins-bot:
Add missing EntityContent::isEmpty default implementation

https://gerrit.wikimedia.org/r/223567

thiemowmde mentioned this in rMEXT67400e2c6301: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 14 2015, 12:53 PM
Addshore mentioned this in rEWBAa33aba8424f4: Add missing EntityContent::isEmpty default implementation.Jul 14 2015, 12:53 PM
gerritbot added a comment.Jul 14 2015, 9:15 PM

Change 222978 merged by Addshore:
Remove usage of Entity::copy

https://gerrit.wikimedia.org/r/222978

Addshore mentioned this in rEWBAfe7213d006c4: Remove usage of Entity::copy.Jul 14 2015, 9:15 PM
Bene mentioned this in rMEXTd16c1003f09a: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 14 2015, 9:15 PM
Ricordisamoa subscribed.Jul 16 2015, 4:00 PM
gerritbot added a comment.Jul 22 2015, 9:00 PM

Change 223563 merged by jenkins-bot:
Add missing redirect checks to EntityContent classes

https://gerrit.wikimedia.org/r/223563

Diffusion mentioned this in rMEXTa28047c0338f: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 22 2015, 9:00 PM
thiemowmde mentioned this in rEWBAfbb0e8e8f7a9: Add missing redirect checks to EntityContent classes.Jul 22 2015, 9:00 PM
JeroenDeDauw closed subtask T64188: Replace old serialization code in lib with datamodel serialization as Resolved.Aug 5 2015, 5:12 AM
daniel added a comment.Aug 5 2015, 3:07 PM

All patches are merged, is this done?

thiemowmde added a comment.Aug 5 2015, 3:55 PM

There are some usages left when I search for the usages of e.g. Entity::removeLabel. Since this is a crucial requirement for T98290: [Task] Remove deprecated methods from Entity and subtypes I think the ticket should stay open.

JanZerebecki added a project: Wikidata-Sprint-2015-08-11.Aug 13 2015, 1:16 AM
JanZerebecki moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-11 board.
Lydia_Pintscher added a project: Wikidata-Sprint-2015-08-18.Aug 18 2015, 1:21 PM
JanZerebecki moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-18 board.Aug 18 2015, 1:24 PM
• Jonas renamed this task from Stop using deprecated methods on Entity to [Task] Stop using deprecated methods on Entity.Aug 19 2015, 12:14 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Aug 20 2015, 9:09 AM
Bene moved this task from Review to Doing on the Wikidata-Sprint-2015-08-18 board.Aug 24 2015, 2:17 PM
thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Aug 25 2015, 10:01 AM
Addshore subscribed.Aug 25 2015, 11:39 AM

Is this really in review? I am not sure I can find any patches left/...?

Addshore moved this task from Review to Doing on the Wikidata-Sprint-2015-08-18 board.Aug 25 2015, 11:39 AM
Bene added a comment.Aug 25 2015, 11:40 AM

Nope, it's not. I'm working on another patch but it isn't on gerrit yet.

gerritbot added a comment.Aug 28 2015, 8:27 PM

Change 233921 had a related patch set uploaded (by Bene):
Remove usage of deprecated methods

https://gerrit.wikimedia.org/r/233921

Bene moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Aug 28 2015, 8:27 PM
• Jonas renamed this task from [Task] Stop using deprecated methods on Entity to [Task] Stop using deprecated methods of Entity.Aug 31 2015, 10:12 AM
• Jonas renamed this task from [Task] Stop using deprecated methods of Entity to [Story] Stop using deprecated methods of Entity.Aug 31 2015, 10:25 AM
• Jonas subscribed.Aug 31 2015, 10:30 AM

I made this a story and I would appreciate if people working on this would create a subtask for certain methods etc. , so the progress can be verified.
I also think that discussion of [T110177] needs to be finish before working an this.

gerritbot added a comment.Aug 31 2015, 10:48 AM

Change 233921 merged by jenkins-bot:
Remove usage of deprecated methods

https://gerrit.wikimedia.org/r/233921

Diffusion mentioned this in rMEXT3cb571635bef: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 31 2015, 10:48 AM
Bene mentioned this in rEWBA2594d28791c5: Remove usage of deprecated methods.Aug 31 2015, 10:48 AM
daniel closed subtask T110177: [RFC] Add methods to EntityDocument as Resolved.Aug 31 2015, 12:35 PM
Bene moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.Aug 31 2015, 6:15 PM
Lydia_Pintscher closed this task as Resolved.Sep 2 2015, 8:36 AM
Lydia_Pintscher subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits