Page MenuHomePhabricator
Create Task
Maniphest T106966

Mobile web wrongly uses desktop domain for load.php
Closed, ResolvedPublic
Actions

Description

https://en.m.wikipedia.org/wiki/Catwalk HTML source:

<link rel="apple-touch-icon" href="/static/apple-touch/wikipedia.png" />
<link rel="shortcut icon" href="/static/favicon/wikipedia.ico" />
<link rel="search" type="application/opensearchdescription+xml" href="/w/opensearch_desc.php" title="Wikipedia (en)" />
<link rel="EditURI" type="application/rsd+xml" href="//en.wikipedia.org/w/api.php?action=rsd" />
<link rel="copyright" href="//creativecommons.org/licenses/by-sa/3.0/" />
<link rel="alternate" type="application/atom+xml" title="Wikipedia Atom feed" href="/w/index.php?title=Special:RecentChanges&amp;feed=atom" />
<link rel="canonical" href="https://en.wikipedia.org/wiki/Runway_(fashion)" />
<link rel="stylesheet" href="//en.wikipedia.org/w/load.php?debug=false&amp;lang=en&amp;modules=ext.gather.menu.icon%7Cmediawiki.ui.button%2Cicon%7Cskins.minerva.base.reset%2Cstyles%7Cskins.minerva.content.styles%7Cskins.minerva.tablet.styles&amp;only=styles&amp;skin=minerva&amp;target=mobile&amp;*" />
<meta name="ResourceLoaderDynamicStyles" content="" />
<link rel="stylesheet" href="//en.wikipedia.org/w/load.php?debug=false&amp;lang=en&amp;modules=user.groups&amp;only=styles&amp;skin=minerva&amp;target=mobile&amp;user=Krinkle&amp;version=By7mXc%2Fa&amp;*" />
<script src="//en.wikipedia.org/w/load.php?debug=false&amp;lang=en&amp;modules=startup&amp;only=scripts&amp;skin=minerva&amp;target=mobile&amp;*"></script>
<script>if(window.mw){

Most references are relative (/static, /wiki). And most that use the desktop domain are meant to be canonical.

But the load.php references should probably be relative instead of absolute so that they make optimal use of SPDY.

Details

SubjectRepoBranchLines +/-
resourceloader: Don't call wfExpandUrl() on load.php urlsmediawiki/corewmf/1.26wmf22+2 -2
resourceloader: Don't call wfExpandUrl() on load.php urlsmediawiki/corewmf/1.26wmf23+2 -2
resourceloader: Don't call wfExpandUrl() on load.php urlsmediawiki/coremaster+2 -2
Remove hardcoded $wgCanonicalServer from $wgResourceBasePathoperations/mediawiki-configmaster+12 -21
Remove hardcoded $wgCanonicalServer from $wgResourceBasePathoperations/mediawiki-configmaster+12 -21
Update URL configuration for mobile when entering mobile modeoperations/mediawiki-configmaster+12 -6
Use absolute URLs to construct load.php requestsoperations/mediawiki-configmaster+5 -4
Use relative URLs to construct load.php requestsoperations/mediawiki-configmaster+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Jul 26 2015, 12:47 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Performance-Team, Web-Team-Backlog.
Krinkle added subscribers: Krinkle, ori, Catrope.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2015, 12:47 AM
Krinkle added a parent task: T94896: Optimize prod's resource domains for SPDY/HTTP2.Jul 26 2015, 12:47 AM
• KLans_WMF edited projects, added Reading-Web-Sprint-52-Zoolander; removed Web-Team-Backlog.Jul 27 2015, 5:10 PM
• KLans_WMF set Security to None.
• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson claimed this task.Jul 27 2015, 6:27 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson added a comment.Jul 27 2015, 6:36 PM

So the issue is $wgLoadScript = "{$wgServer}/w/load.php";

Here are some possible solutions:

  1. We drop wgServer from $wgLoadScript to make it relative.
  2. We redefine $wgServer in the mobile config (https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L1299)
  3. MobileFrontend should apply wgMobileUrlTemplate to the global in some way.

I'm leaning towards 1 or 2. I'm not 100% sure of the impact of 1. We could always do it for mobile first and then see if there is an fall out before applying globally.

Thoughts?

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jul 27 2015, 9:00 PM
Jdlrobson added a comment.Jul 28 2015, 8:59 PM

@Krinkle any thoughts on the best solution?

BBlack added a parent task: T95448: Move bits traffic to text/mobile clusters.Jul 30 2015, 6:11 PM
BBlack mentioned this in T95448: Move bits traffic to text/mobile clusters.
BBlack triaged this task as High priority.Jul 30 2015, 6:20 PM
BBlack subscribed.

Switching this to high. I noticed this while looking at bits hostname work, and realized that this is probably a problem for zero-rating by IP whitelists (zero-rated mobile traffic would be hitting load.php over the Desktop IPs, which are not whitelisted and thus might charge for traffic).

gerritbot subscribed.Jul 30 2015, 6:32 PM

Change 228042 had a related patch set uploaded (by Ori.livneh):
Use relative URLs to construct load.php requests

https://gerrit.wikimedia.org/r/228042

gerritbot added a project: Patch-For-Review.Jul 30 2015, 6:32 PM

Change 228042 merged by jenkins-bot:
Use relative URLs to construct load.php requests

https://gerrit.wikimedia.org/r/228042

gerritbot added a comment.Jul 30 2015, 6:48 PM

Change 228044 had a related patch set uploaded (by Ori.livneh):
Use absolute URLs to construct load.php requests

https://gerrit.wikimedia.org/r/228044

gerritbot added a comment.Jul 30 2015, 6:48 PM

Change 228044 merged by jenkins-bot:
Use absolute URLs to construct load.php requests

https://gerrit.wikimedia.org/r/228044

Jdlrobson reassigned this task from Jdlrobson to ori.Jul 30 2015, 6:54 PM
Jdlrobson subscribed.

I guess 1 was the preferred solution.

Jdlrobson moved this task from Doing to Ready for Signoff on the Reading-Web-Sprint-52-Zoolander board.Jul 30 2015, 6:54 PM
gerritbot added a comment.Jul 30 2015, 7:47 PM

Change 228122 had a related patch set uploaded (by Ori.livneh):
Update URL configuration for mobile when entering mobile mode

https://gerrit.wikimedia.org/r/228122

gerritbot added a comment.Jul 30 2015, 7:47 PM

Change 228122 merged by jenkins-bot:
Update URL configuration for mobile when entering mobile mode

https://gerrit.wikimedia.org/r/228122

ori closed this task as Resolved.Jul 30 2015, 7:50 PM

This is now fixed. The fix does not affect URL references in cached HTML, though.

ori mentioned this in rOMWCae8512898422: Use relative URLs to construct load.php requests.Jul 30 2015, 10:12 PM
ori mentioned this in rOMWC52e9f64188f7: Use absolute URLs to construct load.php requests.
ori mentioned this in rOMWC0dc9d41814ec: Update URL configuration for mobile when entering mobile mode.
BBlack added a comment.Jul 31 2015, 12:22 PM

The mobile cache refs should all be wiped now, too.

• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-52-Zoolander board.Aug 3 2015, 11:32 AM
Krinkle mentioned this in T108152: [Research] T106966 caused doubling for many module builds.Aug 6 2015, 5:18 AM
Krinkle mentioned this in rOMWCf41d6b0f65c4: Remove hardcoded $wgCanonicalServer from $wgResourceBasePath.Sep 15 2015, 7:55 PM
gerritbot added a comment.Sep 15 2015, 8:25 PM

Change 238537 had a related patch set uploaded (by Krinkle):
resourceloader: Don't call wfExpandUrl() on load.php urls

https://gerrit.wikimedia.org/r/238537

gerritbot added a comment.Sep 15 2015, 8:39 PM

Change 238543 had a related patch set uploaded (by Krinkle):
Remove hardcoded $wgCanonicalServer from $wgResourceBasePath

https://gerrit.wikimedia.org/r/238543

gerritbot added a comment.Sep 15 2015, 8:40 PM

Change 238544 had a related patch set uploaded (by Krinkle):
resourceloader: Don't call wfExpandUrl() on load.php urls

https://gerrit.wikimedia.org/r/238544

gerritbot added a comment.Sep 15 2015, 8:41 PM

Change 238545 had a related patch set uploaded (by Krinkle):
resourceloader: Don't call wfExpandUrl() on load.php urls

https://gerrit.wikimedia.org/r/238545

gerritbot added a comment.Sep 15 2015, 11:06 PM

Change 238543 merged by jenkins-bot:
Remove hardcoded $wgCanonicalServer from $wgResourceBasePath

https://gerrit.wikimedia.org/r/238543

Krinkle mentioned this in rOMWC1a06886c661b: Remove hardcoded $wgCanonicalServer from $wgResourceBasePath.Sep 15 2015, 11:07 PM
gerritbot added a comment.Sep 15 2015, 11:25 PM

Change 238537 merged by jenkins-bot:
resourceloader: Don't call wfExpandUrl() on load.php urls

https://gerrit.wikimedia.org/r/238537

Krinkle mentioned this in rMWb5e69c4ef621: resourceloader: Don't call wfExpandUrl() on load.php urls.Sep 15 2015, 11:25 PM
gerritbot added a comment.Sep 15 2015, 11:35 PM

Change 238545 merged by jenkins-bot:
resourceloader: Don't call wfExpandUrl() on load.php urls

https://gerrit.wikimedia.org/r/238545

gerritbot added a comment.Sep 15 2015, 11:36 PM

Change 238544 merged by jenkins-bot:
resourceloader: Don't call wfExpandUrl() on load.php urls

https://gerrit.wikimedia.org/r/238544

Krinkle mentioned this in rMW10cba27e177c: resourceloader: Don't call wfExpandUrl() on load.php urls.Sep 15 2015, 11:36 PM
Krinkle mentioned this in rMW9a8f4f75921e: resourceloader: Don't call wfExpandUrl() on load.php urls.
• MZMcBride subscribed.Sep 16 2015, 4:36 AM
Krinkle mentioned this in T113007: [Research] Investigate 30% load.php reqs increase since 2015-07-30.Sep 18 2015, 1:24 AM
ori mentioned this in rOPUP1ed45f8087c0: varnish: Don't disable Cache-Control for all mobile traffic.Sep 21 2015, 6:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL