Page MenuHomePhabricator

Quick and external surveys shows and look properly on the desktop version of the site
Closed, ResolvedPublic2 Estimated Story Points


If a configured survey is enabled, configured and targeted towards desktop, and bucketed to n% (n>0) of the users, those chosen users will see a widget with the question of the survey and the possible answers on the desktop site.

    1. AC:
  • Design looks good and as in desktop mockups. (Both quick and external surveys).


survey-desktop-02.png (1×1 px, 812 KB)

desktop-03.png (242×349 px, 8 KB)

Survey can be similar width to mobile, aligned right above any infobox or images if present.

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Ping @Moushira do you know what the state of the SecurePoll extension is?
@Fhocutt I see you are active on that extension... would you be open to such an enhancement to that extension? Really what we are looking for is a lightweight way of setting up a one-time in article global survey on a project.

Open question: where do we store the result?

@Jdlrobson EventLogging schema from what I've been told.

Jhernandez renamed this task from An enabled configured quick survey shows on the desktop version of the site to Quick and external surveys shows and look properly on the desktop version of the site.Aug 3 2015, 5:18 PM
Jhernandez updated the task description. (Show Details)
Jhernandez added a subscriber: KHammerstein.

@KHammerstein How are we going to make this look on desktop? Can we haz mockups please?

Jdlrobson edited a custom field.

Change 232221 had a related patch set uploaded (by Jdlrobson):
Survey should float to the right

The floating to the right is pretty straightforward, but to look like the mocks, we will have to rethink our algorithm for adding the survey to the page and add it before the first image.

Change 232222 had a related patch set uploaded (by Jdlrobson):
Insert survey before thumb when present.

@Jdlrobson Hmm I was thinking similar to mobile the survey would appear at the end of the lead section. So my mistake, that would place it below infobox and any image in lead section. Unless we can insert it at the beginning and just align right?

Can we compile a list of example articles to test this against?

We could... I'd rather tackle that separately in T104561 or at least make this block on T104561 though.
Thoughts @Jhernandez ?

@Jdlrobson I've added a blocking task to this and n T104561 to find test articles for desktop insertion for QuickSurveys. I'd appreciate a pass on it and edit description if necessary.

@Jdlrobson: I don't mind how it's implemented but I don't think we can do a release without being confident that we're putting the survey where it's supposed to go.

I'd expect the list of articles to be the equivalent of 1, 0, 999999999, a lizard, -1, sfdeljknesv.

Can someone clarify what more I need to do to get this merged.. ? :)
Is the test articles the only problem?
Are there specific problems we have found that you want me to fix?

Change 232221 abandoned by Jdlrobson:
Survey should float to the right

@bmansurov has a an inline comment on 232222 that needs addressing

Jdlrobson changed the task status from Open to Stalled.Aug 28 2015, 7:01 PM
This comment was removed by Jdlrobson.
Jdlrobson changed the task status from Stalled to Open.Aug 28 2015, 7:02 PM

Ignore. Wrong bug. < please can someone help get this merged before kick off so we can get the quick survey stuff out of the way?

someone feel free to fix this up whilst i'm out!

@rmoen @bmansurov @phuedx please help me get this merged so we can move on with design review etc..

Change 232222 merged by jenkins-bot:
Styling tweaks for Vector

@Jdlrobson Did you want to attach a screenshot or is this what you wanted to talk about over hangout?

Design review completed. Issues captured in a bug so signing this off.