Page MenuHomePhabricator
Create Task
Maniphest T110010

personal toolbar is shown in reverse in RTL wikis in the Special:ContentTranslation columns interface
Closed, ResolvedPublic
Actions

Assigned To
Amire80
Authored By
Amire80
Aug 24 2015, 7:42 AM
Tags
Referenced Files
F2646168: Screen Shot 2015-09-30 at 5.28.42 pm.png
Sep 30 2015, 11:59 AM
F2630060: screenshot2.png
Sep 24 2015, 3:49 AM
F2628008: screenshot2.png
Sep 23 2015, 12:25 PM
Subscribers
Aklapper
Amire80
Arrbee
gerritbot
Jdlrobson
Nikerabbit
santhosh

Description

Personal toolbar is shown in reverse in RTL wikis in the Special:ContentTranslation columns interface.

This is fixed for the dashboard in ext.cx.dashboard.less (T105688), and I can do the same for the columns interface, but it would be better to resolve it properly in the code of the Vector skin itself, so that it would even with the unusual way in which CX loads skins.

Details

SubjectRepoBranchLines +/-
Define explicit position for module ext.cx.header.skinmediawiki/extensions/ContentTranslationmaster+2 -1
Define explicit position for module ext.cx.header.skinmediawiki/extensions/ContentTranslationmaster+2 -1
Display the personal menu in the correct directionmediawiki/extensions/ContentTranslationmaster+19 -5
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Aug 24 2015, 7:42 AM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: RTL, Vector (legacy skin), ContentTranslation.
Amire80 subscribed.
Restricted Application added a project: I18n. · View Herald TranscriptAug 24 2015, 7:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 updated the task description. (Show Details)Aug 24 2015, 7:52 AM
Amire80 set Security to None.
gerritbot subscribed.Aug 24 2015, 7:52 AM

Change 233358 had a related patch set uploaded (by Amire80):
Display the personal menu in the correct direction

https://gerrit.wikimedia.org/r/233358

gerritbot added a project: Patch-For-Review.Aug 24 2015, 7:52 AM
Amire80 claimed this task.Aug 24 2015, 7:53 AM
Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.Aug 24 2015, 6:29 PM
Amire80 added a project: ContentTranslation-Release6.Aug 24 2015, 8:16 PM
Amire80 moved this task from Backlog to Bugs on the ContentTranslation-Release6 board.
Amire80 moved this task from Backlog to Content Translation on the RTL board.Aug 30 2015, 7:15 AM
Nikerabbit subscribed.Sep 11 2015, 12:22 PM

so that it would even with the unusual way in which CX loads skins.

You accidentally what?

gerritbot added a comment.Sep 23 2015, 8:52 AM

Change 233358 merged by jenkins-bot:
Display the personal menu in the correct direction

https://gerrit.wikimedia.org/r/233358

Nikerabbit mentioned this in rECTX9300207bf96c: Display the personal menu in the correct direction.Sep 23 2015, 8:53 AM
Diffusion mentioned this in rMEXTa3939459d9b1: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 23 2015, 8:53 AM
Nikerabbit added a project: LE-CX6-Sprint break.Sep 23 2015, 11:22 AM
Nikerabbit moved this task from Backlog to QA on the LE-CX6-Sprint break board.
santhosh subscribed.Sep 23 2015, 12:25 PM

I see multiple issues with the merged patch

I get the warning

Warning: OutputPage::getModuleStyles: style module should define its position explicitly: ext.cx.header.skin ResourceLoaderFileModule [Called from OutputPage::getModuleStyles in /home/santhosh/dev/wiki/core/includes/OutputPage.php at line 621] in /home/santhosh/dev/wiki/core/includes/debug/MWDebug.php on line 300

screenshot2.png (435×1 px, 73 KB)

Nikerabbit added a comment.Sep 23 2015, 1:13 PM
In T110010#1666099, @santhosh wrote:

I see multiple issues with the merged patch

You described one issue, what are the others?

gerritbot added a comment.Sep 23 2015, 1:27 PM

Change 240355 had a related patch set uploaded (by Amire80):
Define explicit position for module ext.cx.header.skin

https://gerrit.wikimedia.org/r/240355

santhosh added a comment.Sep 23 2015, 2:15 PM

You described one issue, what are the others?

In LTR page language, I see the personal toolbar items as shown in the screenshot. The listing of item in toolbar looks broken

Nikerabbit added a comment.Sep 23 2015, 3:22 PM

Probably side effect of the PHP notices, I don't see it.

gerritbot added a comment.Sep 23 2015, 8:13 PM

Change 240350 had a related patch set uploaded (by Amire80):
Define explicit position for module ext.cx.header.skin

https://gerrit.wikimedia.org/r/240350

gerritbot added a comment.Sep 23 2015, 8:14 PM

Change 240355 abandoned by Amire80:
Define explicit position for module ext.cx.header.skin

Reason:
Dupe of Ia65bd9a9c7d7d30e81f5b97bb3532cccc1ca58b3

https://gerrit.wikimedia.org/r/240355

gerritbot added a comment.Sep 23 2015, 8:46 PM

Change 240350 merged by jenkins-bot:
Define explicit position for module ext.cx.header.skin

https://gerrit.wikimedia.org/r/240350

Amire80 mentioned this in rECTX106b927da1ac: Define explicit position for module ext.cx.header.skin.Sep 23 2015, 8:46 PM
Nikerabbit mentioned this in rMEXTb60d1efd81ff: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 23 2015, 8:47 PM
santhosh added a comment.Sep 24 2015, 3:49 AM

This is what I see

screenshot2.png (165×911 px, 15 KB)

santhosh added a comment.Sep 24 2015, 4:11 AM

Ok, it was my outdated skins/Vector repo. Sorry.

Jdlrobson subscribed.Sep 28 2015, 3:52 PM

Anything we can help with on the Vector side? Did the patch fix the problem (I don't really understand what the problem is... screenshots/links would help)?

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 7:57 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 7:58 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 8:02 PM
Jdlrobson removed a project: Vector (legacy skin).Sep 29 2015, 10:40 PM

(Given fix was in ContentTranslation I don't see what is needed to be down in Vector so have removed the project)

Jdforrester-WMF removed a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
Arrbee subscribed.Sep 30 2015, 11:59 AM

Screen Shot 2015-09-30 at 5.28.42 pm.png (495×1 px, 171 KB)

Arrbee moved this task from QA to Done on the LE-CX6-Sprint break board.Sep 30 2015, 12:00 PM
Amire80 closed this task as Resolved.Oct 1 2015, 8:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits