Page MenuHomePhabricator

personal toolbar is shown in reverse in RTL wikis in the Special:ContentTranslation columns interface
Closed, ResolvedPublic

Description

Personal toolbar is shown in reverse in RTL wikis in the Special:ContentTranslation columns interface.

This is fixed for the dashboard in ext.cx.dashboard.less (T105688), and I can do the same for the columns interface, but it would be better to resolve it properly in the code of the Vector skin itself, so that it would even with the unusual way in which CX loads skins.

Event Timeline

Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added a subscriber: Amire80.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 set Security to None.

Change 233358 had a related patch set uploaded (by Amire80):
Display the personal menu in the correct direction

https://gerrit.wikimedia.org/r/233358

so that it would even with the unusual way in which CX loads skins.

You accidentally what?

Change 233358 merged by jenkins-bot:
Display the personal menu in the correct direction

https://gerrit.wikimedia.org/r/233358

I see multiple issues with the merged patch

I get the warning

Warning: OutputPage::getModuleStyles: style module should define its position explicitly: ext.cx.header.skin ResourceLoaderFileModule [Called from OutputPage::getModuleStyles in /home/santhosh/dev/wiki/core/includes/OutputPage.php at line 621] in /home/santhosh/dev/wiki/core/includes/debug/MWDebug.php on line 300

I see multiple issues with the merged patch

You described one issue, what are the others?

Change 240355 had a related patch set uploaded (by Amire80):
Define explicit position for module ext.cx.header.skin

https://gerrit.wikimedia.org/r/240355

You described one issue, what are the others?

In LTR page language, I see the personal toolbar items as shown in the screenshot. The listing of item in toolbar looks broken

Probably side effect of the PHP notices, I don't see it.

Change 240350 had a related patch set uploaded (by Amire80):
Define explicit position for module ext.cx.header.skin

https://gerrit.wikimedia.org/r/240350

Change 240355 abandoned by Amire80:
Define explicit position for module ext.cx.header.skin

Reason:
Dupe of Ia65bd9a9c7d7d30e81f5b97bb3532cccc1ca58b3

https://gerrit.wikimedia.org/r/240355

Change 240350 merged by jenkins-bot:
Define explicit position for module ext.cx.header.skin

https://gerrit.wikimedia.org/r/240350

Ok, it was my outdated skins/Vector repo. Sorry.

Anything we can help with on the Vector side? Did the patch fix the problem (I don't really understand what the problem is... screenshots/links would help)?

(Given fix was in ContentTranslation I don't see what is needed to be down in Vector so have removed the project)