Page MenuHomePhabricator

Standardize the naming of Echo's "panel"
Open, LowestPublic

Description

We've decided to use "panel". (The others are inaccurate or ambiguous)
We now need to standardize the existing usages of the words "flyout", "popup", and "overlay", and "dropdown", in

  • code (i18n)
  • documentation

Previous description

Echo's notification popup thingy is called the "overlay" or "flyout" inconsistently in different places including code and documentation. Decide upon one, and update everything to use that.

km@km-tp ~/p/v/m/e/Echo> ack flyout --php --js -c -h
47
km@km-tp ~/p/v/m/e/Echo> ack overlay --php --js -c -h
144

Ready, set, bikeshed.

Related Objects

Event Timeline

Legoktm created this task.Aug 25 2015, 6:40 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a project: Notifications.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 25 2015, 6:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm triaged this task as Lowest priority.Aug 25 2015, 6:41 AM

I am not sure we should reflect either of those in the API (as we discussed before) the API should probably output the data necessary, and the front end should build either a popup, a flyout, a dancing div or a special page.

That said, if we call it anything, we should call it a "popup" to make it match OOUI's naming.

If you're migrating it to OOUI, then not 'overlay' please, as that has a different meaning for OOUI widgets (it's a thing you pass to dropdown menus inside dialogs to make them work :P).

matmarex removed a subscriber: matmarex.Aug 25 2015, 8:02 AM

Popup is fine. Agreed it should not be in the API response.

Quiddity added a comment.EditedAug 25 2015, 11:36 PM

The documentation all calls it a flyout

According to https://en.wikipedia.org/wiki/Web_navigation#Styles_of_Web_Navigation it could either be a "drop down menu" or a "flyout menu".
Popup seems to be Apple-specific, per https://en.wikipedia.org/wiki/Drop-down_list ?

"Popup" would be a little bit (but not badly) ambiguous with Navpopups and Extension:Popups (Hovercards)

So, +1 for "flyout"

Quiddity renamed this task from Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent to Figure out whether the Echo notification popup is called a "panel" or "flyout" or "overlay" or "popup" and make usage consistent.Dec 30 2015, 8:52 PM
Quiddity updated the task description. (Show Details)
Quiddity set Security to None.
Quiddity renamed this task from Figure out whether the Echo notification popup is called a "panel" or "flyout" or "overlay" or "popup" and make usage consistent to Standardize the naming of Echo's "panel".Aug 8 2016, 9:54 PM
Quiddity updated the task description. (Show Details)
Quiddity updated the task description. (Show Details)Sep 28 2016, 9:18 PM