Spike: Release first version of QuickSurveys
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 25 2015, 4:35 PM

Description

Devs should get together and decide what the minimum is that needs to be done before performing a first release.
Dev branch should be merged into master with an stable version of the survey.

Add a changelog when merged, with a release number and list the features of the version.

Update https://www.mediawiki.org/wiki/Extension:QuickSurveys with the version and link to changelog on git.wikimedia.org

Related Objects
Search...

Status	Assigned	Task
Resolved	leila	T112326 [Epic] Reader segmentation research - Q2
Resolved	• jhobs	T113443 First QuickSurvey for reader segmentation research - external survey
Resolved	Jdlrobson	T111445 GOAL: Run our first survey campaign
Resolved	• jhobs	T110661 Deploy QuickSurveys extension to the English Wikipedia
Declined	None	T96785 In-channel feedback with star rating / picklist (and on apps, simple text entry?) and backend de-spam
Resolved	• Jhernandez	T104439 [GOAL]: Develop a mechanism for quick surveys on desktop + mobile
Resolved	• rmoen	T110199 Get QuickSurveys enabled on beta cluster
Resolved	Jdlrobson	T110200 Spike: Release first version of QuickSurveys
Resolved	Jdlrobson	T111292 Don't load Mustache and Hogan on mobile
Declined	None	T111472 QA: No browser tests covering QuickSurveys in mobile skin

Event Timeline

Jdlrobson created this task.Aug 25 2015, 4:35 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Reading-Web-Sprint-54-28-Days-Later.

Jdlrobson moved this task to Needs Analysis on the Reading-Web-Sprint-54-28-Days-Later board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2015, 4:35 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-54-28-Days-Later board.Aug 25 2015, 4:35 PM

Jdlrobson added a parent task: T110199: Get QuickSurveys enabled on beta cluster.

Specified description, set priority, moved to next sprint since this one is over and this is unplanned work.

@Jdlrobson Merge to master when the feature is usable enough to call it a version number :)

Jdlrobson updated the task description. (Show Details)Sep 2 2015, 3:04 PM

Jdlrobson renamed this task from Release first version of QuickSurveys to Spike: Release first version of QuickSurveys.Sep 2 2015, 4:43 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-55-π board.Sep 2 2015, 4:55 PM

@phuedx had these discussions points in T110194

No unit tests.
ext.quicksurveys.init/init.js uses jQuery to construct a potentially unnecessary DOM element,
Discussion of the oojs ui template view approach in general
Defer loading of ext.quicksurveys.views might not be necessary.

Thoughts around this:
unit tests: Given we are just displaying stuff, a lack of unit tests kinda makes sense. None of the code concerns me based on the assumption that oojs ui has lots of test coverage. It feels like browser tests are sufficient.
On PHP side SurveyFactory seems the only complicated thing there and that has unit tests.

Jdlrobson mentioned this in T110194: QuickSurveys code quality.Sep 4 2015, 5:14 PM

Jdlrobson merged a task: T110194: QuickSurveys code quality.Sep 4 2015, 5:16 PM

Jdlrobson added a subscriber: • bmansurov.

phuedx closed subtask T111292: Don't load Mustache and Hogan on mobile as Resolved.Sep 8 2015, 8:19 AM

Jdlrobson moved this task from To Do to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 8 2015, 4:05 PM