Page MenuHomePhabricator
Create Task
Maniphest T110492

Move Math specific CSS from core to extension
Closed, ResolvedPublic
Actions

Description

There is still some CSS in core related to the Math extension:
commonPrint.css, shared.css

This should be moved to the extension itself.

Details

SubjectRepoBranchLines +/-
Move Math specific CSS from core to extensionmediawiki/coremaster+0 -19
Move Math specific CSS from core to extensionmediawiki/extensions/Mathmaster+5 -0
Customize query in gerrit

Event Timeline

Schnark created this task.Aug 27 2015, 7:43 AM
Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added a project: Math.
Schnark subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2015, 7:43 AM
TheDJ subscribed.Aug 27 2015, 9:06 AM
Legoktm added projects: Technical-Debt, MediaWiki-User-Interface.Aug 28 2015, 7:18 AM
Legoktm set Security to None.
Physikerwelt claimed this task.Oct 31 2015, 9:24 AM
Physikerwelt triaged this task as Low priority.

I propose the following

  1. Add the styles to math extension style
  2. Remove styles from core
Schnark added a comment.Oct 31 2015, 9:37 AM
In T110492#1771068, @Physikerwelt wrote:
  1. Add the styles to math extension style

It should be checked whether the styles are still in use before moving them, at least the texhtml class seems to refer to the HTML display mode that was killed long time ago. If this class really is no longer used, then it should just be removed.

Physikerwelt added a comment.Oct 31 2015, 9:38 AM

I think span.texhtml and .texvc is never used. Please confirm.

Physikerwelt added a comment.Oct 31 2015, 9:39 AM

^^ cross post

gerritbot subscribed.Oct 31 2015, 9:41 AM

Change 250179 had a related patch set uploaded (by Physikerwelt):
Move Math specific CSS from core to extension

https://gerrit.wikimedia.org/r/250179

gerritbot added a project: Patch-For-Review.Oct 31 2015, 9:41 AM
Physikerwelt added a comment.EditedOct 31 2015, 9:43 AM

I wonder where texerror is defined.

gerritbot added a comment.Oct 31 2015, 9:57 AM

Change 250180 had a related patch set uploaded (by Physikerwelt):
Move Math specific CSS from core to extension

https://gerrit.wikimedia.org/r/250180

Physikerwelt added a comment.Nov 3 2015, 5:47 PM

Now, we need to find someone who is able to review this... I hope we don't get merge conflicts with https://phabricator.wikimedia.org/T106890

Physikerwelt moved this task from Inbox to Blocked: needs help on the Math board.Nov 3 2015, 5:48 PM
gerritbot added a comment.Nov 3 2015, 7:38 PM

Change 250179 merged by jenkins-bot:
Move Math specific CSS from core to extension

https://gerrit.wikimedia.org/r/250179

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 3 2015, 8:00 PM
gerritbot added a comment.Nov 10 2015, 7:08 PM

Change 250180 merged by jenkins-bot:
Move Math specific CSS from core to extension

https://gerrit.wikimedia.org/r/250180

ReleaseTaggerBot added a project: MW-1.27-release-notes.Nov 10 2015, 8:00 PM
Isarra moved this task from Backlog to Bugs on the MediaWiki-User-Interface board.Nov 10 2015, 10:07 PM
Jdforrester-WMF closed this task as Resolved.Nov 25 2015, 3:52 AM
Jdforrester-WMF subscribed.
Danny_B moved this task from Unsorted to Move on the Technical-Debt board.Apr 21 2016, 7:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits