Page MenuHomePhabricator
Create Task
Maniphest T111999

Convert Special:ListUsers autocompletion to use OOUI (Widget or HTMLForm)
Closed, ResolvedPublic
Actions

Description

With T105569: Special:ListUser's "Display users starting at" field should support autocompletion, Special:ListUsers uses mediawiki.usersuggest to autocomplete the user input field. That should be converted to OOUI to build this form and use the [[ https://github.com/wikimedia/mediawiki/blob/a2f75a52efe316d5fea1b5faf9cb094638b6adaf/includes/widget/UserInputWidget.php | UserInputWidget ]], an example usage is in [[ https://github.com/wikimedia/mediawiki/blob/master/includes/htmlform/HTMLUserTextField.php | HTMLUserTextField ]] for HTMLForm (maybe you can manage to use HTMLForm?). Using mediawiki.userSuggest in a new change feels false.

BeforeAfter
Screen Shot 2017-07-17 at 4.47.33 PM.png (123×1 px, 24 KB)
Screen Shot 2017-07-17 at 4.47.39 PM.png (428×1 px, 35 KB)

Details

SubjectRepoBranchLines +/-
WIP: Add new UserListInputWidget to MediaWiki widgetsmediawiki/coremaster+414 -56
Special:ListUsers: Use HTMLForm and OOUImediawiki/coremaster+76 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

Florian created this task.Sep 9 2015, 8:15 PM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added projects: MediaWiki-User-Interface, UI-Standardization.
Florian added subscribers: Florian, Legoktm, Rillke and 5 others.
Umherirrender unsubscribed.Sep 10 2015, 4:16 PM
gerritbot subscribed.Sep 12 2015, 6:29 PM

Change 237958 had a related patch set uploaded (by Florianschmidtwelzow):
WIP: Add new UserListInputWidget to MediaWiki widgets

https://gerrit.wikimedia.org/r/237958

gerritbot added a project: Patch-For-Review.Sep 12 2015, 6:29 PM
Florian added a parent task: T107037: Convert all MW core special pages to OOUI.Nov 4 2015, 5:18 PM
Liuxinyu970226 subscribed.Nov 6 2015, 2:36 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 6 2015, 2:36 PM
Liuxinyu970226 set Security to None.Nov 6 2015, 2:38 PM
Isarra moved this task from Backlog to General requests on the MediaWiki-User-Interface board.Nov 10 2015, 10:27 PM
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:29 PM
UtkarshGpta subscribed.Mar 12 2016, 12:06 PM
gerritbot added a comment.Aug 15 2016, 3:15 PM

Change 237958 abandoned by Florianschmidtwelzow:
WIP: Add new UserListInputWidget to MediaWiki widgets

https://gerrit.wikimedia.org/r/237958

gerritbot added a comment.Aug 15 2016, 6:21 PM

Change 237958 restored by Florianschmidtwelzow:
WIP: Add new UserListInputWidget to MediaWiki widgets

Reason:
hmm, naja... :( ... ... ok :D

https://gerrit.wikimedia.org/r/237958

gerritbot added a comment.Jul 2 2017, 11:30 AM

Change 362872 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] [wip] Special:ListUsers: Use HTMLForm and OOUI

https://gerrit.wikimedia.org/r/362872

• Prtksxna claimed this task.Jul 10 2017, 7:44 AM
matmarex closed this task as Resolved.Jul 13 2017, 6:19 PM
matmarex removed a project: Patch-For-Review.
gerritbot added a comment.Jul 13 2017, 6:25 PM

Change 362872 merged by jenkins-bot:
[mediawiki/core@master] Special:ListUsers: Use HTMLForm and OOUI

https://gerrit.wikimedia.org/r/362872

Volker_E subscribed.Jul 13 2017, 6:26 PM

@Prtksxna Please add a before/after screenshot table to the task description.

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 13 2017, 7:00 PM
Liuxinyu970226 unsubscribed.Jul 14 2017, 12:46 AM
• Prtksxna added a comment.Jul 17 2017, 11:40 AM
BeforeAfter
Screen Shot 2017-07-17 at 4.47.33 PM.png (123×1 px, 24 KB)
Screen Shot 2017-07-17 at 4.47.39 PM.png (428×1 px, 35 KB)
Volker_E updated the task description. (Show Details)Jul 17 2017, 2:32 PM
• Prtksxna added a comment.Jul 18 2017, 6:01 AM

See also T170804: CheckboxMultiselectWidget should have an option to use a HorizontalLayout.

• Prtksxna mentioned this in T171332: Checkboxes on Special:ListUsers don't work.Jul 22 2017, 1:58 AM
Volker_E mentioned this in T73441: Fix Special:ListUsers.Mar 19 2018, 5:38 AM
Volker_E added a comment.Mar 19 2018, 5:55 AM

Besides putting the checkboxes here in a HorizontalLayout (T170804) I see three more options to optimize this in vertical space:

  • Roll-out of 14px base in T97631
  • Using equal to 12px instead of the .oo-ui-fieldLayout's 1.25em right now
  • Making “User list” legend visible only to screenreaders
matmarex added a comment.Apr 5 2018, 5:38 PM

For reference, current look, after T97631 and some related whitespace changes:

image.png (364×959 px, 17 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits