Page MenuHomePhabricator
Create Task
Maniphest T112045

Parsoid lacks support for mustRender in the non-extension DataAccesses
Closed, DeclinedPublic
Actions

Description

For any file type where the handler returns true from mustRender(), such as SVG, PDF, DjVu, etc., the renderer is required to not attempt to link directly to the file in an <img/> tag. For example, for wikitext input [[File:Cross.svg]], the MW output is

<a href="/wiki/File:Cross.svg" class="image"><img alt="Cross.svg" src="//upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Cross.svg/32px-Cross.svg.png" width="32" height="32" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Cross.svg/48px-Cross.svg.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/8/8b/Cross.svg/64px-Cross.svg.png 2x" data-file-width="32" data-file-height="32" /></a>

whereas Parsoid attempts client-side scaling regardless of the file type:

...<img resource="./File:Cross.svg" src="//upload.wikimedia.org/wikipedia/commons/8/8b/Cross.svg" data-file-width="32" data-file-height="32" data-file-type="drawing" height="32" width="32" data-parsoid='...'/>

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix support for height parameter and mustRendermediawiki/extensions/ParsoidBatchAPImaster+47 -15
Fix support for height parameter and mustRendermediawiki/extensions/ParsoidBatchAPIwmf/1.26wmf22+47 -15
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT112045 Parsoid lacks support for mustRender in the non-extension DataAccesses
 OpenNoneT89971 ApiQueryImageInfo is crufty, needs rewrite
 OpenNoneT132947 Make it possible for extensions to add additional info to the fileinfo/imageinfo response.
 DeclinedNoneT134641 Make TextHandler use the timedtext videoinfo api for remoteDB sources
 InvalidNoneT187759 API is returning 500 status code
 OpenNoneT201205 Bad metadata for a single file errors out the complete imageinfo prop request
 InvalidNoneT235011 API query times out
 OpenBUG REPORTNoneT311633 Unable to get imageinfo only for the latest revision
 OpenNoneT67251 Query-continue for imageinfo returns timestamp which is ambiguous if multiple files were uploaded within the same second under the same file name
 OpenNoneT67264 File storage uses (title,timestamp) as a unique key, but this is not unique
 OpenLadsgroupT28741 Migrate file tables to a modern layout (image/oldimage; file/filerevision; add primary keys)
 ResolvedKrinkleT589 RFC: image and oldimage tables
 ResolvedLadsgroupT368113 Design and merge the new tables of file tables
 ResolvedmfornsT389800 Update Commons Impact Metrics to account for new File table
 ResolvedLadsgroupT383093 Set beta cluster to write both in file schema and thoroughly test it
 ResolvedLadsgroupT383491 Deploy new file tables in production
 ResolvedLadsgroupT383492 Write the migration script
 Resolved• ZabeT383496 Add support for reading new file schema into MediaWiki
 ResolvedDreamy_JazzT383555 Add support for reading new file schema in MediaModeration
 ResolvedLadsgroupT384481 Set new file tables to write both in production
 ResolvedLadsgroupT385167 Run data migration script for file migration
 DuplicateNoneT386133 Update Data Pipelines with new image table schema
 Resolved• ZabeT412164 Set beta cluster to read new in file schema and thoroughly test it
 OpenLadsgroupT415330 Add support for stop writing to the old file db schema
 Open• ZabeT416548 Start reading from file table on wmf production
 OpenPRODUCTION ERRORNoneT418007 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'Savannah_River_(26769689014).jpg' for key 'file_name'Function: MediaWiki\FileRepo\File\LocalFile::acquireFileIdFromNameQuery: INSERT INTO `file` (file_name,file_lates
 ResolvedPRODUCTION ERROR• ZabeT418327 PHP Deprecated: Caller from MediaWiki\Exception\MWExceptionHandler::rollbackPrimaryChanges ignored an error originally raised from MediaWiki\Pager\IndexPager::buildQueryInfo (MediaWiki\Specials\Pager\ImageListPager): [1054] Unk
 ResolvedPRODUCTION ERROR• ZabeT419062 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'img_timestamp' in 'WHERE'Function: MediaWiki\Pager\IndexPager::buildQueryInfo (MediaWiki\Specials\Pager\NewFilesPager)Query: SELECT /*! STRAIGHT_JOIN */ file_name AS
 ResolvedPRODUCTION ERROR• ZabeT422946 Expectation (readQueryTime <= 5) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:{query}
 ResolvedSecurity• ZabeT423654 Expectation (readQueryTime <= 5) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:{query}
 ResolvedBUG REPORTLadsgroupT423978 Special:Mediastatistics is being weird and not grouping similar file types together
 Open• ZabeT425191 Drop old image tables from wikireplicas

Event Timeline

tstarling created this task.Sep 10 2015, 6:47 AM
tstarling raised the priority of this task from to Needs Triage.
tstarling updated the task description. (Show Details)
tstarling added projects: Parsoid, Parsoid-Rendering.
tstarling subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 6:47 AM
tstarling added a subtask: T89971: ApiQueryImageInfo is crufty, needs rewrite.Sep 11 2015, 3:05 AM
gerritbot subscribed.Sep 14 2015, 1:12 AM

Change 238082 had a related patch set uploaded (by Tim Starling):
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238082

gerritbot added a project: Patch-For-Review.Sep 14 2015, 1:12 AM
tstarling added a comment.Sep 14 2015, 1:16 AM

The patch above fixes the issue only if the batch API is enabled.

gerritbot added a comment.Sep 14 2015, 11:00 PM

Change 238082 merged by jenkins-bot:
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238082

tstarling mentioned this in rMEXT1819b70a508b: Updated mediawiki/extensions Project: mediawiki/extensions/ParsoidBatchAPI….Sep 14 2015, 11:01 PM
gerritbot added a comment.Sep 14 2015, 11:21 PM

Change 238356 had a related patch set uploaded (by Tim Starling):
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238356

gerritbot added a comment.Sep 14 2015, 11:21 PM

Change 238356 merged by jenkins-bot:
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238356

tstarling mentioned this in rMW13214521a74b: Updated mediawiki/core Project: mediawiki/extensions/ParsoidBatchAPI….Sep 14 2015, 11:21 PM
ReleaseTaggerBot added projects: WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23).Sep 15 2015, 12:00 AM
ssastry triaged this task as Low priority.Sep 16 2015, 10:51 PM
ssastry removed a project: Patch-For-Review.
ssastry set Security to None.
ssastry removed a subscriber: gerritbot.
ssastry subscribed.

This support is now there in the Parsoid Batching API. If all testing goes well, that will be enabled in production next week. So, the only thing left here is support in the non-batching API. It is unclear how easy it is to do it there, and if the batching API becomes the default, it is low priority to do this for the non-batching API use case.

tstarling mentioned this in T113318: ParsoidBatchAPI doesn't normalize file titles.Sep 22 2015, 5:22 AM
ssastry mentioned this in T116840: Cached REST end point for imageinfo requests.Nov 3 2015, 11:33 PM
ssastry moved this task from Needs Triage to Read Views on the Parsoid board.Jan 11 2018, 9:37 PM
Reedy edited projects, added Parsoid-Read-Views-Deprecated-Project; removed Parsoid.Sep 17 2018, 7:25 PM
ssastry moved this task from Uncategorized to Missing functionality on the Parsoid-Read-Views-Deprecated-Project board.Sep 20 2018, 3:40 PM
Aklapper edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project.Feb 29 2020, 5:14 PM
ssastry moved this task from Read Views to Missing Functionality on the Parsoid board.Feb 29 2020, 5:31 PM
LGoto assigned this task to Arlolra.Jun 25 2020, 6:22 PM
LGoto moved this task from Missing Functionality to Needs Investigation on the Parsoid board.
Arlolra removed Arlolra as the assignee of this task.Jun 29 2020, 5:12 PM
Arlolra subscribed.
In T112045#1647399, @ssastry wrote:

This support is now there in the Parsoid Batching API. If all testing goes well, that will be enabled in production next week. So, the only thing left here is support in the non-batching API. It is unclear how easy it is to do it there, and if the batching API becomes the default, it is low priority to do this for the non-batching API use case.

Since the port, this is now implemented in the extension/ DataAccess but not the others. So, basically the same state as pre-port.

Arlolra renamed this task from Parsoid lacks support for mustRender to Parsoid lacks support for mustRender in the non-extension DataAccesses.Jun 29 2020, 5:14 PM
Arlolra moved this task from Needs Investigation to Missing Functionality on the Parsoid board.
MBinder_WMF closed this task as Declined.EditedJul 9 2020, 6:23 PM
MBinder_WMF added subscribers: SubrahamanyamVarma, MBinder_WMF.

@ssastry et al to explain why this was declined

Reedy removed a subscriber: SubrahamanyamVarma.Jul 9 2020, 6:28 PM
ssastry added a comment.Jul 9 2020, 9:41 PM

Previous comments explain that the original gaps in functionality have been long since addressed.

As for the last remaining bit, we don't use the non-extension DataAccess in production and it is an edge case usage for developer testing and there is no reason to spend cycles on this use case right now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits