Page MenuHomePhabricator

Special:Notifications has rendering issues on mobile
Closed, ResolvedPublic


The Special:Notifications page on mobile renders rather badly (e.g. ). This is highly visible and prominent in the mobile interface on slow connections.

2015-09-10 14.59.40.png (1×1 px, 169 KB)

*It should maximise it's use of whitespace (no padding at 320px)
*More info/preferences should not be cramped into the top left corner

  • Text should line up with the hamburger icon and never appear left of it.

Note: I would suggest using a media query at the 768px threshold to add the padding for desktop users.

Event Timeline

Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Notifications.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mattflaschen-WMF renamed this task from Special:Notifications not rendering on mobile to Special:Notifications has rendering issues on mobile.Sep 10 2015, 10:03 PM
Mattflaschen-WMF set Security to None.
Jdlrobson added a subscriber: Mooeypoo.

Edited since comment was confusing. We are removing the special page from MobileFrontend not the JavaScript overlay. I'm working with @Mooeypoo separately on consolidating code there with desktop.

Change 238083 had a related patch set uploaded (by Bmansurov):
Remove SpecialMobileNotifications

Change 238083 merged by jenkins-bot:
Remove SpecialMobileNotifications

Misleading patch hasn't fixed this problem. Echo team please let me know if you need help resolving this.

Misleading patch hasn't fixed this problem. Echo team please let me know if you need help resolving this.

So what did it do? From this task I have gleaned zero understanding of what the issue is, what was done, how well that worked out, what the current state of things is, and what is expected.

All information is in the description of this task. You and ignore the other task. Just take a look at the screenshot.

For background on the other task it had its own notifications code which was reinventing desktop code e.g. more link which had broken at some point. So we removed it. The code for the special page in Echo is where code changes need to be made.

An updated screenshot shows you've fixed it somewhat ( I don't know which patches removed the underlines but it looks better):
Main issue now seems to be the more info and preferences

Screen Shot 2015-09-15 at 9.36.02 AM.png (676×491 px, 85 KB)

kostajh claimed this task.
kostajh added a subscriber: kostajh.

This seems long-since done.