Page MenuHomePhabricator
Create Task
Maniphest T112191

Special:Notifications has rendering issues on mobile
Closed, ResolvedPublic
Actions

Description

The Special:Notifications page on mobile renders rather badly (e.g. https://m.mediawiki.org/wiki/Special:Notifications ). This is highly visible and prominent in the mobile interface on slow connections.

2015-09-10 14.59.40.png (1×1 px, 169 KB)

Expected:
*It should maximise it's use of whitespace (no padding at 320px)
*More info/preferences should not be cramped into the top left corner

  • Text should line up with the hamburger icon and never appear left of it.

Note: I would suggest using a media query at the 768px threshold to add the padding for desktop users.

Details

SubjectRepoBranchLines +/-
Remove SpecialMobileNotificationsmediawiki/extensions/MobileFrontendmaster+0 -227
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 10 2015, 10:01 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Notifications.
Jdlrobson subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 10 2015, 10:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson mentioned this in T112189: Remove SpecialMobileNotifications from MobileFrontend.Sep 10 2015, 10:01 PM
• Mattflaschen-WMF renamed this task from Special:Notifications not rendering on mobile to Special:Notifications has rendering issues on mobile.Sep 10 2015, 10:03 PM
• Mattflaschen-WMF set Security to None.
Quiddity updated the task description. (Show Details)Sep 11 2015, 12:00 AM
Quiddity updated the task description. (Show Details)Sep 11 2015, 12:03 AM
Jdlrobson updated the task description. (Show Details)Sep 11 2015, 12:09 AM
Jdlrobson added a subscriber: Mooeypoo.

Edited since comment was confusing. We are removing the special page from MobileFrontend not the JavaScript overlay. I'm working with @Mooeypoo separately on consolidating code there with desktop.

gerritbot subscribed.Sep 14 2015, 1:18 AM

Change 238083 had a related patch set uploaded (by Bmansurov):
Remove SpecialMobileNotifications

https://gerrit.wikimedia.org/r/238083

gerritbot added a project: Patch-For-Review.Sep 14 2015, 1:18 AM
gerritbot added a comment.Sep 14 2015, 6:38 PM

Change 238083 merged by jenkins-bot:
Remove SpecialMobileNotifications

https://gerrit.wikimedia.org/r/238083

• bmansurov mentioned this in rMEXT1ca9af55182b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 14 2015, 6:38 PM
• bmansurov mentioned this in rEMFR498e616d7011: Remove SpecialMobileNotifications.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 14 2015, 7:00 PM
Jdlrobson removed a project: Patch-For-Review.Sep 14 2015, 10:42 PM

Misleading patch hasn't fixed this problem. Echo team please let me know if you need help resolving this.

Catrope subscribed.Sep 15 2015, 9:18 AM
In T112191#1639551, @Jdlrobson wrote:

Misleading patch hasn't fixed this problem. Echo team please let me know if you need help resolving this.

So what did it do? From this task I have gleaned zero understanding of what the issue is, what was done, how well that worked out, what the current state of things is, and what is expected.

Jdlrobson added a comment.Sep 15 2015, 4:32 PM

All information is in the description of this task. You and ignore the other task. Just take a look at the screenshot.

For background on the other task it had its own notifications code which was reinventing desktop code e.g. more link which had broken at some point. So we removed it. The code for the special page in Echo is where code changes need to be made.

Jdlrobson updated the task description. (Show Details)Sep 15 2015, 4:35 PM

An updated screenshot shows you've fixed it somewhat ( I don't know which patches removed the underlines but it looks better):
Main issue now seems to be the more info and preferences

Screen Shot 2015-09-15 at 9.36.02 AM.png (676×491 px, 85 KB)

Quiddity edited projects, added Collab-Notifications-Page; removed Notifications.Apr 28 2016, 1:31 AM
Aklapper edited projects, added Growth-Team; removed Collaboration-Team-Triage.Oct 12 2019, 4:14 AM
kostajh closed this task as Resolved.Jan 30 2020, 2:14 PM
kostajh claimed this task.
kostajh subscribed.

This seems long-since done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits