webboy wrote:

Interwiki redirects shouldn't be in the redirect table OR should have the
interwiki-prefix.

From the redirect table on nlwiki_p (toolserver):
+---------+-------------------------------------+-------+-----------------------------+

+---------+-------------------------------------+-------+-----------------------------+

Contributions/Joep_Vullings |

Потребител_беседа:Bggoldie |

+---------+-------------------------------------+-------+-----------------------------+

Confirming this bug still exists in MW 1.10.1. The page content:

#REDIRECT [[Special:Listusers]]

causes an entry to appear on Special:Brokenredirects.

webboy wrote:

The problem with special pages can be fixed by the patch for bug 7890

rotemliss wrote:

(In reply to comment #1)

Interwiki redirects shouldn't be in the redirect table OR should have the
interwiki-prefix.

I think it's better to remove them from the redirect table, because they are not usable there.

rotemliss wrote:

Patch

This patch removes interwiki redirects from the redirect table. Note that an actual edit (not a blank edit or action=purge) on the redirect page is required for the redirect table update.

attachment patch ignored as obsolete

*** Bug 9960 has been marked as a duplicate of this bug. ***

Comment on attachment 4112
Patch

The proposed patch to bug 14418 makes this as easy as adding rd_interwiki != '' to the WHERE clause.

• Bug 21666 has been marked as a duplicate of this bug. ***

I don't see this any longer. Is this still a valid bug, or was the fix implemented?

This seems to still be a valid bug, using the basic query used in SpecialBrokenRedirects, adding in the rd_interwiki col, we get the below

mysql> SELECT p1.page_namespace AS namespace,p1.page_title AS title,rd_namespace,rd_title,rd_interwiki FROM mw_redirect LEFT JOIN mw_page p1 ON ((rd_from=p1.page_id)) LEFT JOIN mw_page p2 ON ((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title)) WHERE (rd_namespace >= 0) AND (p2.page_namespace IS NULL) ORDER BY rd_namespace, rd_title, rd_from LIMIT 50\g
+-----------+-------+--------------+----------+--------------+

+-----------+-------+--------------+----------+--------------+

+-----------+-------+--------------+----------+--------------+

[[Test2]] -> #REDIRECT [[wikipedia:Test]]

The following redirects link to non-existent pages:
Showing below up to 1 result starting with #1.
View (previous 50 | next 50) (20 | 50 | 100 | 250 | 500)
Test2 (edit | delete) → Test

So would look like this still needs fixing. But if the fix is so simple, we should do it and get this bug closed :)

Would

SELECT p1.page_namespace AS namespace,p1.page_title AS title,rd_namespace,rd_title,rd_interwiki FROM mw_redirect LEFT JOIN mw_page p1 ON ((rd_from=p1.page_id)) LEFT JOIN mw_page p2 ON ((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title)) WHERE (rd_namespace >= 0) AND (p2.page_namespace IS NULL) ORDER BY rd_namespace, rd_title, rd_from LIMIT 50\g

to

SELECT p1.page_namespace AS namespace,p1.page_title AS title,rd_namespace,rd_title,rd_interwiki FROM mw_redirect LEFT JOIN mw_page p1 ON ((rd_from=p1.page_id)) LEFT JOIN mw_page p2 ON ((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title)) WHERE (rd_namespace >= 0) AND (p2.page_namespace IS NULL) AND (rd_interwiki = '') ORDER BY rd_namespace, rd_title, rd_from LIMIT 50\g

(that is, adding "AND (rd_interwiki = '') "), be enough to fix this? That way the brroken redirect query isn't including things that redirect to IW

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

See also bug 40352 and 40353. Going to tackle this.

(In reply to comment #10)

This seems to still be a valid bug, using the basic query used in
SpecialBrokenRedirects, adding in the rd_interwiki col

[..]

(that is, adding "AND (rd_interwiki = '') "), be enough to fix this? That way
the brroken redirect query isn't including things that redirect to IW

I just ran into this bug on an old wiki that I upgraded from MediaWiki 1.8.2 to 1.20alpha.

That works indeed, except it also needs rd_interwiki IS NULL. For some reason it can be both null or empty string.

Fix in Ifee9fdcdd3a327742b18cfcc2a235e1e24c062bf.