Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | • Prtksxna | T114130 Improve error handling UX in the mw.ForeignStructuredUpload.BookletLayout | |||
Resolved | matmarex | T49395 jqueryMsg can not parse wikilink with parameters in page name |
Event Timeline
Change 242655 had a related patch set uploaded (by Prtksxna):
mediawiki.Upload.BookletLayout: Move error checking for uploadToStash to uploadFile
Change 242655 merged by jenkins-bot:
mw.Upload.BookletLayout: Move error checking for uploadToStash to uploadFile
Change 242717 had a related patch set uploaded (by Prtksxna):
mw.Upload.BookletLayout: Make all errors unrecoverable
Change 242723 had a related patch set uploaded (by Prtksxna):
mw.Upload.BookletLayout: Go back to upload page on upload error
Change 242717 merged by jenkins-bot:
mw.Upload.BookletLayout: Make all errors unrecoverable
Change 242723 merged by jenkins-bot:
mw.Upload.BookletLayout: Go back to upload page on upload error
Change 242899 had a related patch set uploaded (by Prtksxna):
mw.Upload: Add details of error when uploading to stash
Change 243144 had a related patch set uploaded (by Prtksxna):
mw.Upload.BookletLayout: Show errors and try to recover from warnings
Change 242899 merged by jenkins-bot:
mw.Upload: Add details of error when uploading to stash
Change 243144 merged by jenkins-bot:
mw.Upload.BookletLayout: Show errors and try to recover from warnings
I had mentioned this on Gerrit but then forgot about it. We are running into T55576: mediawiki.jqueryMsg double escapes HTML entities when using mw.message(key).parse() on a message containing a link and T49395: jqueryMsg can not parse wikilink with parameters in page name on a few error messages. It causes warnings in the console and the result look like this:
@matmarex mentioned on IRC that he'd be working on this soon. Not sure if we should re-open this task and mark the other bugs as blocking, or leave it as is.
Yeah, I can work on them some time this week.
Looking at the one in screenshot, I think that exhibits one more issue – jqueryMsg is not able to parse image syntax ([[File:Foo.jpg|thumb]]), and frankly I'm not sure if it should be able. We might need a separate message for this one, or to move the [[$1|thumb]] out of this message and to where it is actually used.
Change 243887 had a related patch set uploaded (by Prtksxna):
mw.Upload.BookletLayout: Add a catch all error state
What is the reason for putting a : before the argument in filepageexists? In our case it just gets appended before the name.
It's because of image thumbnail syntax. [[File:Docs.png]] would generate an embedded thumbnail (in the normal parser, jqueryMsg doesn't support that), [[:File:Docs.png]] generates a link to file page. The leading colon should be stripped, though…
Change 244226 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.jqueryMsg: Strip leading colon in wikilinks
Change 243887 merged by jenkins-bot:
mw.Upload.BookletLayout: Add a catch all error state
Change 244226 merged by jenkins-bot:
mediawiki.jqueryMsg: Strip leading colon in wikilinks