Page MenuHomePhabricator
Create Task
Maniphest T114362

Browser tests broken for Internet Explorer, Safari, Android and iOS
Closed, ResolvedPublic
Actions

Description

Noticed while working on T94151. I will delete the jenkins jobs since they are broken for a long time, but I will paste terminal output here. The jobs should be easy to recreate, if needed for debugging.

Android P2134

...
02:22:09   Scenario: Banner three is displayed for low roll # features/banners.feature:4
02:22:09   uninitialized constant MediawikiSelenium::BrowserFactory::Android (NameError)
02:22:09   /mnt/home/jenkins-deploy/.gem/2.0.0/gems/mediawiki_selenium-1.2.1/lib/mediawiki_selenium/browser_factory.rb:20:in `const_get'
...

iOS P2135

...
01:54:12   Scenario: Banner three is displayed for low roll # features/banners.feature:4
01:54:13   uninitialized constant Iphone (NameError)
01:54:13   /mnt/home/jenkins-deploy/.gem/2.0.0/gems/mediawiki_selenium-1.2.1/lib/mediawiki_selenium/browser_factory.rb:20:in `const_get'
...

Safari P2136

...
12:47:10   Scenario: Banner three is displayed for low roll # features/banners.feature:4
12:47:11   uninitialized constant MediawikiSelenium::BrowserFactory::Safari (NameError)
12:47:11   /mnt/home/jenkins-deploy/.gem/2.0.0/gems/mediawiki_selenium-1.2.1/lib/mediawiki_selenium/browser_factory.rb:20:in `const_get'
...

Internet Explorer P2137

...
11:48:11   Scenario: Banner three is displayed for low roll # features/banners.feature:4
11:48:11   uninitialized constant InternetExplorer (NameError)
11:48:11   /mnt/home/jenkins-deploy/.gem/2.0.0/gems/mediawiki_selenium-1.2.1/lib/mediawiki_selenium/browser_factory.rb:20:in `const_get'
...

Details

SubjectRepoBranchLines +/-
Delete broken CentralNotice browsertests Jenkins jobsintegration/configmaster+0 -23
Deleted failing Flow browsertests Jenkins jobintegration/configmaster+0 -7
Upgrade to the latest version of mediawiki_selenium Ruby gemmediawiki/extensions/MultimediaViewermaster+3 -3
Simplify instructions on releasing the gemmediawiki/seleniummaster+7 -27
Release patch version 1.6.3mediawiki/seleniummaster+8 -4
Support all SauceLabs provided browsersmediawiki/seleniummaster+87 -5
Customize query in gerrit

Related Objects

Event Timeline

zeljkofilipin created this task.Oct 1 2015, 1:12 PM
zeljkofilipin raised the priority of this task from to High.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a project: Browser-Tests-Infrastructure.
zeljkofilipin added subscribers: zeljkofilipin, hashar, AndyRussG, • dduvall.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2015, 1:12 PM
zeljkofilipin moved this task from Inbox to Gems on the Browser-Tests-Infrastructure board.Oct 1 2015, 1:13 PM
zeljkofilipin updated the task description. (Show Details)Oct 1 2015, 1:28 PM
zeljkofilipin set Security to None.
zeljkofilipin mentioned this in T94151: Fix or delete failing CentralNotice browsertests Jenkins jobs.Oct 1 2015, 1:31 PM
zeljkofilipin mentioned this in T94153: Fix Flow scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily.Oct 1 2015, 1:46 PM
zeljkofilipin added a subscriber: SBisson.
gerritbot subscribed.Oct 1 2015, 1:49 PM

Change 242880 had a related patch set uploaded (by Zfilipin):
Deleted broken CentralNotice browsertests Jenkins jobs

https://gerrit.wikimedia.org/r/242880

gerritbot added a project: Patch-For-Review.Oct 1 2015, 1:49 PM
gerritbot added a comment.Oct 1 2015, 1:52 PM

Change 242887 had a related patch set uploaded (by Zfilipin):
Deleted failing Flow browsertests Jenkins job

https://gerrit.wikimedia.org/r/242887

greg subscribed.Oct 1 2015, 3:24 PM

All broswer test for IE, Safari, Android, and iOS, or just some subset?

Why? Just long unmaintained or did something change?

(The title and description scare me as written :) )

AndyRussG added a comment.Oct 1 2015, 3:47 PM

@greg, in the case of CentralNotice, just unmaintained. As far as we know and have smoke-tested, CentralNotice banners work on these platforms. (There is a problem with IE versions 8 and 9--neither of which were included n tests, in any case.) It'd be great to have working tests for all of these... but, indeed, broken tests are distracting and worse than none. Hope to revive and work on these again soooon. :)

JanZerebecki renamed this task from Browser tests broken for Internet Explorer, Safari, Android and iOS to delete broken CentralNotice browser tests for Internet Explorer, Safari, Android and iOS.Oct 1 2015, 3:49 PM
greg added a comment.Oct 1 2015, 3:52 PM

Thanks @AndyRussG, and just confirmed with @zeljkofilipin, the title/description as written are accurate (but sad).

zeljkofilipin renamed this task from delete broken CentralNotice browser tests for Internet Explorer, Safari, Android and iOS to Browser tests broken for Internet Explorer, Safari, Android and iOS.Oct 1 2015, 4:36 PM
zeljkofilipin added a subscriber: JanZerebecki.

@JanZerebecki I have reverted your title change, jobs are broken for all repositories, not only CentralNotice.

gerritbot added a comment.Oct 5 2015, 12:39 PM

Change 242887 merged by jenkins-bot:
Deleted failing Flow browsertests Jenkins job

https://gerrit.wikimedia.org/r/242887

hashar mentioned this in rCICF2635d8452b63: Deleted failing Flow browsertests Jenkins job.Oct 5 2015, 12:39 PM
gerritbot added a comment.Oct 12 2015, 8:22 AM

Change 242880 merged by jenkins-bot:
Delete broken CentralNotice browsertests Jenkins jobs

https://gerrit.wikimedia.org/r/242880

gerritbot mentioned this in T94162: Fix VisualEditor scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily.Nov 2 2015, 1:55 PM
gerritbot mentioned this in T111525: No such file or directory - i18n/af.json (Errno::ENOENT).
Jdforrester-WMF awarded a token.Nov 2 2015, 3:35 PM
Jdforrester-WMF subscribed.
zeljkofilipin claimed this task.Nov 27 2015, 9:06 AM
zeljkofilipin moved this task from Gems to Next on the Browser-Tests-Infrastructure board.
zeljkofilipin removed zeljkofilipin as the assignee of this task.Dec 10 2015, 4:08 PM
• dduvall claimed this task.Dec 10 2015, 8:05 PM
• dduvall moved this task from Next to In Progress on the Browser-Tests-Infrastructure board.
gerritbot added a comment.Dec 11 2015, 1:04 AM

Change 258394 had a related patch set uploaded (by Dduvall):
Support all SauceLabs provided browsers

https://gerrit.wikimedia.org/r/258394

gerritbot added a comment.Dec 11 2015, 2:45 PM

Change 258394 merged by jenkins-bot:
Support all SauceLabs provided browsers

https://gerrit.wikimedia.org/r/258394

hashar added a comment.Dec 14 2015, 4:19 PM

So I guess we will now want a new release of mediawiki_selenium (1.7.0 ?) and bump all repositories :-}

zeljkofilipin added a comment.Dec 14 2015, 4:37 PM

@hashar that is my plan for this week.

zeljkofilipin removed • dduvall as the assignee of this task.Dec 14 2015, 5:50 PM
zeljkofilipin claimed this task.
gerritbot added a comment.Dec 15 2015, 2:04 PM

Change 259244 had a related patch set uploaded (by Zfilipin):
Release patch version 1.6.3

https://gerrit.wikimedia.org/r/259244

gerritbot added a comment.Dec 15 2015, 2:10 PM

Change 259244 merged by jenkins-bot:
Release patch version 1.6.3

https://gerrit.wikimedia.org/r/259244

gerritbot added a comment.Dec 15 2015, 2:19 PM

Change 259247 had a related patch set uploaded (by Zfilipin):
Simplify instructions on releasing the gem

https://gerrit.wikimedia.org/r/259247

gerritbot added a comment.Dec 15 2015, 2:39 PM

Change 259247 merged by jenkins-bot:
Simplify instructions on releasing the gem

https://gerrit.wikimedia.org/r/259247

gerritbot added a comment.Dec 15 2015, 2:52 PM

Change 259255 had a related patch set uploaded (by Zfilipin):
Upgrade to the latest version of mediawiki_selenium Ruby gem

https://gerrit.wikimedia.org/r/259255

gerritbot added a comment.Dec 15 2015, 2:59 PM

Change 259255 merged by jenkins-bot:
Upgrade to the latest version of mediawiki_selenium Ruby gem

https://gerrit.wikimedia.org/r/259255

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 15 2015, 3:00 PM
zeljkofilipin closed this task as Resolved.Dec 15 2015, 3:04 PM

Repositories will be updated while working on T114241: Update all repositories that use mediawiki_selenium Ruby gem to version 1.6.x.

hashar added a comment.Dec 16 2015, 10:17 AM

The mediawiki_selenium gem restores support for Android/IE as of version 1.6.3.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL