Page MenuHomePhabricator

Whitelist Paladox in Zuul configuration
Closed, ResolvedPublic


I am proposing to revisit CI whitelisting of @Paladox. Previous attempts have been made at the beginning of July 2015: by @aude by @hashar (dupe of above) by @Addshore (dupe again)

Been vetoed by Timo (and approved by others including myself) for good reason at that time:

User is sufficiently inexperienced that I would not trust him to not accidentally compromise our CI infrastructure.
He's known to often copy/paste arbitrary code and is still learning a lot. It'd be trivial for him to accidentally submit insecure or malicious code and compromise our CI servers.
Once our CI infrastructure is better isolated, this will no longer be a concern. At which point the plan is to simply remove this whitelist functionality and open it up to all accounts by default; rendering this addition no longer needed.

I @hashar have been reviewing a lot of his changes in September. He has shown willingness to improve and proposed a lot of additions. @Paladox has definitely been a key person in standardizing the composer/npm setup for MediaWiki extensions.

You can have a quick glance by browsing the long list of changes he made:,n,z

Moreover Paladox has CR+2 on a few repositories (label:Code-Review=2,user=Paladox is:merged`).

I believe it is time to whitelist him in CI without waiting for the isolated instances. Can we list the pro/con and reach a consensus ?

Reference: T106359 (semi private task)

Event Timeline

hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added subscribers: hashar, Krinkle, Paladox and 7 others.

Change 243244 had a related patch set uploaded (by Paladox):
Add Paladox to the whitelist

Was trying to add a subscriber that I thought wasent in the list.

hashar triaged this task as Medium priority.Oct 6 2015, 11:10 AM

A week has elapsed. I will get him whitelisted following the CI meeting on Tuesday. Added to the agenda

Change 215064 had a related patch set uploaded (by Hashar):
Add Paladox to the whitelist

Change 215064 merged by jenkins-bot:
Add Paladox to the whitelist

hashar claimed this task.

Change 243244 abandoned by Paladox:
Add Paladox to the whitelist

Merged here