Page MenuHomePhabricator

As a user I want to delete all my saved pages
Closed, ResolvedPublic3 Estimated Story Points

Description

Design here

  • The trash icon will be on left top and we will need a confirmation here. default ios action sheet with title.

    Event Timeline

    JMinor raised the priority of this task from to Medium.
    JMinor updated the task description. (Show Details)

    Hey, I don't think we should proceed with this design for a number of reasons. I'd rather not have delete all in the beta, than this.

    Reasoning:

    • The Trash is way too prominent visually
    • This is too easy to tap after taping a back from looking at articles
    • It doesn't match the look or flow of the Search history deletion.

    There are a number of alternatives here, but given that this is not a "must have" for beta, I am pushing this back onto Needs Design and removing the beta tag.

    @JMinor @Fjalapeno quick recap of ideas we discussed on hangout, which aren't all mutually exclusive:

    Section-only deletion

    Pros

    • Similar to Recent Searches UX

    Cons

    • No ability to delete all items in the list
    • Unless we group all old recent items (e.g. if all of them are by day), could be very tedious to clear everything

    Move to "Settings" view

    Pros

    • Super easy to implement
    • Similar to browser behavior (e.g. delete history/cookies/etc.)

    Cons

    • Not discoverable

    Pull to reveal menu below navigation bar

    Pros

    • Stays out of the way unless needed
    • Potential tie in w/ other features (e.g. filtering lists of articles by title and/or text)

    Cons

    • Harder to implement

    On behalf of @Mhurd, ideally this would be doable on saved & recent pages.

    Lets use this updated design. The text is less prominent than the icon was, and this design will work for both Saved and History.

    Checked with 5.0.0 (714) on iPad mini iOS 8.2 and iPhone 6 iOS 9.0.

    iPhone 6 iOS 9.0
    vertical position

    IMG_0108.PNG (1×640 px, 123 KB)

    landscape position
    IMG_0109.PNG (640×1 px, 147 KB)

    After clicking on 'Yes, delete all' , the following screen is displayed.

    IMG_0110.PNG (1×640 px, 42 KB)

    However, in iOS 8 'Cancel is not present (the same issue as in T126080: [5.0.0 (672)] iOS 8 - 'Cancel' is missing from menus).

    IMG_0571 (1).PNG (640×480 px, 206 KB)

    Edited the description of T126080 to reflect that it also applies to this menu. Bug is in ready for development.