Show not logged in error before uploading to stash in mw.Upload.BookletLayout
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Prtksxna
	Oct 19 2015, 2:13 PM

Description

Even though this happens pretty quickly, the user shouldn't have to select an image and wait for the upload request to find out that they aren not logged in.

Details

Subject	Repo	Branch	Lines +/-
mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form	mediawiki/core	master	+21 -1
Revert "mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form"	mediawiki/core	master	+0 -12
mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form	mediawiki/core	master	+12 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open	None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Resolved	matmarex	T119314 MWMediaDialog: exception "Local uploads are disabled"
Resolved	matmarex	T115866 Show not logged in error before uploading to stash in mw.Upload.BookletLayout
Resolved	matmarex	T117868 Factor out mw.user.getRights()/getGroups() into a mediawiki.api module (so that it can be used with ForeignApi)

Event Timeline

• Prtksxna created this task.Oct 19 2015, 2:13 PM

• Prtksxna raised the priority of this task from to Medium.

• Prtksxna updated the task description. (Show Details)

• Prtksxna added a project: Multimedia.

• Prtksxna added subscribers: Pginer-WMF, Jdforrester-WMF, • Prtksxna.

Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptOct 19 2015, 2:13 PM

matmarex added a project: MediaWiki-General.Oct 19 2015, 5:10 PM

Should use mw.user.getRights and check if the user is allowed to upload.

Here we want to frame it in a positive way ("you need to log-in to upload" ) as opposed to an error ("you forgot to log-in").

I think it makes sense to still keep a "disabled" version of the main entry point that informs about the need to log-in. That should include a clear call to action that allows the user to access the log-in form.

Change 248101 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.Upload.BookletLayout: If the user can't upload anything, don't give them the option to

https://gerrit.wikimedia.org/r/248101

gerritbot added a project: Patch-For-Review.Oct 22 2015, 7:34 PM

The patch above is a very barebones solution. For VE, it will keep the "Upload" tab, but display a short error message instead of the form.

It doesn't close this task: in addition to this being pretty poor UI, there are at least two problems with it under different MediaWiki configuration (see the commit message). But it'll do the job for now.

Change 248101 merged by jenkins-bot:
mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form

https://gerrit.wikimedia.org/r/248101

Change 248246 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form"

https://gerrit.wikimedia.org/r/248246

matmarex edited projects, added VisualEditor; removed Patch-For-Review.Oct 22 2015, 9:22 PM

matmarex set Security to None.

Change 248246 merged by jenkins-bot:
Revert "mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form"

https://gerrit.wikimedia.org/r/248246

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 22 2015, 10:00 PM

Would it be possible to show a link to the correct login page?

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Oct 26 2015, 4:00 PM

matmarex removed projects: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)), MW-1.27-release-notes.Oct 26 2015, 8:44 PM

Probably? We'd have to wait for the ForeignApi to be initialized, then query that to get the scripts paths and stuff for the foreign wiki, then we could make a working link. In Wikimedia config it is sufficient to log in on the local wiki.

https://gerrit.wikimedia.org/r/249567 should help with the first part of that.

Jdforrester-WMF edited a custom field.Nov 12 2015, 3:55 PM

Jdforrester-WMF moved this task from Untriaged to Next up on the Multimedia board.

matmarex added a parent task: T119314: MWMediaDialog: exception "Local uploads are disabled".Dec 8 2015, 3:41 PM

Change 257669 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form

https://gerrit.wikimedia.org/r/257669

gerritbot added a project: Patch-For-Review.Dec 8 2015, 7:13 PM

matmarex claimed this task.Dec 8 2015, 7:15 PM

Change 257669 merged by jenkins-bot:
mediawiki.Upload.BookletLayout: If the user can't upload, don't show them the form

https://gerrit.wikimedia.org/r/257669

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 15 2015, 5:00 PM

Jdforrester-WMF closed this task as Resolved.Dec 15 2015, 5:26 PM

Jdforrester-WMF closed subtask T117868: Factor out mw.user.getRights()/getGroups() into a mediawiki.api module (so that it can be used with ForeignApi) as Resolved.

Jdforrester-WMF removed a project: Patch-For-Review.