Page MenuHomePhabricator

Deleted topics deleted edits shouldn't appear in recent changes
Closed, ResolvedPublic

Description

Only the delete action should appear in recent changes if a topic has been deleted. This is for consistency with core behavior and to make recent changes cleaner. It's very hard to keep track of mw.org's rc due to the ongoing mass spam attack there.


The RecentChanges API has the same behavior as the page in this regard.

See also T116326: Hide all actions connected to deleted boards from RC and watchlist.

Event Timeline

Glaisher raised the priority of this task from to Needs Triage.
Glaisher updated the task description. (Show Details)
Glaisher subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It'd be nice if this could be prioritized and quickly fixed. Patrolling recent changes at MediaWiki.org is very hard currently due to the spam attack there.

Quiddity set Security to None.

Change 248314 had a related patch set uploaded (by Matthias Mullie):
Remove RC spam for moderated topics

https://gerrit.wikimedia.org/r/248314

Change 248314 merged by jenkins-bot:
Remove RC spam for moderated topics

https://gerrit.wikimedia.org/r/248314

Checked in betalabs - topic 'Topic1 to be deleted' was deleted from 'Talk:ET46'

  1. History before deletion:

Screen Shot 2015-10-27 at 3.24.25 PM.png (286×1 px, 160 KB)

History after topic deletion

Screen Shot 2015-10-27 at 3.25.47 PM.png (219×1 px, 154 KB)

  • 'changed the topic title' action is still there
  • 'commented' and 'created topic summary' actions are gone
    • previous delete/restore/hide actions on the topic also not filtered out
  1. 'Recent changes' - display references to actions in #1. 'Recent changes' match 'History' after topic deletion

Screen Shot 2015-10-27 at 3.30.37 PM.png (196×891 px, 65 KB)

  1. Watchlist - the same as History after topic deletion
  1. User contributions - the same as History after topic deletion

Should the following be addressed?

'changed the topic title' action is still there
previous delete/restore/hide actions on the topic also not filtered out

@Etonkovidova: did you get those results while you were logged in as a user who has the right to delete things? Does it look different if you're logged out?

I believe " previous delete/restore/hide actions on the topic also not filtered out" is by design.

I commented on the Gerrit about "'changed the topic title' action is still there ", didn't think it required blocking the change.

I believe what is wanted (please confirm, @Glaisher et al?) is for deleted topics to only show up in RC, as entries in the (deletion log).
E.g. (like for deleted pages) Grouped and ungrouped views:

4XefLha.png (264×873 px, 84 KB)

ycjF2Bh.png (309×903 px, 108 KB)

Other than the edit-title issue, we only show it once (no longer showing the comments, and only one line about the deletion, assuming there's a single deletion action):

This is from ungrouped RC (I made several comments before deleting). Elena showed some screenshots from grouped RC.

Topic deletion test.png (133×1 px, 45 KB)

Changing the rendering to use "(Deletion log)" is outside the scope of this task. This is about hiding other entries (comments made before the topic was deleted, mainly).

@Catrope
As user that has no right to delete ( the same View history is for non-logged users): the delete action does not display a topic title.
The topic title is displayed when a user clicks on the topic link.

Screen Shot 2015-10-28 at 1.33.24 PM.png (364×1 px, 143 KB)