Page MenuHomePhabricator
Create Task
Maniphest T116142

Phabricator login page does not show Welcome text / "Click button below" text anymore
Closed, ResolvedPublic
Actions

Description

STEPS:

  1. Open private window in browser
  2. Go to https://phabricator.wikimedia.org/
  3. Click icon in upper right corner
  4. End up on https://phabricator.wikimedia.org/auth/start/?next=%2F

EXPECTED OUTCOME:
T545 / https://gerrit.wikimedia.org/r/#/c/194126/ / https://phabricator.wikimedia.org/M7 had added custom text on top of the login page. It should have been displayed.

ACTUAL OUTCOME:
No text shown anymore at all. Hard to realize that I need to click the button at the bottom instead of entering MW OAuth login data into the LDAP fields.

Realized after T963#1741365

Details

SubjectRepoBranchLines +/-
Add custom header on login pagephabricator/extensionsmaster+13 -0
Remove auth.login-message - not supported by upstream anymoreoperations/puppetproduction+0 -44
Customize query in gerrit

Related Objects

Event Timeline

Aklapper created this task.Oct 21 2015, 9:02 AM
Aklapper raised the priority of this task from to High.
Aklapper updated the task description. (Show Details)
Aklapper added projects: Phabricator, Regression.
Aklapper added subscribers: Aklapper, • mmodell.
Restricted Application added a subscriber: scfc. · View Herald TranscriptOct 21 2015, 9:02 AM
Aklapper mentioned this in T963: Make the phabricator OAuth login UI more prominent.Oct 21 2015, 9:03 AM
Aklapper added a comment.Oct 21 2015, 9:27 AM

This regressed due to https://secure.phabricator.com/T9346

gerritbot subscribed.Oct 21 2015, 9:36 AM

Change 247793 had a related patch set uploaded (by Aklapper):
Remove auth.login-message - not supported by upstream anymore

https://gerrit.wikimedia.org/r/247793

gerritbot added a project: Patch-For-Review.Oct 21 2015, 9:36 AM
gerritbot added a comment.Oct 21 2015, 9:46 AM

Change 247794 had a related patch set uploaded (by Aklapper):
Add custom header on login page

https://gerrit.wikimedia.org/r/247794

Krenair subscribed.Oct 21 2015, 10:59 AM
Dzahn subscribed.EditedOct 22 2015, 2:23 PM

Do we want to do what it says in that linked upstream ticket?

" get equivalent behavior by putting a file like this in phabricator/src/extensions/:
CustomLoginHandler.php" ?

Nevermind. You already did :)

• chasemp mentioned this in T862: Redesign Phabricator login page: LDAP login too prominent; position of MediaWiki SUL login not prominent enough.Oct 22 2015, 5:22 PM
gerritbot added a comment.Oct 22 2015, 5:23 PM

Change 247793 merged by Rush:
Remove auth.login-message - not supported by upstream anymore

https://gerrit.wikimedia.org/r/247793

gerritbot added a comment.Dec 2 2015, 6:26 PM

Change 247794 merged by 20after4:
Add custom header on login page

https://gerrit.wikimedia.org/r/247794

Diffusion mentioned this in rPHEX840ee6e964dd: Add custom header on login page.Dec 2 2015, 6:26 PM
• mmodell mentioned this in rPHDEP8dfeca5488e1: Updated phabricator/deployment Project: phabricator/extensions….Dec 2 2015, 6:27 PM
• mmodell closed this task as Resolved.Dec 2 2015, 6:30 PM
• mmodell claimed this task.

fixed

greg added a project: Essential-Work.Jan 13 2016, 9:38 PM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJan 13 2016, 9:38 PM
Aklapper reopened this task as Open.Mar 29 2016, 11:05 PM
Aklapper removed a project: Patch-For-Review.

This broke again, see https://www.mediawiki.org/wiki/Topic:T0yz6r3gu00hdm8x

Krenair mentioned this in T131697: Phabricator asks to log in but does not show SUL dialog, and traps the user (starting on www.mediawiki.org and ending on m.mediawiki.org?).Apr 4 2016, 10:34 PM
greg removed • mmodell as the assignee of this task.Apr 5 2016, 8:26 PM
greg subscribed.Apr 5 2016, 8:47 PM

@Aklapper do you know if this is the same cause? (In general, I'd prefer new tasks rather than opening old ones when it's separate incidents)

Dzahn unsubscribed.Apr 11 2016, 5:35 PM
Aklapper added a comment.Apr 30 2016, 6:22 PM
In T116142#2181935, @greg wrote:

@Aklapper do you know if this is the same cause?

Not the same cause. It's simply the symlink missing on our server:

aklapper@iridium:/$ ls -al /srv/phab/extensions/CustomLoginHandler.php 
-rw-r--r-- 1 phab-deploy phab-deploy 817 Mar 24 00:45 /srv/phab/extensions/CustomLoginHandler.php
aklapper@iridium:/$ ls -al /srv/phab/phabricator/src/extensions/CustomLoginHandler.php
ls: cannot access /srv/phab/phabricator/src/extensions/CustomLoginHandler.php: No such file or directory
aklapper@iridium:/$

Assuming we have a neat deployment system (scap?) in place that I don't know much about, I don't know how to "properly" fix it myself.
@mmodell maybe?

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 30 2016, 6:22 PM
• mmodell closed this task as Resolved.May 2 2016, 3:32 PM
• mmodell claimed this task.
Aklapper mentioned this in T223926: Phabricator login page does not show Welcome text / "Click button below" text anymore.May 20 2019, 5:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits