Page MenuHomePhabricator

Phabricator login page does not show Welcome text / "Click button below" text anymore
Closed, ResolvedPublic

Description

STEPS:

  1. Open private window in browser
  2. Go to https://phabricator.wikimedia.org/
  3. Click icon in upper right corner
  4. End up on https://phabricator.wikimedia.org/auth/start/?next=%2F

EXPECTED OUTCOME:
T545 / https://gerrit.wikimedia.org/r/#/c/194126/ / https://phabricator.wikimedia.org/M7 had added custom text on top of the login page. It should have been displayed.

ACTUAL OUTCOME:
No text shown anymore at all. Hard to realize that I need to click the button at the bottom instead of entering MW OAuth login data into the LDAP fields.

Realized after T963#1741365

Event Timeline

Aklapper raised the priority of this task from to High.
Aklapper updated the task description. (Show Details)
Aklapper added subscribers: Aklapper, mmodell.

Change 247793 had a related patch set uploaded (by Aklapper):
Remove auth.login-message - not supported by upstream anymore

https://gerrit.wikimedia.org/r/247793

Change 247794 had a related patch set uploaded (by Aklapper):
Add custom header on login page

https://gerrit.wikimedia.org/r/247794

Do we want to do what it says in that linked upstream ticket?

" get equivalent behavior by putting a file like this in phabricator/src/extensions/:
CustomLoginHandler.php" ?

Nevermind. You already did :)

Change 247793 merged by Rush:
Remove auth.login-message - not supported by upstream anymore

https://gerrit.wikimedia.org/r/247793

Change 247794 merged by 20after4:
Add custom header on login page

https://gerrit.wikimedia.org/r/247794

mmodell claimed this task.

fixed

greg removed mmodell as the assignee of this task.Apr 5 2016, 8:26 PM

@Aklapper do you know if this is the same cause? (In general, I'd prefer new tasks rather than opening old ones when it's separate incidents)

@Aklapper do you know if this is the same cause?

Not the same cause. It's simply the symlink missing on our server:

aklapper@iridium:/$ ls -al /srv/phab/extensions/CustomLoginHandler.php 
-rw-r--r-- 1 phab-deploy phab-deploy 817 Mar 24 00:45 /srv/phab/extensions/CustomLoginHandler.php
aklapper@iridium:/$ ls -al /srv/phab/phabricator/src/extensions/CustomLoginHandler.php
ls: cannot access /srv/phab/phabricator/src/extensions/CustomLoginHandler.php: No such file or directory
aklapper@iridium:/$

Assuming we have a neat deployment system (scap?) in place that I don't know much about, I don't know how to "properly" fix it myself.
@mmodell maybe?

mmodell claimed this task.